[Sustainable Architecture] Telemetry schemas #201760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
reviewed
Nov 26, 2024
| @@ -10,5 +10,10 @@ | |||
| "output": "src/plugins/telemetry/schema/kbn_packages.json", | |||
| "root": "packages/", | |||
| "exclude": [] | |||
| }, | |||
| { | |||
| "output": "src/plugins/telemetry/schema/oss_platform.json", | |||
There was a problem hiding this comment.
I see the configs above make a distinction between "plugins" and "packages", producing different output files.
Is it okay to not do the distinction here?
There was a problem hiding this comment.
I think so... IMO, the main reason we had to do distinction is that they had different roots.
gsoldevila
reviewed
Nov 26, 2024
| const plugins = [ | ||
| ossPluginsTelemetrySchema, | ||
| ossPackagesTelemetrySchema, | ||
| ossPlatformTelemetrySchema, |
There was a problem hiding this comment.
I suppose this answers my question, as all schemas are merged here anyway.
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
cc @afharo |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12055251694 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 27, 2024
## Summary Since we are moving code around, the schema extractor now needs to adapt to the new directories. This PR adds new per-solution schemas to the `.telemetryrc.json` files and adapts FTRs accordingly. Related elastic#201653 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dac87ef)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 27, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Sustainable Architecture] Telemetry schemas (#201760)](#201760) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-11-27T17:18:09Z","message":"[Sustainable Architecture] Telemetry schemas (#201760)\n\n## Summary\n\nSince we are moving code around, the schema extractor now needs to adapt\nto the new directories.\n\nThis PR adds new per-solution schemas to the `.telemetryrc.json` files\nand adapts FTRs accordingly.\n\nRelated https://github.com/elastic/kibana/pull/201653\n\n### Checklist\n\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dac87ef6fec2ff2291ea72ffe5ec00588265500a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","technical debt","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Sustainable Architecture] Telemetry schemas","number":201760,"url":"https://github.com/elastic/kibana/pull/201760","mergeCommit":{"message":"[Sustainable Architecture] Telemetry schemas (#201760)\n\n## Summary\n\nSince we are moving code around, the schema extractor now needs to adapt\nto the new directories.\n\nThis PR adds new per-solution schemas to the `.telemetryrc.json` files\nand adapts FTRs accordingly.\n\nRelated https://github.com/elastic/kibana/pull/201653\n\n### Checklist\n\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dac87ef6fec2ff2291ea72ffe5ec00588265500a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201760","number":201760,"mergeCommit":{"message":"[Sustainable Architecture] Telemetry schemas (#201760)\n\n## Summary\n\nSince we are moving code around, the schema extractor now needs to adapt\nto the new directories.\n\nThis PR adds new per-solution schemas to the `.telemetryrc.json` files\nand adapts FTRs accordingly.\n\nRelated https://github.com/elastic/kibana/pull/201653\n\n### Checklist\n\n- [x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"dac87ef6fec2ff2291ea72ffe5ec00588265500a"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Since we are moving code around, the schema extractor now needs to adapt to the new directories. This PR adds new per-solution schemas to the `.telemetryrc.json` files and adapts FTRs accordingly. Related elastic#201653 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we are moving code around, the schema extractor now needs to adapt to the new directories.
This PR adds new per-solution schemas to the
.telemetryrc.jsonfiles and adapts FTRs accordingly.Related #201653
Checklist