Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-explore #202852

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 4, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

1 plugin(s) are going to be relocated:

Id Target folder
@kbn/ecs-data-quality-dashboard-plugin x-pack/solutions/security/plugins/ecs_data_quality_dashboard

8 packages(s) are going to be relocated:

Id Target folder
@kbn/cell-actions src/platform/packages/shared/kbn-cell-actions
@kbn/ecs-data-quality-dashboard x-pack/solutions/security/packages/ecs_data_quality_dashboard
@kbn/security-solution-features x-pack/solutions/security/packages/features
@kbn/security-solution-navigation x-pack/solutions/security/packages/navigation
@kbn/security-solution-side-nav x-pack/solutions/security/packages/side_nav
@kbn/security-solution-storybook-config x-pack/solutions/security/packages/storybook/config
@kbn/security-solution-upselling x-pack/solutions/security/packages/upselling
@kbn/securitysolution-ecs src/platform/packages/shared/kbn-securitysolution-ecs
Updated references
./.eslintrc.js
./.i18nrc.json
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/dev/storybook/aliases.ts
./src/platform/packages/shared/kbn-cell-actions/jest.config.js
./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js
./yarn.lock
Updated relative paths
src/platform/packages/shared/kbn-cell-actions/jest.config.js:12
src/platform/packages/shared/kbn-cell-actions/tsconfig.json:2
src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12
src/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2

Copy link
Contributor

github-actions bot commented Dec 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team labels Dec 4, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 4, 2024 08:22
@gsoldevila gsoldevila requested review from a team as code owners December 4, 2024 08:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-threat-hunting-explore branch from 3435a0e to 2879194 Compare December 5, 2024 06:15
@PhilippeOberti PhilippeOberti added Team:Threat Hunting:Explore and removed Team:Threat Hunting:Investigations Security Solution Investigations Team labels Dec 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-threat-hunting-explore branch from e25132a to 7b49c02 Compare December 10, 2024 16:09
@kapral18 kapral18 force-pushed the kbn-team-1309-move-kibana-security-threat-hunting-explore branch 3 times, most recently from d894861 to 76b2a21 Compare December 12, 2024 22:35
Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kapral18 kapral18 force-pushed the kbn-team-1309-move-kibana-security-threat-hunting-explore branch from 76b2a21 to 37b75d6 Compare December 13, 2024 15:19
@kapral18 kapral18 force-pushed the kbn-team-1309-move-kibana-security-threat-hunting-explore branch from 37b75d6 to 19b3abe Compare December 13, 2024 16:32
@kapral18 kapral18 enabled auto-merge (squash) December 13, 2024 17:40
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 13, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@kapral18 kapral18 merged commit f144078 into elastic:main Dec 13, 2024
9 checks passed
@kapral18 kapral18 deleted the kbn-team-1309-move-kibana-security-threat-hunting-explore branch December 13, 2024 18:48
@kapral18 kapral18 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 13, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12321534800

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12321534711

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202852

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202852

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Dec 15, 2024
…rity-threat-hunting-explore` (elastic#202852)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

#### 1 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/ecs-data-quality-dashboard-plugin` |
`x-pack/solutions/security/plugins/ecs_data_quality_dashboard` |

#### 8 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/cell-actions` | `src/platform/packages/shared/kbn-cell-actions`
|
| `@kbn/ecs-data-quality-dashboard` |
`x-pack/solutions/security/packages/ecs_data_quality_dashboard` |
| `@kbn/security-solution-features` |
`x-pack/solutions/security/packages/features` |
| `@kbn/security-solution-navigation` |
`x-pack/solutions/security/packages/navigation` |
| `@kbn/security-solution-side-nav` |
`x-pack/solutions/security/packages/side_nav` |
| `@kbn/security-solution-storybook-config` |
`x-pack/solutions/security/packages/storybook/config` |
| `@kbn/security-solution-upselling` |
`x-pack/solutions/security/packages/upselling` |
| `@kbn/securitysolution-ecs` |
`src/platform/packages/shared/kbn-securitysolution-ecs` |

<details >
<summary>Updated references</summary>

```
./.eslintrc.js
./.i18nrc.json
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/dev/storybook/aliases.ts
./src/platform/packages/shared/kbn-cell-actions/jest.config.js
./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js
./yarn.lock
```

</details><details >
<summary>Updated relative paths</summary>

```
src/platform/packages/shared/kbn-cell-actions/jest.config.js:12
src/platform/packages/shared/kbn-cell-actions/tsconfig.json:2
src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12
src/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2
```

</details>

---------

Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
(cherry picked from commit f144078)

# Conflicts:
#	.eslintrc.js
#	.github/CODEOWNERS
#	x-pack/.i18nrc.json
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 16, 2024
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Dec 16, 2024
…rity-threat-hunting-explore` (elastic#202852)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

#### 1 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/ecs-data-quality-dashboard-plugin` |
`x-pack/solutions/security/plugins/ecs_data_quality_dashboard` |

#### 8 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/cell-actions` | `src/platform/packages/shared/kbn-cell-actions`
|
| `@kbn/ecs-data-quality-dashboard` |
`x-pack/solutions/security/packages/ecs_data_quality_dashboard` |
| `@kbn/security-solution-features` |
`x-pack/solutions/security/packages/features` |
| `@kbn/security-solution-navigation` |
`x-pack/solutions/security/packages/navigation` |
| `@kbn/security-solution-side-nav` |
`x-pack/solutions/security/packages/side_nav` |
| `@kbn/security-solution-storybook-config` |
`x-pack/solutions/security/packages/storybook/config` |
| `@kbn/security-solution-upselling` |
`x-pack/solutions/security/packages/upselling` |
| `@kbn/securitysolution-ecs` |
`src/platform/packages/shared/kbn-securitysolution-ecs` |

<details >
<summary>Updated references</summary>

```
./.eslintrc.js
./.i18nrc.json
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/dev/storybook/aliases.ts
./src/platform/packages/shared/kbn-cell-actions/jest.config.js
./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js
./yarn.lock
```

</details><details >
<summary>Updated relative paths</summary>

```
src/platform/packages/shared/kbn-cell-actions/jest.config.js:12
src/platform/packages/shared/kbn-cell-actions/tsconfig.json:2
src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12
src/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12
x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2
```

</details>

---------

Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
(cherry picked from commit f144078)

# Conflicts:
#	.eslintrc.js
#	.github/CODEOWNERS
#	x-pack/.i18nrc.json
gsoldevila added a commit that referenced this pull request Dec 17, 2024
…c/security-threat-hunting-explore` (#202852) (#204327)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Sustainable Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting-explore`
(#202852)](#202852)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-13T18:46:30Z","message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting-explore` (#202852)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n#### 1 plugin(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/ecs-data-quality-dashboard-plugin`
|\r\n`x-pack/solutions/security/plugins/ecs_data_quality_dashboard`
|\r\n\r\n\r\n\r\n\r\n#### 8 packages(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/cell-actions` |
`src/platform/packages/shared/kbn-cell-actions`\r\n|\r\n|
`@kbn/ecs-data-quality-dashboard`
|\r\n`x-pack/solutions/security/packages/ecs_data_quality_dashboard`
|\r\n| `@kbn/security-solution-features`
|\r\n`x-pack/solutions/security/packages/features` |\r\n|
`@kbn/security-solution-navigation`
|\r\n`x-pack/solutions/security/packages/navigation` |\r\n|
`@kbn/security-solution-side-nav`
|\r\n`x-pack/solutions/security/packages/side_nav` |\r\n|
`@kbn/security-solution-storybook-config`
|\r\n`x-pack/solutions/security/packages/storybook/config` |\r\n|
`@kbn/security-solution-upselling`
|\r\n`x-pack/solutions/security/packages/upselling` |\r\n|
`@kbn/securitysolution-ecs`
|\r\n`src/platform/packages/shared/kbn-securitysolution-ecs`
|\r\n\r\n\r\n<details >\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./.eslintrc.js\r\n./.i18nrc.json\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/storybook/aliases.ts\r\n./src/platform/packages/shared/kbn-cell-actions/jest.config.js\r\n./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js\r\n./yarn.lock\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-cell-actions/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-cell-actions/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2\r\n```\r\n\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by:
Karen Grigoryan
<karen.grigoryan@elastic.co>","sha":"f1440787129c973fdae0a8fa419f8909029601ae","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team:Threat
Hunting:Explore","backport:prev-minor"],"number":202852,"url":"https://github.com/elastic/kibana/pull/202852","mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting-explore` (#202852)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n#### 1 plugin(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/ecs-data-quality-dashboard-plugin`
|\r\n`x-pack/solutions/security/plugins/ecs_data_quality_dashboard`
|\r\n\r\n\r\n\r\n\r\n#### 8 packages(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/cell-actions` |
`src/platform/packages/shared/kbn-cell-actions`\r\n|\r\n|
`@kbn/ecs-data-quality-dashboard`
|\r\n`x-pack/solutions/security/packages/ecs_data_quality_dashboard`
|\r\n| `@kbn/security-solution-features`
|\r\n`x-pack/solutions/security/packages/features` |\r\n|
`@kbn/security-solution-navigation`
|\r\n`x-pack/solutions/security/packages/navigation` |\r\n|
`@kbn/security-solution-side-nav`
|\r\n`x-pack/solutions/security/packages/side_nav` |\r\n|
`@kbn/security-solution-storybook-config`
|\r\n`x-pack/solutions/security/packages/storybook/config` |\r\n|
`@kbn/security-solution-upselling`
|\r\n`x-pack/solutions/security/packages/upselling` |\r\n|
`@kbn/securitysolution-ecs`
|\r\n`src/platform/packages/shared/kbn-securitysolution-ecs`
|\r\n\r\n\r\n<details >\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./.eslintrc.js\r\n./.i18nrc.json\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/storybook/aliases.ts\r\n./src/platform/packages/shared/kbn-cell-actions/jest.config.js\r\n./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js\r\n./yarn.lock\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-cell-actions/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-cell-actions/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2\r\n```\r\n\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by:
Karen Grigoryan
<karen.grigoryan@elastic.co>","sha":"f1440787129c973fdae0a8fa419f8909029601ae"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202852","number":202852,"mergeCommit":{"message":"Sustainable
Kibana Architecture: Move modules owned by
`@elastic/security-threat-hunting-explore` (#202852)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\n#### 1 plugin(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/ecs-data-quality-dashboard-plugin`
|\r\n`x-pack/solutions/security/plugins/ecs_data_quality_dashboard`
|\r\n\r\n\r\n\r\n\r\n#### 8 packages(s) are going to be
relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n|
`@kbn/cell-actions` |
`src/platform/packages/shared/kbn-cell-actions`\r\n|\r\n|
`@kbn/ecs-data-quality-dashboard`
|\r\n`x-pack/solutions/security/packages/ecs_data_quality_dashboard`
|\r\n| `@kbn/security-solution-features`
|\r\n`x-pack/solutions/security/packages/features` |\r\n|
`@kbn/security-solution-navigation`
|\r\n`x-pack/solutions/security/packages/navigation` |\r\n|
`@kbn/security-solution-side-nav`
|\r\n`x-pack/solutions/security/packages/side_nav` |\r\n|
`@kbn/security-solution-storybook-config`
|\r\n`x-pack/solutions/security/packages/storybook/config` |\r\n|
`@kbn/security-solution-upselling`
|\r\n`x-pack/solutions/security/packages/upselling` |\r\n|
`@kbn/securitysolution-ecs`
|\r\n`src/platform/packages/shared/kbn-securitysolution-ecs`
|\r\n\r\n\r\n<details >\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./.eslintrc.js\r\n./.i18nrc.json\r\n./docs/developer/plugin-list.asciidoc\r\n./package.json\r\n./packages/kbn-repo-packages/package-map.json\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/dev/storybook/aliases.ts\r\n./src/platform/packages/shared/kbn-cell-actions/jest.config.js\r\n./src/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js\r\n./yarn.lock\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nsrc/platform/packages/shared/kbn-cell-actions/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-cell-actions/tsconfig.json:2\r\nsrc/platform/packages/shared/kbn-securitysolution-ecs/jest.config.js:12\r\nsrc/platform/packages/shared/kbn-securitysolution-ecs/tsconfig.json:2\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/jest.config.js:15\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:12\r\nx-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.json:2\r\n```\r\n\r\n</details>\r\n\r\n---------\r\n\r\nCo-authored-by:
Karen Grigoryan
<karen.grigoryan@elastic.co>","sha":"f1440787129c973fdae0a8fa419f8909029601ae"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 17, 2024
@rudolf rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Threat Hunting:Explore v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants