Remove bfetch plugin

[lukasolson]

Summary

Part of #186139.

Relies on #204284.

Second step of breaking up #199066 into smaller pieces.

Removes the bfetch and bfetch-error plugins.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[pheyos]

x-pack/test/tsconfig.json changes LGTM

[nreese]

Would it be possible to refactor x-pack/test/api_integration/apis/maps/bsearch.ts to use search API? These tests have value ensuring responses required by maps do not change shape.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 8413d9e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
bfetch	27	-	-27

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/bfetch-error	1	-	-1
bfetch	59	-	-59
total			-60

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
bfetch	1	-	-1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
bfetch	2	-	-2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
bfetch	6.8KB	-	-6.8KB
kbnUiSharedDeps-srcJs	3.5MB	3.5MB	-390.0B
total			-7.2KB

Unknown metric groups

API count

id	before	after	diff
@kbn/bfetch-error	4	-	-4
bfetch	60	-	-60
total			-64

ESLint disabled in files

id	before	after	diff
bfetch	1	-	-1

ESLint disabled line counts

id	before	after	diff
bfetch	4	-	-4

Total ESLint disabled count

id	before	after	diff
bfetch	5	-	-5

History

• 💚 Build #261603 succeeded 498a587
• 💔 Build #261551 failed 42b62a1
• 💔 Build #261504 failed 5530bfa
• 💔 Build #261474 failed 48e6019
• 💔 Build #261175 failed febf7da
• 💔 Build #260926 failed d0dc079

cc @lukasolson

[lukasolson]

Would it be possible to refactor x-pack/test/api_integration/apis/maps/bsearch.ts to use search API? These tests have value ensuring responses required by maps do not change shape.

👍 8ecf1af

[nreese]

kibana-presentation changes LGTM
code review only

[afharo]

kibana.jsonc changes LGTM

[mattkime]

codeowner changes lgtm

[mattkime]

Please, out of respect for the proud legacy of the bfetch code, play this while merging - https://www.youtube.com/watch?v=2d37ij4EWGg

[markov00]

Visualization code changes look good to me!

[eokoneyo]

Changes; deletions of the bfetch plugin, LGTM

[jughosta]

LGTM 👍

[jasonrhodes]

Re: obs-ux-management changes and removing stale refs: I grepped our plugins for bfetch references and saw none and Kibana loads with no errors. LGTM!