Reactify users roles #20739
Reactify users roles #20739
Conversation
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@bmcconaghy are we sure we are ok removing the email address field? Since this is still part of the Elasticsearch User Management API, it seems strange that we don't support it in the UI as at least an optional field. |
|
@legrego added the email field back in |
|
Thanks, @bmcconaghy! I'll take a look this afternoon |
| id="username" | ||
| name="username" | ||
| ng-model="user.username" | ||
| required pattern="[a-zA-Z_][a-zA-Z0-9_@\-\$\.]*" |
There was a problem hiding this comment.
I think we lost this validation -- I can create a user with a username consisting of just special characters. It looks like ES (or maybe Kibana itself) strips out some of those characters, so the username I typed isn't the username that was actually saved.
There was a problem hiding this comment.
Good catch, added that back in.
| @@ -96,6 +96,8 @@ export class EditUser extends Component { | |||
| const { username } = this.state.user; | |||
| if (username !== null && !username) { | |||
| return 'Username is required'; | |||
| } else if (!username.match(validUsernameRegex)) { | |||
| return 'Username contains invalid character(s)'; | |||
There was a problem hiding this comment.
I'm sorry to be such a pest... can we use the original error message here? I feel like it'd be more helpful to users trying to figure out what they did wrong:
Username must begin with a letter or underscore and contain only letters, underscores, and numbers
There was a problem hiding this comment.
Lol, you're not being a pest, should have just gotten the original error message in the first place.
|
Just pulled this down again and getting a weird error when I click
My instance has only system/reserved users. |
|
@jen-huang that's what I get for making changes w/o testing :( . Just pushed a fix. |
💚 Build Succeeded |
* partial progress on reactifying users * progress on EUIfication of users screen * removing Angular stuff * adding data-test-subj="passwordConfirmationInput" * removing data-test-subj="userFormEmailInput" refs from tests * fixing selector for role assignment * some functional test fixes * fixing some functional tests * fixing last functional test * removing stray console log * fixing warnings * attempting to fix flaky test * trying again to fix flaky test * PR feedback * PR feedback * fixing issue where form tried to submit * adding sleep to allow user to load * Design edits Mainly adding wrapper EUI page elements, but also shifted around form elements. * Fixed console error and added responsive prop to table * addressing PR feedback * A few more PR feedback - Fixed alignment of table - Removed the tooltip from the lock icon and placed the description inline. - Changed delete button to an empty button * addressing more PR feedback * adding email field back in * adding back username validation * restoring original error message * fixing dumb null error
* partial progress on reactifying users * progress on EUIfication of users screen * removing Angular stuff * adding data-test-subj="passwordConfirmationInput" * removing data-test-subj="userFormEmailInput" refs from tests * fixing selector for role assignment * some functional test fixes * fixing some functional tests * fixing last functional test * removing stray console log * fixing warnings * attempting to fix flaky test * trying again to fix flaky test * PR feedback * PR feedback * fixing issue where form tried to submit * adding sleep to allow user to load * Design edits Mainly adding wrapper EUI page elements, but also shifted around form elements. * Fixed console error and added responsive prop to table * addressing PR feedback * A few more PR feedback - Fixed alignment of table - Removed the tooltip from the lock icon and placed the description inline. - Changed delete button to an empty button * addressing more PR feedback * adding email field back in * adding back username validation * restoring original error message * fixing dumb null error
This PR updates the new Role Management screen to use the public role API introduced as part of #20732. Additionally, this updates the breadcrumb nav for Spaces and Role management screens to be consistent with the nav introduced in #20739. There are a couple of visual glitches in this PR which are a result of current defects on master, so they can be safely ignored for the time being.
This PR converts the users list and edit users screen of security management to use EUI. It is intended to be a straight port with no modifications. One exception to this is that the email field for users has been removed (it is not used anywhere).