Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add aria-label to calendar and jobs list buttons #21922

Merged
merged 2 commits into from
Aug 14, 2018
Merged

[ML] Add aria-label to calendar and jobs list buttons #21922

merged 2 commits into from
Aug 14, 2018

Conversation

peteharverson
Copy link
Contributor

Adds aria-label to various buttons on the Calendar management pages which were missing the property. Also adds in details of the job(s) to the aria-label used on various controls in the Jobs List:

  • Edit calendar button (including calendar ID)
  • Delete calendar button (including calendar ID)
  • Delete calendar event (including event description)
  • View results buttons on the Jobs List (adds job ID / number of jobs)
  • Hide / show details button on the Jobs List (adds job ID)

Fixes #20187

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit fee34f7 into elastic:master Aug 14, 2018
@peteharverson peteharverson deleted the ml-table-action-aria-labels branch August 14, 2018 12:50
peteharverson added a commit to peteharverson/kibana that referenced this pull request Aug 14, 2018
@peteharverson
[ML] Add aria-label to calendar and jobs list buttons (elastic#21922)
714ce2a 
* [ML] Add aria-label to calendar and jobs list buttons

* [ML] Simplify building of Jobs List expanded row icon aria-label
@peteharverson peteharverson mentioned this pull request Aug 14, 2018
Merged
peteharverson added a commit that referenced this pull request Aug 14, 2018
@peteharverson
[ML] Add aria-label to calendar and jobs list buttons (#21922) (#21959)
660775c 
* [ML] Add aria-label to calendar and jobs list buttons

* [ML] Simplify building of Jobs List expanded row icon aria-label
@peteharverson peteharverson mentioned this pull request Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml Project:Accessibility release_note:enhancement review v6.5.0 v7.0.0 WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peteharverson @elasticmachine @walterra @jgowdyelastic