Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add aria-label to calendar and jobs list buttons #21922

Merged
merged 2 commits into from
Aug 14, 2018
Merged

[ML] Add aria-label to calendar and jobs list buttons #21922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83eb828
[ML] Add aria-label to calendar and jobs list buttons
peteharverson Aug 13, 2018
0e18a0b
[ML] Simplify building of Jobs List expanded row icon aria-label
peteharverson Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/public/jobs/jobs_list/components/job_actions/results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function ResultLinks({ jobs }) {
<EuiButtonIcon
href={getLink('timeseriesexplorer', jobs)}
iconType="stats"
aria-label="View results in single metric viewer"
aria-label={`Open ${tooltipJobs} in Single Metric Viewer`}
className="results-button"

/>
Expand All @@ -60,7 +60,7 @@ export function ResultLinks({ jobs }) {
<EuiButtonIcon
href={getLink('explorer', jobs)}
iconType="tableOfContents"
aria-label="View results in anomaly explorer"
aria-label={`Open ${tooltipJobs} in Anomaly Explorer`}
className="results-button"
/>
</EuiToolTip>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export class JobsList extends Component {
<EuiButtonIcon
onClick={() => this.toggleRow(item)}
iconType={this.state.itemIdToExpandedRowMap[item.id] ? 'arrowDown' : 'arrowRight'}
aria-label={this.state.itemIdToExpandedRowMap[item.id] ? 'Hide details' : 'Show details'}
aria-label={this.state.itemIdToExpandedRowMap[item.id] ? `Hide details for ${item.id}` : `Show details for ${item.id}`}
data-row-id={item.id}
/>
)
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/public/settings/scheduled_events/calendars_list/calendars_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
ng-attr-tooltip="{{buttonChecks.newButtonWrapperTooltip()}}">
<button
class="kuiMenuButton kuiMenuButton--basic kuiMenuButton--iconText"
title="Edit"
aria-label="Edit {{calendar.calendar_id}}"
ng-disabled='buttonChecks.newButtonDisabled()'
ng-click="editCalendarClick(calendar.calendar_id)">
<span class="kuiMenuButton__icon kuiIcon fa-pencil"></span>
Expand All @@ -114,7 +114,7 @@
ng-attr-tooltip="{{buttonChecks.deleteButtonWrapperTooltip()}}">
<button
class="kuiMenuButton kuiMenuButton--danger kuiMenuButton--iconText"
title="Edit"
aria-label="Delete {{calendar.calendar_id}}"
ng-disabled='buttonChecks.deleteButtonDisabled()'
ng-click="deleteCalendarClick(calendar.calendar_id)"
href="" >
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/settings/scheduled_events/components/events_list/events_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
<div class="kuiMenuButtonGroup kuiMenuButtonGroup--alignRight">
<button
class="kuiMenuButton kuiMenuButton--danger kuiMenuButton--iconText"
title="Edit"
aria-label="Delete {{event.description}}"
ng-disabled="lockControls === true"
ng-click="deleteEvent(event)"
href="">
Expand Down