Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GIS] plugin #24804

Merged
merged 836 commits into from
Dec 19, 2018
Merged

[GIS] plugin #24804

merged 836 commits into from
Dec 19, 2018

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Oct 30, 2018 •
edited by nreese
Loading

For discussion purposes only.

Hi:

  • 👛 es geohash grid soures need to be able to configured to either return centroid points or geohash-rectangles, so they can be used in the vector-layer and styled accordingly
  • 👛 es geohash grid sources need to be able to have their data query configured (so not just counts)
  • 🐛 attribution must display on map
  • 🐛 time-aware layers seem to refresh twice on time-change. once after the time-change, and once on the first extent change
  • 🐛 @aaronjcaldwell auto-refresh of time doesnt work
  • 🐛 @thomasneirynck data-refresh seems to be buggy (likely all related)
    • 🐛 for es search sources, the fitlered-by-map bound flag seems to be always false.(Source#getGeoJson should not have time and extent filters if they shouldn't be applied to begin with)
  • 🐛 saving workspaces that cross dateline (consider punting on it too)
  • 🐛 updating style (e.g. with sliders), should be debounced so we don't do a full render round-trip for each little change
  • 🐛 temporary-status of style should not affect opacity

Mid:

  • 👛 @thomasneirynck basic point and line styling (otherwise we're limited to just visualizing polygons from ES)
  • 🐛 extent-aware filtering does not seem to work on map pan/zoom
  • 🐛 @nreese cancel button should work for ALL layer properties (e.g. label, zoom-settigs, ...), not just style-settings
  • 🐛 zooming sometimes seems to jitter

Low:

  • 👛 when previewing a layer in the add-layer panel, the map should fit to the data, and then, after adding snap back to the previous extent
  • 👛 @aaronjcaldwell WMS data source
  • 🐛 currently can enable tooltip without fields, which actually results in no tooltip. should be a warning to the user that no fields have been specified for tooltip
  • 👛 @aaronjcaldwell user needs to be able to select from default set of icons. color and outline of icon needs to be styled statically. size needs to be able to be styled dynamically. consider mapbox default symbol set

Functional test cases:

  • Can save a workspace
  • Can load a saved workspace
    • Applies workspace time to Kibana global time
    • Applies workspace map center and zoom
    • Applies workspace layers
  • es_search_source
    • should add request to inspector
    • should not requery data when next extent is contained within old extent (ie. when zooming in) and we received all documents
    • should requery data when next extent is contained within old extent (ie. when zooming in)
  • es_geohashgrid_source
    • should add request to inspector
    • should not requery data when next extent is contained within old extent (ie. when zooming in)
    • should requery data when next extent is contained within old extent (ie. when zooming in) and precision changes

thomasneirynck and others added 30 commits October 17, 2018 23:48
@thomasneirynck
sync dynamic-settings in UX
9d7b0d7
@thomasneirynck
deal with empty properties
8544cb0
Import mappings as default export, not module
0ab201b
Update saved workspaces to filter out data on new state shape. Use 'g…
bc43ddc 
…is-app' rather than 'config' saved object
Merge branch 'enh/gis-plugin' of github.com:elastic/kibana into enh/g…
3b441f5 
…is-plugin
Only permit x-pack licensed users to use GIS App, first pass
6389bd9
Fix ems license typo
18fe7cf
Just use placeholder content in license verification for now
8d050e0
@thomasneirynck
some fixes to data updates
0eaa9be 
some fixes to data updates
@thomasneirynck
Merge branch 'enh/gis-plugin' of github.com:elastic/kibana into enh/g…
400845f 
…is-plugin
@thomasneirynck
do not update layer if no time-change
e2774b7
Make store available outside of async method. Will always be resolved…
434b719 
… by time of app load
Make color assignment state-aware
78efbff
Merge branch 'enh/gis-plugin' of github.com:elastic/kibana into enh/g…
88e556f 
…is-plugin

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Merge branch 'enh/gis-plugin' of github.com:elastic/kibana into enh/g…
603172c 
…is-plugin
Minor optimization
2257ea2
@thomasneirynck
simplify actions/style updating
0421ba8
@thomasneirynck
Merge branch 'enh/gis-plugin' of github.com:elastic/kibana into enh/g…
a621f80 
…is-plugin
@thomasneirynck
trigger reflow when there are join updates
343c46f
@thomasneirynck
temp remove limit setting
2798d28
@thomasneirynck
fix map extent filtering
b14b261
@thomasneirynck
disable joining for layers that have extent-filtering
19eefaa
@thomasneirynck
temporary disable tooltip switch, to simplify demo-scenario
496793b
@thomasneirynck
turn off dark theme (simplify demo scenario)
a996a86
@thomasneirynck
fix details
aba3d96
@thomasneirynck
make display-name async so we can do better effort for human-readable…
781e2b9 
… name
@thomasneirynck
increase limit
e58ba1e
@thomasneirynck
remove some todos
b4e5693
@thomasneirynck
disable zoom level switch
c140ee8
@thomasneirynck
remove crufty button from tms xyz layer
0b8a128
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor

nreese commented Dec 19, 2018

test failure looks like flaky test in Kibana CI group 11

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

nreese
nreese reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nreese
nreese approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kindsun
kindsun approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@thomasneirynck thomasneirynck merged commit ffc8bae into master Dec 19, 2018
@thomasneirynck thomasneirynck mentioned this pull request Dec 19, 2018
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Dec 19, 2018
@thomasneirynck
[GIS] Add Maps Plugin (elastic#24804)
7e65c47 
This adds the MVP of the Phase 1 version of the Maps Plugin to Kibana (elastic#19582).

This is added as a new Stack Feature, requiring a basic license.
@thomasneirynck
Copy link
Contributor Author

6.x backport: #27543

@thomasneirynck
Copy link
Contributor Author

todo:
[ ] need to merge outstanding bugs and enhancements to separate github issues

@kindsun kindsun mentioned this pull request Dec 21, 2018
Closed
thomasneirynck added a commit that referenced this pull request Dec 21, 2018
@thomasneirynck
[6.x] [GIS] Add Maps Plugin (#24804) (#27543)
5840370 
* Update to new version of EMS (#26511)

This updates Kibana to use the 6.6 version of EMS. It introduces a new library `ems_client`, to parse the manifests. This library will be used by the upcoming GIS-app. The original visualizations continue to use service_settings, but this component has now been rewritten to use this new `ems_client` client.

This backport required manual edits due to differences in the schema.js diff.

* [GIS] Add Maps Plugin (#24804)

This adds the MVP of the Phase 1 version of the Maps Plugin to Kibana (#19582).

This is added as a new Stack Feature, requiring a basic license.
@elasticmachine
Copy link
Contributor

💔 Build Failed

@thomasneirynck thomasneirynck deleted the gis-plugin branch February 12, 2019 20:13
@legrego legrego mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thomasneirynck @elasticmachine @nreese @kindsun @cchaos @nickpeihl