Update to new version of EMS #26511

thomasneirynck · 2018-12-03T08:50:37Z

DO NOT MERGE.

Needs double check

can open pre-6.6 saved objects for region maps and coordinate maps (e.g. test with sample data)
works with EMS layers and linked layers (e.g. custom TMS and region maps from yml)
todo attribution does not work now
todo format parsing does not work

Summary

This PR needs to upgrade the EMS client code to match the new upcoming version. It also needs to make the code more reusable, so it can be used in the upcoming GIS-app plugin.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support]~~(https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2018-12-03T08:51:02Z

Pinging @elastic/kibana-gis

elasticmachine · 2018-12-03T09:36:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-03T21:45:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-04T00:25:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-04T08:32:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2018-12-04T20:03:50Z

@nickpeihl this needs work still (failing tests/some broken UI), but this might already be useful for a first look.

I extracted the ems-client to https://github.com/elastic/kibana/pull/26511/files#diff-600060cb1ee51e89577bdadc0d6014f5 for v6.6.

We can use that module in the GIS app too, both server-side and on the client.

I backfilled serviceSettings (the old EMS-code) so it continues to work (or at least, the test-suite continues to pass). I'll be looking at UI/loose ends next.

nickpeihl

So far it looks good. Just a few things I've noticed.

Also the Preview EMS Hotlink link bad, but I can't figure out where that happens.

src/core_plugins/ems_util/common/file_layer.js

nickpeihl · 2018-12-04T23:29:16Z

src/core_plugins/ems_util/common/tms_service.js

+  }
+
+  getHTMLAttribution() {
+    return this._emsClient.sanitizeMarkdown(this._config.attribution);


There are slight differences in the TMS and Vector file attributions which causes duplicate attributions in the maps. This must be addressed in the upstream tile service rather than in kibana. But I thought I would point it out.

thx, yeah, we can look at this. we still need to remove dupes client-side, I'll work on that...

src/core_plugins/ems_util/common/file_layer.js

elasticmachine · 2018-12-12T19:58:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-13T18:17:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

This reverts commit ef85651.

elasticmachine · 2018-12-17T18:54:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2018-12-17T19:20:19Z

@nickpeihl I believe I addressed all outstanding issues.

hotlink is not working now, because we need to release corresponding landing page for 6.6 (id of layers have changed). that needs to be a separate PR for the landing page, outside kibana
attribution for local layers in the yml, does not work prior to this either, it does not apply markdown formatting. I'll log separete issue for that

elasticmachine · 2018-12-17T19:52:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2018-12-17T21:58:54Z

jenkins, test this

elasticmachine · 2018-12-17T22:36:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2018-12-18T04:41:51Z

jenkins, test this

elasticmachine · 2018-12-18T04:42:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2018-12-18T04:42:57Z

jenkins, test this

elasticmachine · 2018-12-18T05:19:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-18T06:17:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2018-12-18T17:48:31Z

Backports:
6.x: #27417

This updates Kibana to use the 6.6 version of EMS. It introduces a new library `ems_client`, to parse the manifests. This library will be used by the upcoming GIS-app. The original visualizations continue to use service_settings, but this component has now been rewritten to use this new `ems_client` client. This backport required manual edits due to differences in the schema.js diff.

* Update to new version of EMS (#26511) This updates Kibana to use the 6.6 version of EMS. It introduces a new library `ems_client`, to parse the manifests. This library will be used by the upcoming GIS-app. The original visualizations continue to use service_settings, but this component has now been rewritten to use this new `ems_client` client. This backport required manual edits due to differences in the schema.js diff. * [GIS] Add Maps Plugin (#24804) This adds the MVP of the Phase 1 version of the Maps Plugin to Kibana (#19582). This is added as a new Stack Feature, requiring a basic license.

thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Dec 3, 2018

thomasneirynck added 7 commits December 3, 2018 18:35

tmp commit

2af23c0

add boilerplate

a42f7c1

more tests

b44dccf

more localization tests

3cdc5fd

add retrieval methods

297b358

more tests

f1fb716

add more tests

480c887

thomasneirynck force-pushed the chore/update_to_ems66 branch from f560f12 to 480c887 Compare December 3, 2018 23:36

thomasneirynck added 3 commits December 4, 2018 01:36

backfill tests (EMS)

8c6f9ec

backfill file tests

ae7df62

update regionmap tests

ff38a90

thomasneirynck added v7.0.0 v6.6.0 labels Dec 4, 2018

thomasneirynck requested a review from nickpeihl December 4, 2018 20:01

nickpeihl requested changes Dec 5, 2018

View reviewed changes

thomasneirynck added 2 commits December 12, 2018 11:37

Merge branch 'master' into chore/update_to_ems66

29a1574

lint

ef85651

setup regionmaps

78011e6

thomasneirynck requested review from a team as code owners December 13, 2018 17:50

thomasneirynck added 4 commits December 17, 2018 13:14

Revert "lint"

026e487

This reverts commit ef85651.

check for url presence

603b8c1

rename for consistency

ff4c6a8

fix attribution

e97000f

thomasneirynck added 2 commits December 17, 2018 13:55

remove unused dependency

79b667a

match format metadata to new schema

de78f32

thomasneirynck added 2 commits December 17, 2018 23:29

fix unit tests

d080540

match new fieldnames

67336ff

thomasneirynck added 2 commits December 18, 2018 00:23

fix tests

42e80e2

fix more tests

4ea6af2

thomasneirynck mentioned this pull request Dec 18, 2018

Update config to use productlon link for EMS and EMS Landing Page #27407

Closed

nickpeihl approved these changes Dec 18, 2018

View reviewed changes

thomasneirynck mentioned this pull request Dec 18, 2018

Attribution param in regionmap config in the yml should be formatted as markdown #27330

Closed

thomasneirynck merged commit 71c16e6 into elastic:master Dec 18, 2018

thomasneirynck added the backport pending label Dec 18, 2018

thomasneirynck removed the backport pending label Dec 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to new version of EMS #26511

Update to new version of EMS #26511

thomasneirynck commented Dec 3, 2018 •

edited

Loading

elasticmachine commented Dec 3, 2018

elasticmachine commented Dec 3, 2018

elasticmachine commented Dec 3, 2018

elasticmachine commented Dec 4, 2018

elasticmachine commented Dec 4, 2018

thomasneirynck commented Dec 4, 2018

nickpeihl left a comment

nickpeihl Dec 4, 2018

thomasneirynck Dec 17, 2018 •

edited

Loading

elasticmachine commented Dec 12, 2018

elasticmachine commented Dec 13, 2018

elasticmachine commented Dec 17, 2018

thomasneirynck commented Dec 17, 2018

elasticmachine commented Dec 17, 2018

thomasneirynck commented Dec 17, 2018

elasticmachine commented Dec 17, 2018

thomasneirynck commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

thomasneirynck commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

thomasneirynck commented Dec 18, 2018 •

edited

Loading

Update to new version of EMS #26511

Update to new version of EMS #26511

Conversation

thomasneirynck commented Dec 3, 2018 • edited Loading

Needs double check

Summary

Checklist

For maintainers

elasticmachine commented Dec 3, 2018

elasticmachine commented Dec 3, 2018

💔 Build Failed

elasticmachine commented Dec 3, 2018

💔 Build Failed

elasticmachine commented Dec 4, 2018

💚 Build Succeeded

elasticmachine commented Dec 4, 2018

💔 Build Failed

thomasneirynck commented Dec 4, 2018

nickpeihl left a comment

Choose a reason for hiding this comment

nickpeihl Dec 4, 2018

Choose a reason for hiding this comment

thomasneirynck Dec 17, 2018 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Dec 12, 2018

💔 Build Failed

elasticmachine commented Dec 13, 2018

💔 Build Failed

elasticmachine commented Dec 17, 2018

💔 Build Failed

thomasneirynck commented Dec 17, 2018

elasticmachine commented Dec 17, 2018

💔 Build Failed

thomasneirynck commented Dec 17, 2018

elasticmachine commented Dec 17, 2018

💔 Build Failed

thomasneirynck commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

💔 Build Failed

thomasneirynck commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

💔 Build Failed

elasticmachine commented Dec 18, 2018

💚 Build Succeeded

thomasneirynck commented Dec 18, 2018 • edited Loading

thomasneirynck commented Dec 3, 2018 •

edited

Loading

thomasneirynck Dec 17, 2018 •

edited

Loading

thomasneirynck commented Dec 18, 2018 •

edited

Loading