Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate Visual Builder(part_2) #25800

Merged
merged 31 commits into from
Nov 26, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Nov 16, 2018

Part 1 : #23988

Issue #23257

Nox911 and others added 23 commits September 24, 2018 18:58
@Nox911 Nox911 requested a review from maryia-lapata November 16, 2018 12:39
@Nox911 Nox911 added Feature:TSVB TSVB (Time Series Visual Builder) v6.6.0 labels Nov 16, 2018
@Nox911 Nox911 added the review label Nov 16, 2018
@Nox911 Nox911 requested a review from timroes November 16, 2018 14:18
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please fix some small comments

@Nox911 Nox911 requested a review from pavel06081991 November 22, 2018 08:07
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 28556bf into elastic:master Nov 26, 2018
@Nox911 Nox911 deleted the feature/translate-visual-builder-part_2 branch November 26, 2018 08:44
@Nox911 Nox911 removed the review label Nov 26, 2018
Nox911 added a commit to Nox911/kibana that referenced this pull request Nov 26, 2018
* Translate visual_builder(part_2)

* Replace namespace metrics to tsvb

* Fix issues
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Nov 26, 2018
* Translate visual_builder(part_2)

* Replace namespace metrics to tsvb

* Fix issues
maryia-lapata added a commit that referenced this pull request Nov 26, 2018
* Translate visual_builder(part_2)

* Replace namespace metrics to tsvb

* Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:TSVB TSVB (Time Series Visual Builder) Project:i18n Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants