-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Translate Visual Builder(part_2) #25800
[i18n] Translate Visual Builder(part_2) #25800
Conversation
second merge
💚 Build Succeeded |
Pinging @elastic/kibana-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please fix some small comments
src/core_plugins/metrics/public/components/lib/get_axis_label_string.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/gauge.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/markdown.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/table.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/panel_config/timeseries.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 Build Succeeded |
* Translate visual_builder(part_2) * Replace namespace metrics to tsvb * Fix issues
* Translate visual_builder(part_2) * Replace namespace metrics to tsvb * Fix issues
Part 1 : #23988
Issue #23257