Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate Visual Builder(part_3) #25923

Merged
merged 37 commits into from
Nov 26, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Nov 20, 2018

Part 1 : #23988
Part 2: #25800

Issue #23257

@Nox911 Nox911 added review Project:i18n Feature:TSVB TSVB (Time Series Visual Builder) v6.6.0 labels Nov 20, 2018
@Nox911 Nox911 requested a review from pavel06081991 November 20, 2018 09:38
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix some comments

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nox911 Nox911 requested a review from timroes November 22, 2018 12:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor request for one description. Besides that looks GTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit cc7070d into elastic:master Nov 26, 2018
@Nox911 Nox911 deleted the feature/translate-visual_builder_part_3 branch November 26, 2018 12:32
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Nov 26, 2018
* Translate visual builder part_3

* Add two minor translations

* Add two minor translations from server folder

* Fix issues from  comments

* Fix issues
Nox911 pushed a commit that referenced this pull request Nov 26, 2018
* Translate visual builder part_3

* Add two minor translations

* Add two minor translations from server folder

* Fix issues from  comments

* Fix issues
@Nox911 Nox911 added backported and removed review labels Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants