-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Translate Visual Builder(part_3) #25923
[i18n] Translate Visual Builder(part_3) #25923
Conversation
second merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix some comments
src/core_plugins/metrics/public/components/add_delete_buttons.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/add_delete_buttons.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/annotations_editor.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/annotations_editor.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/annotations_editor.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/vis_editor_visualization.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/vis_editor_visualization.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/vis_types/table/vis.js
Outdated
Show resolved
Hide resolved
src/core_plugins/metrics/public/components/vis_types/table/vis.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor request for one description. Besides that looks GTM
💚 Build Succeeded |
# Conflicts: # src/core_plugins/metrics/public/kbn_vis_types/editor_controller.js
💚 Build Succeeded |
* Translate visual builder part_3 * Add two minor translations * Add two minor translations from server folder * Fix issues from comments * Fix issues
Part 1 : #23988
Part 2: #25800
Issue #23257