[Maps] geotile_grid aggregation #29477
Conversation
nreese
added
v7.0.0
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
|
cc @nyurik |
|
This looks awesome! One small thing - I noticed that the precision needs to be rounded to the nearest integer. |
💔 Build Failed |
💔 Build Failed |
| @@ -142,13 +140,6 @@ export class ESGeoGridSource extends AbstractESSource { | |||
| query: searchFilters.query, | |||
| }); | |||
|
|
|||
| if (this._descriptor.requestType === RENDER_AS.GRID) { | |||
There was a problem hiding this comment.
Now convertToGeoJson returns feature collection of grids when renderAs is GRID to avoid looping over data second time.
💔 Build Failed |
|
The precision requested by the app is too high, and frequently exceeds the 10,000 bucket limit. If we say that a screen is ~20 tiles, with partial tiles visible that makes it to 30. Having zoom+7 means that for each of the 30 tiles visible on screen, you are requesting 4^7 buckets - 16,384 -- way too much, and so is +6 (4,096). +5 (1,024/tile) is doable if you make several requests 9 tiles each (they have to be rectangular, so either 3x3 or 4x2), and stitch them together on the client. Thus, +4 (256/tile) is the maximum reasonable one if you have no more than 39 tiles per request. Also, make sure you handle server error responses (e.g. bucket count exceeded). I wonder if we should have a slider instead of a dropdown, with the slider going from (zoom-1 .. zoom+4) ? Lastly, each request should be aligned to the tile boundaries rather than the screen, and it would be great if the response was cached per tile, not per request. |
|
Closing PR. Work has been put on the feature branch upstream |
💔 Build Failed |
|
feature branch: https://github.com/elastic/kibana/commits/feature/geotile_grid |
Fixes #28485
Requires elastic/elasticsearch#37842
This PR replaces geohash_grid aggregation with geotile_grid aggregation