[Maps] use geo-tile aggregation instead of geohash precision #29776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
bug
|
Pinging @elastic/kibana-gis |
thomasneirynck
removed
the
bug
thomasneirynck
changed the title
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
💚 Build Succeeded |
nreese
reviewed
Feb 5, 2019
| return column.aggConfig.type.type === 'metrics' | ||
| && column.aggConfig.type.dslName !== 'geo_centroid'; | ||
| }); | ||
| const geocentroidColumn = table.columns.find(column => column.aggConfig.type.dslName === 'geo_centroid'); |
There was a problem hiding this comment.
Check that geocentroidColumn and throw an error if does not exist since there is not longer a check before geocentroidColumn.id
| @@ -36,20 +37,28 @@ export default function ({ getPageObjects, getService }) { | |||
| beforeTimestamp = await getRequestTimestamp(); | |||
| }); | |||
|
|
|||
| it('should not rerequest when zoom changes do not cause geohash precision to change', async () => { | |||
| await PageObjects.maps.setView(DATA_CENTER_LAT, DATA_CENTER_LON, 2); | |||
| it('should not rerequest when pan changes do not cause geotile_grid precision to change', async () => { | |||
There was a problem hiding this comment.
This should be should not rerequest when pan changes do not move map view area outside of buffer
|
One more thing. The test map saved object is still called |
nreese
reviewed
Feb 5, 2019
|
|
||
| _loadUrl = async () => { | ||
| const tilemap = await getKibanaTileMap(); | ||
| if (this._isMounted) { | ||
| this.setState({ | ||
| url: tilemap.url | ||
| }); | ||
| this.props.previewTilemap(this.props.url); | ||
| this.props.previewTilemap(this.state.url); |
There was a problem hiding this comment.
Looks like this change snuck in
💚 Build Succeeded |
nreese
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28485
Replaces #29477