[CCR] Copy edits #29676

cjcenizal · 2019-01-31T00:42:41Z

Permissions check

Empty state

Tables

Form

API error

Create/Update save button

Follower index

Auto-follow pattern

RemoteClustersFormField callouts

Follower index

Auto-follow pattern

Context menu and row actions

"Update" confirm modal

Paused follower index

Active follower index

"Pause data replication" confirm modal

"Resume data replication" confirm modal

"Unfollow" confirm modal

elasticmachine · 2019-01-31T00:42:42Z

Pinging @elastic/es-ui

elasticmachine · 2019-01-31T01:35:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-31T01:59:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-31T05:21:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

x-pack/plugins/cross_cluster_replication/public/app/components/follower_index_pause_provider.js

@@ -56,11 +56,11 @@ class Provider extends PureComponent {
    const title = isSingle
      ? intl.formatMessage({
        id: 'xpack.crossClusterReplication.pauseFollowerIndex.confirmModal.pauseSingleTitle',
-        defaultMessage: 'Pause follower index \'{name}\'?',
+        defaultMessage: 'Pause data replication of follower index \'{name}\'?',


…on errors. Remove spacer from SectionError implementation.

cjcenizal · 2019-01-31T19:09:43Z

Ready for another look @jen-huang!

elasticmachine · 2019-01-31T19:21:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-31T19:54:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

...er_replication/public/app/sections/home/auto_follow_pattern_list/auto_follow_pattern_list.js

@@ -105,7 +105,7 @@ export const AutoFollowPatternList = injectI18n(
                <p>
                  <FormattedMessage
                    id="xpack.crossClusterReplication.autoFollowPatternList.autoFollowPatternsDescription"
-                    defaultMessage="Auto-follow patterns replicate leader indices from a remote
+                    defaultMessage="An auto-follow pattern replicates leader indices from a remote


elasticmachine · 2019-01-31T20:55:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

..._cluster_replication/public/app/sections/home/follower_indices_list/follower_indices_list.js

@@ -182,8 +188,7 @@ export const FollowerIndicesList = injectI18n(
              <p>
                <FormattedMessage
                  id="xpack.crossClusterReplication.followerIndexList.emptyPromptDescription"
-                  defaultMessage="Use a follower to start replicating operations from
-                    the leader index to the follower index."
+                  defaultMessage="Use a follower to replicate data from a leader index."
                />


..._cluster_replication/public/app/sections/home/follower_indices_list/follower_indices_list.js

@@ -102,7 +102,7 @@ export const FollowerIndicesList = injectI18n(
                <p>
                  <FormattedMessage
                    id="xpack.crossClusterReplication.followerIndexList.followerIndicesDescription"
-                    defaultMessage="Followers replicate operations from the leader index to the follower index."
+                    defaultMessage="A follower index replicates data from a leader index."


gchaps · 2019-01-31T21:12:14Z

...s/cross_cluster_replication/public/app/components/follower_index_form/follower_index_form.js

+              <p>
+                <FormattedMessage
+                  id="xpack.crossClusterReplication.followerIndexForm.sectionLeaderIndexDescription2"
+                  defaultMessage="{note} the leader index must already exist."


Capitalize The

gchaps · 2019-01-31T21:14:15Z

...s/cross_cluster_replication/public/app/components/follower_index_form/follower_index_form.js

@@ -489,8 +518,7 @@ export const FollowerIndexForm = injectI18n(
                  <p>
                    <FormattedMessage
                      id="xpack.crossClusterReplication.followerIndexForm.advancedSettingsDescription"
-                      defaultMessage="Customize advanced settings to control the rate at which data is replicated.
-                        If you don't customize them, default advanced settings will be applied."
+                      defaultMessage="Advanced settings control the rate at which data is replicated.."


Remove second period.

Advanced settings control the rate of replication.

gchaps · 2019-01-31T21:16:05Z

x-pack/plugins/cross_cluster_replication/public/app/components/remote_clusters_form_field.js

  />),
  remoteClusterNotConnectedEditable: () => (<FormattedMessage
    id="xpack.crossClusterReplication.forms.currentRemoteClusterNotConnectedCallOutDescription"
-    defaultMessage="Edit the remote cluster to fix the problem or select a different one."
+    defaultMessage="Edit the remote cluster or select one that's connected."


or select a cluster that is connected

gchaps · 2019-01-31T21:37:36Z

...s/cross_cluster_replication/public/app/components/follower_index_form/follower_index_form.js

@@ -382,13 +389,13 @@ export const FollowerIndexForm = injectI18n(
          />),
          remoteClusterNotConnectedNotEditable: () => (<FormattedMessage
            id="xpack.crossClusterReplication.followerIndexForm.currentRemoteClusterNotConnectedCallOutDescription"
-            defaultMessage="You need to connect it before editing this follower index. Edit the remote cluster to
-              fix the problem."
+            defaultMessage="The remote cluster must be connected to edit this follower index."


Can't edit follower index because remote cluster 'text' is not connected.

You can address this by editing the remote cluster.

Edit remote cluster

gchaps · 2019-01-31T21:46:12Z

x-pack/plugins/cross_cluster_replication/public/app/components/follower_index_pause_provider.js

-                }
+                <FormattedMessage
+                  id="xpack.crossClusterReplication.pauseFollowerIndex.confirmModal.multiplePauseDescription"
+                  defaultMessage="These follower indices will pause replication:"


Replication will pause on these follower indices:

gchaps · 2019-01-31T21:47:29Z

...ck/plugins/cross_cluster_replication/public/app/components/follower_index_resume_provider.js

              <p>
                <FormattedMessage
                  id="xpack.crossClusterReplication.resumeFollowerIndex.confirmModal.multipleResumeDescription"
-                  defaultMessage="The follower indices below will be resumed using default advanced settings.
-                    To resume using custom advanced settings, edit each follower index instead."
+                  defaultMessage="These follower indices will resume replication:"


Replication will resume on these follower indices:

gchaps · 2019-01-31T21:49:28Z

.../plugins/cross_cluster_replication/public/app/components/follower_index_unfollow_provider.js

-                    The index will no longer appear in Cross Cluster Replication but can still be managed using Index
-                    Management. This operation cannot be undone."
+                  defaultMessage="This follower index will be converted to a standard index and no
+                    longer appear in Cross Cluster Replication, but you can manage it in Index


The follower index will be converted to a standard index. It will no longer appear in ...

gchaps · 2019-01-31T21:50:30Z

.../plugins/cross_cluster_replication/public/app/components/follower_index_unfollow_provider.js

-                    The indices will no longer appear in Cross Cluster Replication but can still be managed using Index
-                    Management. This operation cannot be undone."
+                  defaultMessage="These follower indices will be converted to standard indices and no
+                    longer appear in Cross Cluster Replication, but you can manage them in Index


The follower indices will be converted to standard indices. They will no longer appear ....

elasticmachine · 2019-01-31T23:06:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

jen-huang

I have one suggestion for changing replication to replication tasks in pause and resume modals, I think that will make it clear that we are not replicating the follower index itself. I will defer to @cjcenizal and @gchaps to make the final call on that. Overall the copy is much better and terser; thank you both and great work!

jen-huang · 2019-02-01T04:35:29Z

...s/cross_cluster_replication/public/app/components/follower_index_form/follower_index_form.js

@@ -489,8 +533,7 @@ export const FollowerIndexForm = injectI18n(
                  <p>
                    <FormattedMessage
                      id="xpack.crossClusterReplication.followerIndexForm.advancedSettingsDescription"
-                      defaultMessage="Customize advanced settings to control the rate at which data is replicated.
-                        If you don't customize them, default advanced settings will be applied."
+                      defaultMessage="Advanced settings control the rate of replication."


are we ok with dropping the copy about default settings?

How about:

Advanced settings control the rate at which data is replicated. You can customize these settings or use the default values.

👍 I left out the mention of "data" per @jen-huang's previous comments:

Advanced settings control the rate of replication. You can customize these settings or use the default values.

jen-huang · 2019-02-01T04:40:52Z

x-pack/plugins/cross_cluster_replication/public/app/components/follower_index_pause_provider.js

@@ -56,11 +56,11 @@ class Provider extends PureComponent {
    const title = isSingle
      ? intl.formatMessage({
        id: 'xpack.crossClusterReplication.pauseFollowerIndex.confirmModal.pauseSingleTitle',
-        defaultMessage: 'Pause follower index \'{name}\'?',
+        defaultMessage: 'Pause replication of follower index \'{name}\'?',


this sounds like we are pausing replication of the follower index itself, rather than saying that the follower index will stop replicating its leader index. what do you think of saying something like Pause replication tasks of... here and elsewhere in this file? cc @gchaps

@jen-huang, @cjcenizal I like the idea of adding the word task. I tried it out:

Modals

Pause replication tasks of follower index 'd'?

Pausing the replication tasks of this follower index clears its custom advanced settings.

Resume replication tasks of follower index "d"?

Replication tasks resume using the default advanced settings...

Menu

Pause/Resume replication tasks

@gchaps Jen and I chatted about this and identified the issue with the original wording is that "replication of the follower index" makes it sound like the follower index is what is being replication, which is misleading because it's actually that leader index that's being replicated. We agreed that the word "task" wasn't necessary in the copy and arrived at the phrase, "replication ~~from~~ to the follower index". How do you feel about this?

@cjcenizal I thought it was "replication to"? 🤔 like Pause replication to follower index...

Bah, typo on my part. Thanks for catching that! Edited the comment.

"replication to" feels cleaner. I was worried about the modal titles getting too long.

jen-huang · 2019-02-01T04:41:58Z

x-pack/plugins/cross_cluster_replication/public/app/components/follower_index_pause_provider.js

-                }
+                <FormattedMessage
+                  id="xpack.crossClusterReplication.pauseFollowerIndex.confirmModal.multiplePauseDescription"
+                  defaultMessage="Replication will pause on these follower indices:"


then this could say Replication tasks will pause...

jen-huang · 2019-02-01T04:42:27Z

...ck/plugins/cross_cluster_replication/public/app/components/follower_index_resume_provider.js

@@ -57,11 +57,11 @@ class Provider extends PureComponent {
    const title = isSingle
      ? intl.formatMessage({
        id: 'xpack.crossClusterReplication.resumeFollowerIndex.confirmModal.resumeSingleTitle',
-        defaultMessage: 'Resume follower index \'{name}\'?',
+        defaultMessage: 'Resume replication of follower index \'{name}\'?',


same suggestion for adding tasks, like Resume replication tasks of...

jen-huang · 2019-02-01T04:43:17Z

...ck/plugins/cross_cluster_replication/public/app/components/follower_index_resume_provider.js

@@ -90,14 +90,14 @@ class Provider extends PureComponent {
            <p>
              <FormattedMessage
                id="xpack.crossClusterReplication.resumeFollowerIndex.confirmModal.singleResumeDescription"
-                defaultMessage="This follower index will be resumed using default advanced settings.
-                  To resume using custom advanced settings, {editLink}."
+                defaultMessage="Replication resumes using the default advanced settings. To use


Replication tasks resume using...

elasticmachine · 2019-02-01T21:27:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2019-02-01T22:24:08Z

I've implemented the latest request from @jen-huang and will merge once CI goes green, unless anyone has any other suggestions.

…cluster.

…llower index.

elasticmachine · 2019-02-02T00:34:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2019-02-02T00:36:08Z

CI failure is unrelated to this PR.

* [CCR] Refactor redux for Auto-follow pattern detail panel (elastic#27491) * [CCR] Refactor redux for Auto-follow pattern detail panel * [CCR] Small refactor * [CCR] Change to present tense * [CCR] Display auto-follow pattern name even if it does not exist * [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params * [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern * [CCR] Replace api middleware with redux-thunk action * [CCR] Show detail footer close button even when cluster is not valid * [CCR] Add endpoints for fetching and creating follower indices (elastic#27646) * Add GET /follower_indices endpoint with deserialization logic and tests. * Add POST /follower_indices endpoint with serialization logic and tests. * [CCR] Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (elastic#27647) * Use componentDidUpdate instead of getDerivedStateFromProps. * Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable. * Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots * Update snapshot for Remote Cluster list test * [CCR] Follower indices table and detail panel (elastic#27804) * Store for follower indices * Initial work for follower indices table and detail panel * Fix load auto-follow stats load as middleware was removed * [CCR] Create follower index UI form (elastic#27864) * Initial setup Follower Index form * Working form without client validation * Add client side validation for follower index * Add client validation to check if index already exist * Improve error message when leader index does not exist * Remove update method for follower index * Clear api error on field change * Fix i18n error * Update snapshots * [CCR] Add pause, resume, and unfollow actions for follower indices (elastic#28305) * Add pause and resume follower index routes * Add unfollow route * Add api methods for new routes * Adjust routes to have bulk capabilities, add corresponding actions * Refresh list after pausing/resuming, remove items after unfollowing * First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response) * Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status * PR feedback * [CCR] Advanced settings UI for follower indices (elastic#28267) * Add client side validation of advanced settings form * Move form entry row to separate component * Add server side serialization for advanced settings * Ignore advanced settings input when that section is hidden. - Cache and restore input when the section is shown again. * [CCR] Show remote cluster validation in CCR forms, and add edit follower index (elastic#28778) * [CCR] Advanced settings component * Remove preview active on toggle settings * Add client side validation of advanced settings form * Move form entry row to separate component * Add title to panel * Add i18n translation of advanced settings * Update Follower index form with toggle for advanced settings * Add server side serialisation for advanced settings * Make code review changes * Fix test: mock constant dependency * Add section to edit follower index * Show confirm modal before updating follower index * Add edit icon in table + update server endpoint to pause / resume * [CCR] Show remote cluster validation in follower index form & auto-follow pattern form * PR feedback, cleanup form sizes, add redirect to edit remote cluster * Fix routing, remove unused code, adjust auto follow pattern edit loading error page * Adjust error messages and make remote cluster not found edit page the same * Fix functionality as result of merge * Fix validation, reorder actions, fix tests, and address feedback * PR feedback and fix validation pt 2 * Adjust remote cluster validation * Fix i18n * Fix api error not showing on add follower form * [CCR] Integrate new follower index info ES API (elastic#29153) * Integrate new follower index info ES API * Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI * Adjust tests * Address PR feedback * Update snapshots * [CCR] Surface license errors in-app and refine permissions error UI. (elastic#29228) * Fix camelcasing bug in XPackInfo. * Silently swallow API error when checking for index name availability. * Fix typo in followerIndexForm fatal error. * Add permissions check before allowing user to access the app. * Refine wording of CCR permission denied page, to specify cluster privileges. (elastic#29533) * [CCR] Improve form error handling and general UX (elastic#29419) * Remove unnecessary eslint disable-line * [CCR] Implement Advanced Settings design feedback (elastic#29543) * Use EuiSwitch to toggle advanced settings in Create Follower Index form. * Move 'optional' from each Advanced Setting field to the section heading. * Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults. * Prepopulate Advanced Settings fields with default values. * When editing a follower index, check if advanced settings have been edited and open them if so. * Add 'Reset to default' button below advanced settings fields if their values are different than the default. * Remove 'Default' copy from Advanced Settings descriptions. * Simplify toggleAdvancedSettings function, add comments, and fix React console error. * [CCR] Follower index list fixes from design feedback (elastic#29484) * Delete remote cluster settings before updating * Fix detail panel z-index * Remove default descriptor from follower index detail panel setting values * Follower index confirm action copy adjustments * Change z-index styling to use EUI vars * [CCR] Improve remote clusters test coverage (elastic#29487) * Add Jest test for RemoteClusterForm validation state. * Extract validation functions out of RemoteClusterForm and add unit tests. - Return null instead of undefined from validators. * Add unit tests for different types of remote clusters in RemoteClusterTable. * Add unit test for RemoteClusterList empty prompt. * Add tests verifying behavior for row link, row delete button, and detail panel delete button. - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel. * [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (elastic#29789) * Adjust spacing around description around descriptions in list views so that it's even on top and bottom. * Add link to transport port docs from Remote Cluster form. * Move 'View in Index Management' link from the detail panel body into the footer. * Re-order follower index form sections: remote cluster, leader index, follower index. (elastic#29885) * Fix deep-linking to follower index after creating/updating it. (elastic#29865) * [CCR] Copy edits (elastic#29676) * Use 'Resume/pause data replication' in context menu and row actions. * Update copy of 'Update' confirm modal for a paused follower index. * Update copy of 'Update' confirm modal for an active follower index. * Update copy of 'Pause data replication' confirm modal. * Update copy of 'Resume data replication' confirm modal. * Update copy for permissions check. * Update copy of table empty state. * Update copy around tables. * Update form copy. * Update copy for RemoteClustersFormField callouts. * Convert 'data replication' -> 'replication'. * Update copy for Unfollow confirm modal. * Update copy for form API error and Auto-follow Patterns table. * Update form save button labels to be 'Create' and 'Update'. * Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation. * [CCR] Open index after unfollowing leader (elastic#29887) * Open index after unfollowing leader, fix some variable names * Fix typo * Add comment * [CCR] IE and Screen reader accesibility (elastic#29731) * Fix api endpoit for auto-follow stats * Prevent letter wrapping in IE for the Remote cluster "connection" table column * Move inline style to CSS class to fix IE flex bug * [CCR] Add callout to paused follower index detail panel (elastic#30013) * Add callout to paused follower index detail panel * Update copy * Skip call to ccr stats api if follower index is paused (elastic#30027) * [CCR] Add integration tests for follower indices (elastic#30064) * [CCR] Add integration tests for follower indices * Import advanced settings value from app constants

* [CCR] Refactor redux for Auto-follow pattern detail panel (#27491) * [CCR] Refactor redux for Auto-follow pattern detail panel * [CCR] Small refactor * [CCR] Change to present tense * [CCR] Display auto-follow pattern name even if it does not exist * [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params * [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern * [CCR] Replace api middleware with redux-thunk action * [CCR] Show detail footer close button even when cluster is not valid * [CCR] Add endpoints for fetching and creating follower indices (#27646) * Add GET /follower_indices endpoint with deserialization logic and tests. * Add POST /follower_indices endpoint with serialization logic and tests. * [CCR] Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (#27647) * Use componentDidUpdate instead of getDerivedStateFromProps. * Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable. * Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots * Update snapshot for Remote Cluster list test * [CCR] Follower indices table and detail panel (#27804) * Store for follower indices * Initial work for follower indices table and detail panel * Fix load auto-follow stats load as middleware was removed * [CCR] Create follower index UI form (#27864) * Initial setup Follower Index form * Working form without client validation * Add client side validation for follower index * Add client validation to check if index already exist * Improve error message when leader index does not exist * Remove update method for follower index * Clear api error on field change * Fix i18n error * Update snapshots * [CCR] Add pause, resume, and unfollow actions for follower indices (#28305) * Add pause and resume follower index routes * Add unfollow route * Add api methods for new routes * Adjust routes to have bulk capabilities, add corresponding actions * Refresh list after pausing/resuming, remove items after unfollowing * First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response) * Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status * PR feedback * [CCR] Advanced settings UI for follower indices (#28267) * Add client side validation of advanced settings form * Move form entry row to separate component * Add server side serialization for advanced settings * Ignore advanced settings input when that section is hidden. - Cache and restore input when the section is shown again. * [CCR] Show remote cluster validation in CCR forms, and add edit follower index (#28778) * [CCR] Advanced settings component * Remove preview active on toggle settings * Add client side validation of advanced settings form * Move form entry row to separate component * Add title to panel * Add i18n translation of advanced settings * Update Follower index form with toggle for advanced settings * Add server side serialisation for advanced settings * Make code review changes * Fix test: mock constant dependency * Add section to edit follower index * Show confirm modal before updating follower index * Add edit icon in table + update server endpoint to pause / resume * [CCR] Show remote cluster validation in follower index form & auto-follow pattern form * PR feedback, cleanup form sizes, add redirect to edit remote cluster * Fix routing, remove unused code, adjust auto follow pattern edit loading error page * Adjust error messages and make remote cluster not found edit page the same * Fix functionality as result of merge * Fix validation, reorder actions, fix tests, and address feedback * PR feedback and fix validation pt 2 * Adjust remote cluster validation * Fix i18n * Fix api error not showing on add follower form * [CCR] Integrate new follower index info ES API (#29153) * Integrate new follower index info ES API * Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI * Adjust tests * Address PR feedback * Update snapshots * [CCR] Surface license errors in-app and refine permissions error UI. (#29228) * Fix camelcasing bug in XPackInfo. * Silently swallow API error when checking for index name availability. * Fix typo in followerIndexForm fatal error. * Add permissions check before allowing user to access the app. * Refine wording of CCR permission denied page, to specify cluster privileges. (#29533) * [CCR] Improve form error handling and general UX (#29419) * Remove unnecessary eslint disable-line * [CCR] Implement Advanced Settings design feedback (#29543) * Use EuiSwitch to toggle advanced settings in Create Follower Index form. * Move 'optional' from each Advanced Setting field to the section heading. * Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults. * Prepopulate Advanced Settings fields with default values. * When editing a follower index, check if advanced settings have been edited and open them if so. * Add 'Reset to default' button below advanced settings fields if their values are different than the default. * Remove 'Default' copy from Advanced Settings descriptions. * Simplify toggleAdvancedSettings function, add comments, and fix React console error. * [CCR] Follower index list fixes from design feedback (#29484) * Delete remote cluster settings before updating * Fix detail panel z-index * Remove default descriptor from follower index detail panel setting values * Follower index confirm action copy adjustments * Change z-index styling to use EUI vars * [CCR] Improve remote clusters test coverage (#29487) * Add Jest test for RemoteClusterForm validation state. * Extract validation functions out of RemoteClusterForm and add unit tests. - Return null instead of undefined from validators. * Add unit tests for different types of remote clusters in RemoteClusterTable. * Add unit test for RemoteClusterList empty prompt. * Add tests verifying behavior for row link, row delete button, and detail panel delete button. - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel. * [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (#29789) * Adjust spacing around description around descriptions in list views so that it's even on top and bottom. * Add link to transport port docs from Remote Cluster form. * Move 'View in Index Management' link from the detail panel body into the footer. * Re-order follower index form sections: remote cluster, leader index, follower index. (#29885) * Fix deep-linking to follower index after creating/updating it. (#29865) * [CCR] Copy edits (#29676) * Use 'Resume/pause data replication' in context menu and row actions. * Update copy of 'Update' confirm modal for a paused follower index. * Update copy of 'Update' confirm modal for an active follower index. * Update copy of 'Pause data replication' confirm modal. * Update copy of 'Resume data replication' confirm modal. * Update copy for permissions check. * Update copy of table empty state. * Update copy around tables. * Update form copy. * Update copy for RemoteClustersFormField callouts. * Convert 'data replication' -> 'replication'. * Update copy for Unfollow confirm modal. * Update copy for form API error and Auto-follow Patterns table. * Update form save button labels to be 'Create' and 'Update'. * Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation. * [CCR] Open index after unfollowing leader (#29887) * Open index after unfollowing leader, fix some variable names * Fix typo * Add comment * [CCR] IE and Screen reader accesibility (#29731) * Fix api endpoit for auto-follow stats * Prevent letter wrapping in IE for the Remote cluster "connection" table column * Move inline style to CSS class to fix IE flex bug * [CCR] Add callout to paused follower index detail panel (#30013) * Add callout to paused follower index detail panel * Update copy * Skip call to ccr stats api if follower index is paused (#30027) * [CCR] Add integration tests for follower indices (#30064) * [CCR] Add integration tests for follower indices * Import advanced settings value from app constants

* [CCR] Follower index CRUD (#27936) * [CCR] Refactor redux for Auto-follow pattern detail panel (#27491) * [CCR] Refactor redux for Auto-follow pattern detail panel * [CCR] Small refactor * [CCR] Change to present tense * [CCR] Display auto-follow pattern name even if it does not exist * [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params * [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern * [CCR] Replace api middleware with redux-thunk action * [CCR] Show detail footer close button even when cluster is not valid * [CCR] Add endpoints for fetching and creating follower indices (#27646) * Add GET /follower_indices endpoint with deserialization logic and tests. * Add POST /follower_indices endpoint with serialization logic and tests. * [CCR] Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (#27647) * Use componentDidUpdate instead of getDerivedStateFromProps. * Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable. * Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots * Update snapshot for Remote Cluster list test * [CCR] Follower indices table and detail panel (#27804) * Store for follower indices * Initial work for follower indices table and detail panel * Fix load auto-follow stats load as middleware was removed * [CCR] Create follower index UI form (#27864) * Initial setup Follower Index form * Working form without client validation * Add client side validation for follower index * Add client validation to check if index already exist * Improve error message when leader index does not exist * Remove update method for follower index * Clear api error on field change * Fix i18n error * Update snapshots * [CCR] Add pause, resume, and unfollow actions for follower indices (#28305) * Add pause and resume follower index routes * Add unfollow route * Add api methods for new routes * Adjust routes to have bulk capabilities, add corresponding actions * Refresh list after pausing/resuming, remove items after unfollowing * First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response) * Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status * PR feedback * [CCR] Advanced settings UI for follower indices (#28267) * Add client side validation of advanced settings form * Move form entry row to separate component * Add server side serialization for advanced settings * Ignore advanced settings input when that section is hidden. - Cache and restore input when the section is shown again. * [CCR] Show remote cluster validation in CCR forms, and add edit follower index (#28778) * [CCR] Advanced settings component * Remove preview active on toggle settings * Add client side validation of advanced settings form * Move form entry row to separate component * Add title to panel * Add i18n translation of advanced settings * Update Follower index form with toggle for advanced settings * Add server side serialisation for advanced settings * Make code review changes * Fix test: mock constant dependency * Add section to edit follower index * Show confirm modal before updating follower index * Add edit icon in table + update server endpoint to pause / resume * [CCR] Show remote cluster validation in follower index form & auto-follow pattern form * PR feedback, cleanup form sizes, add redirect to edit remote cluster * Fix routing, remove unused code, adjust auto follow pattern edit loading error page * Adjust error messages and make remote cluster not found edit page the same * Fix functionality as result of merge * Fix validation, reorder actions, fix tests, and address feedback * PR feedback and fix validation pt 2 * Adjust remote cluster validation * Fix i18n * Fix api error not showing on add follower form * [CCR] Integrate new follower index info ES API (#29153) * Integrate new follower index info ES API * Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI * Adjust tests * Address PR feedback * Update snapshots * [CCR] Surface license errors in-app and refine permissions error UI. (#29228) * Fix camelcasing bug in XPackInfo. * Silently swallow API error when checking for index name availability. * Fix typo in followerIndexForm fatal error. * Add permissions check before allowing user to access the app. * Refine wording of CCR permission denied page, to specify cluster privileges. (#29533) * [CCR] Improve form error handling and general UX (#29419) * Remove unnecessary eslint disable-line * [CCR] Implement Advanced Settings design feedback (#29543) * Use EuiSwitch to toggle advanced settings in Create Follower Index form. * Move 'optional' from each Advanced Setting field to the section heading. * Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults. * Prepopulate Advanced Settings fields with default values. * When editing a follower index, check if advanced settings have been edited and open them if so. * Add 'Reset to default' button below advanced settings fields if their values are different than the default. * Remove 'Default' copy from Advanced Settings descriptions. * Simplify toggleAdvancedSettings function, add comments, and fix React console error. * [CCR] Follower index list fixes from design feedback (#29484) * Delete remote cluster settings before updating * Fix detail panel z-index * Remove default descriptor from follower index detail panel setting values * Follower index confirm action copy adjustments * Change z-index styling to use EUI vars * [CCR] Improve remote clusters test coverage (#29487) * Add Jest test for RemoteClusterForm validation state. * Extract validation functions out of RemoteClusterForm and add unit tests. - Return null instead of undefined from validators. * Add unit tests for different types of remote clusters in RemoteClusterTable. * Add unit test for RemoteClusterList empty prompt. * Add tests verifying behavior for row link, row delete button, and detail panel delete button. - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel. * [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (#29789) * Adjust spacing around description around descriptions in list views so that it's even on top and bottom. * Add link to transport port docs from Remote Cluster form. * Move 'View in Index Management' link from the detail panel body into the footer. * Re-order follower index form sections: remote cluster, leader index, follower index. (#29885) * Fix deep-linking to follower index after creating/updating it. (#29865) * [CCR] Copy edits (#29676) * Use 'Resume/pause data replication' in context menu and row actions. * Update copy of 'Update' confirm modal for a paused follower index. * Update copy of 'Update' confirm modal for an active follower index. * Update copy of 'Pause data replication' confirm modal. * Update copy of 'Resume data replication' confirm modal. * Update copy for permissions check. * Update copy of table empty state. * Update copy around tables. * Update form copy. * Update copy for RemoteClustersFormField callouts. * Convert 'data replication' -> 'replication'. * Update copy for Unfollow confirm modal. * Update copy for form API error and Auto-follow Patterns table. * Update form save button labels to be 'Create' and 'Update'. * Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation. * [CCR] Open index after unfollowing leader (#29887) * Open index after unfollowing leader, fix some variable names * Fix typo * Add comment * [CCR] IE and Screen reader accesibility (#29731) * Fix api endpoit for auto-follow stats * Prevent letter wrapping in IE for the Remote cluster "connection" table column * Move inline style to CSS class to fix IE flex bug * [CCR] Add callout to paused follower index detail panel (#30013) * Add callout to paused follower index detail panel * Update copy * Skip call to ccr stats api if follower index is paused (#30027) * [CCR] Add integration tests for follower indices (#30064) * [CCR] Add integration tests for follower indices * Import advanced settings value from app constants * Disable flaky follower indices API integration tests.

cjcenizal added 5 commits January 30, 2019 15:55

Use 'Resume/pause data replication' in context menu and row actions.

21b38b8

Update copy of 'Update' confirm modal for a paused follower index.

f95b77f

Update copy of 'Update' confirm modal for an active follower index.

b544ab9

Update copy of 'Pause data replication' confirm modal.

ee721ca

Update copy of 'Resume data replication' confirm modal.

0beee6c

cjcenizal added WIP Work in progress Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 31, 2019

cjcenizal added 4 commits January 30, 2019 16:48

Update copy for permissions check.

2403120

Update copy of table empty state.

120e1a3

Update copy around tables.

bf405b1

Update form copy.

950bf23

Update copy for RemoteClustersFormField callouts.

0eba66d

jen-huang reviewed Jan 31, 2019

View reviewed changes

cjcenizal added 2 commits January 31, 2019 10:26

Convert 'data replication' -> 'replication'.

aaa62b0

Update copy for Unfollow confirm modal.

571a84d

cjcenizal force-pushed the ccr/copy-edits branch from 3dbecb7 to 571a84d Compare January 31, 2019 18:33

cjcenizal added 3 commits January 31, 2019 10:50

Update copy for form API error and Auto-follow Patterns table.

976e521

Update form save button labels to be 'Create' and 'Update'.

eea6e2f

Move API errors to bottom of form, into same posiion as sync validati…

aada6bc

…on errors. Remove spacer from SectionError implementation.

cjcenizal requested review from sebelga and gchaps January 31, 2019 19:09

cjcenizal removed the WIP Work in progress label Jan 31, 2019

Fix i18n error.

ed5bf46

cjcenizal commented Jan 31, 2019

View reviewed changes

gchaps reviewed Jan 31, 2019

View reviewed changes

Update copy with feedback from Gail.

4bbc5d3

jen-huang approved these changes Feb 1, 2019

View reviewed changes

Fix bug with remoteClusterNotConnectedEditable throwing an error.

f136ebf

Rephrase 'replication of leader index' -> 'replication to leader index'.

a5921d6

cjcenizal added 3 commits February 1, 2019 15:02

Tweak leader index description to reinforce relationship with remote …

f183122

…cluster.

Tweak leader index description to clarify role of leader index and fo…

3de1955

…llower index.

Merge branch 'feature/ccr' into ccr/copy-edits

d86fcd0

cjcenizal merged commit c794f42 into elastic:feature/ccr Feb 2, 2019

cjcenizal deleted the ccr/copy-edits branch February 2, 2019 00:36

AlexP-Elastic mentioned this pull request Apr 28, 2021

[Fleet] Use 9243 as default port for cloud URLs #98670

Closed

[CCR] Copy edits #29676

[CCR] Copy edits #29676

Conversation

cjcenizal commented Jan 31, 2019 • edited Loading

Permissions check

Empty state

Tables

Form

API error

Create/Update save button

Follower index

Auto-follow pattern

RemoteClustersFormField callouts

Follower index

Auto-follow pattern

Context menu and row actions

"Update" confirm modal

Paused follower index

Active follower index

"Pause data replication" confirm modal

"Resume data replication" confirm modal

"Unfollow" confirm modal

elasticmachine commented Jan 31, 2019

elasticmachine commented Jan 31, 2019

💚 Build Succeeded

elasticmachine commented Jan 31, 2019

💚 Build Succeeded

elasticmachine commented Jan 31, 2019

💔 Build Failed

This comment was marked as resolved.

This comment was marked as resolved.

cjcenizal commented Jan 31, 2019

elasticmachine commented Jan 31, 2019

💔 Build Failed

elasticmachine commented Jan 31, 2019

💔 Build Failed

This comment was marked as resolved.

elasticmachine commented Jan 31, 2019

💚 Build Succeeded

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jan 31, 2019

💚 Build Succeeded

jen-huang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjcenizal Feb 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Feb 1, 2019

💚 Build Succeeded

cjcenizal commented Feb 1, 2019

elasticmachine commented Feb 2, 2019

💔 Build Failed

cjcenizal commented Feb 2, 2019

cjcenizal commented Jan 31, 2019 •

edited

Loading

cjcenizal Feb 1, 2019 •

edited

Loading