Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries Visual Builder - DST shift in historic data #34283

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 1, 2019

Fix: #33006

Summary

In the timeseries visualization of visual builder we compare different series from this week, last week (1w) and 2 weeks (2w) ago, i.e. using "offset series time" in the options of the metric
After the daylight saving time shift in the US suddenly our historic data (offsetted timeseries) got also shifted and is displayed with 1 hour offset. The current data after the shift is displaying fine.
Reason is probably the series when selected for the last 7 days uses the same timestamps on the X-Axis for this week as for last week and old data gets converted to the new "time zone".

Note: Timestamps are UTC everywhere (code, server, ES?), data is from Europe, so now DST shift involved here.

Steps to reproduce:

Create multiple timeseries in visual builder which spans over the DST shift
Observe how peaks in historic data shift by 1 hour

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp added release_note:enhancement Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Apr 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@PhilippBaranovskiy PhilippBaranovskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐸👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00 markov00 assigned markov00 and emmacunningham and unassigned markov00 Apr 8, 2019
Copy link

@emmacunningham emmacunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally & code lgtm

@alexwizp alexwizp merged commit 9bde4e4 into elastic:master Apr 9, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Apr 9, 2019
* Timeseries Visual Builder - DST shift in historic data

* Timeseries Visual Builder - DST shift in historic data - performance optimization
alexwizp added a commit that referenced this pull request Apr 9, 2019
* Timeseries Visual Builder - DST shift in historic data

* Timeseries Visual Builder - DST shift in historic data - performance optimization
@kobelb kobelb mentioned this pull request Jul 3, 2019
@alexwizp alexwizp deleted the 33006 branch January 4, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants