-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] offset option doesn't work properly for some values #83051
Conversation
Closes: elastic#40299
@kobelb could you please have a look that? I need your eyes to be sure that it will be finally fixed. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am not sure if the previous bug still exists though. I tried to do some tests but couldn't reproduce it, and as this solves the problem with the offsets I approve it.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Closes: elastic#40299 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* master: [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062) skip flaky suite (elastic#84440) skip flaky suite (elastic#84445) [APM] Fix missing `service.node.name` (elastic#84269) Upgrade fp-ts to 2.8.6 (elastic#83866) Added data streams privileges to better control delete actions in UI (elastic#83573) Improve short-url redirect validation (elastic#84366) TSVB offsets (elastic#83051) [Discover] Fix navigating back when changing index pattern (elastic#84061) [Logs UI] Polish the UI for the log entry examples in the anomaly table (elastic#82139) [Logs UI] Limit the height of the "view in context" container (elastic#83178) [Application Usage] Update `schema` with new `fleet` rename (elastic#84327) fix identation in list (elastic#84301)
Closes: #40299
Summary
This PR is reverting #34283 because this PR brought us new issues with offset. Also I think date should be also parsed in UTC on server side to avoid this types of issues.
In my local offset works fine (second chart with 1y offset)
Checklist
Delete any items that are not applicable to this PR.
For maintainers