-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] A <label> for time bucket size selector on discover #38396
Conversation
💔 Build Failed |
Pinging @elastic/kibana-app |
💔 Build Failed |
💚 Build Succeeded |
@vitalics, updated and checked, please have a look one more time, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rockfield can we get this label of time interval box to read as timespan? Is that possible? Right now screenreader reads it as "checkmark second".
code LGTM for me |
@bhavyarm let's create another issue and update that |
@bhavyarm does it work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as we are fixing the aria-label in a different PR
…lastic#38396) * Replace <span> with a <label for=''> used as a label for a dropdown <select> * Change CSS selector for functional test
Fixes #19448
Summary
Axe analyzing tool warns that form element should have an appropriate labels event if they are not a part of
<form>
.Here I've replaced
<span>
with<label for="">
and placedid
attribute to<select>
.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately