Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] A <label> for time bucket size selector on discover #38396

Merged
merged 4 commits into from
Jun 12, 2019

Conversation

PhilippBaranovskiy
Copy link
Contributor

@PhilippBaranovskiy PhilippBaranovskiy commented Jun 7, 2019

Fixes #19448

Summary

Axe analyzing tool warns that form element should have an appropriate labels event if they are not a part of <form>.
Here I've replaced <span> with <label for=""> and placed id attribute to <select>.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Jun 7, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@PhilippBaranovskiy PhilippBaranovskiy marked this pull request as ready for review June 11, 2019 13:04
@PhilippBaranovskiy PhilippBaranovskiy changed the title WIP: [Accessibility] A <label> for time bucket size selector on discover [Accessibility] A <label> for time bucket size selector on discover Jun 11, 2019
@PhilippBaranovskiy PhilippBaranovskiy added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure Project:Accessibility v7.3.0 labels Jun 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💔 Build Failed

@vitalics
Copy link
Contributor

a common issue with the previos master branch. Could you please update your source code. This issue was already solved
image

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@PhilippBaranovskiy
Copy link
Contributor Author

@vitalics, updated and checked, please have a look one more time, please.

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rockfield can we get this label of time interval box to read as timespan? Is that possible? Right now screenreader reads it as "checkmark second".
Screen Shot 2019-06-11 at 2 46 19 PM

@vitalics
Copy link
Contributor

code LGTM for me

@PhilippBaranovskiy
Copy link
Contributor Author

@rockfield can we get this label of time interval box to read as timespan? Is that possible? Right now screenreader reads it as "checkmark second".

@bhavyarm let's create another issue and update that <select> later?
Here the one: #38794
If you think it's good to add some further details, please update the ticket.

@PhilippBaranovskiy
Copy link
Contributor Author

@bhavyarm does it work?

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as we are fixing the aria-label in a different PR

@PhilippBaranovskiy PhilippBaranovskiy merged commit 7225591 into elastic:master Jun 12, 2019
@PhilippBaranovskiy PhilippBaranovskiy deleted the 19448 branch June 12, 2019 18:46
PhilippBaranovskiy added a commit to PhilippBaranovskiy/kibana that referenced this pull request Jun 12, 2019
…lastic#38396)

* Replace <span> with a <label for=''> used as a label for a dropdown <select>
* Change CSS selector for functional test
PhilippBaranovskiy added a commit that referenced this pull request Jun 12, 2019
…38396) (#38819)

* Replace <span> with a <label for=''> used as a label for a dropdown <select>
* Change CSS selector for functional test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Discover Discover Application Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.0 WCAG A
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time bucket size selector on discover is missing label
4 participants