Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📕 Storybook for everyone #38943

Closed
wants to merge 57 commits into from
Closed

📕 Storybook for everyone #38943

wants to merge 57 commits into from

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Jun 13, 2019 •
edited
Loading

Enabling Storybook for everyone.

  • Sets up storybook for siem and infra
  • Loads stories only for specific plugin
  • Canvas Storybook still works as before

See instructions:

yarn storybook

Run siem stories:

yarn storybook siem

Run infra stories:

yarn storybook infra

Run canvas stories:

yarn storybook canvas

@streamich streamich requested a review from a team as a code owner June 13, 2019 22:25
@streamich streamich added the release_note:skip Skip the PR/issue when compiling release notes label Jun 13, 2019
@streamich streamich mentioned this pull request Jun 13, 2019
Closed
4 tasks
@elastic elastic deleted a comment from elasticmachine Jun 13, 2019
@streamich streamich requested review from a team as code owners July 10, 2019 19:42
@elastic elastic deleted a comment from elasticmachine Jul 11, 2019
@elastic elastic deleted a comment from elasticmachine Jul 11, 2019
@elastic elastic deleted a comment from elasticmachine Jul 11, 2019
@elastic elastic deleted a comment from elasticmachine Jul 11, 2019
@elastic elastic deleted a comment from elasticmachine Jul 11, 2019
@elastic elastic deleted a comment from elasticmachine Jul 16, 2019
@elastic elastic deleted a comment from elasticmachine Jul 16, 2019
@elastic elastic deleted a comment from elasticmachine Jul 18, 2019
@elastic elastic deleted a comment from elasticmachine Jul 19, 2019
@elastic elastic deleted a comment from elasticmachine Jul 19, 2019
@elastic elastic deleted a comment from elasticmachine Jul 19, 2019
@elastic elastic deleted a comment from elasticmachine Jul 19, 2019
@stacey-gammon
Copy link
Contributor

are you waiting on review from canvas and ops team?

@elastic elastic deleted a comment from elasticmachine Aug 15, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

spalger
spalger reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request review from @elastic/kibana-operations once the tests are passing

@streamich
Copy link
Contributor Author

streamich commented Aug 27, 2019 •
edited
Loading

Closing this in favor of #43529, which is exactly the same but correctly resolves merge conflicts.

@spalger in #43529 If I use devDependencies in @kbn/storybook I get import/no-extraneous-dependencies, but if I use just dependencies I get "Import paths are too long on Windows.". Any hints how to solve this?

@streamich streamich closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger left review comments

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Operations Team label for Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@streamich @elasticmachine @clintandrewhall @stacey-gammon @jasonrhodes @spalger