Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📕 Storybook for everyone #38943

Closed
wants to merge 57 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
ac31c51
chore: 🤖 load stories from /src folder, too
streamich May 29, 2019
15ad998
test: 💍 add CertificateFingerprint examples
streamich Jun 8, 2019
cc7e2cb
test: 💍 add AndOrBadge examples
streamich Jun 8, 2019
685570b
test: 💍 add InfraLoadingPanel examples
streamich Jun 8, 2019
5975592
test: 💍 add SuggestionItem examples
streamich Jun 8, 2019
fe93590
chore: 🤖 run Storybook only for specific plugins
streamich Jun 13, 2019
e9b04a0
chore: remove test file
streamich Jun 13, 2019
e44ce1c
test: 💍 add <AutoSizer> story
streamich Jun 13, 2019
1e55e08
chore: 🤖 don't namespace story names
streamich Jun 13, 2019
dbe6c14
test: 💍 add <FormattedDuration> stories
streamich Jun 13, 2019
06c2e5c
Merge branch 'master' into storybook
streamich Jul 8, 2019
538cbd5
Merge branch 'master' into storybook
streamich Jul 10, 2019
4e0c059
[dev-utils] add types for procRunner
Jun 13, 2019
8e8d6ed
save
Jun 14, 2019
7489e35
chore: 🤖 clean up merge
streamich Jul 10, 2019
bfd696e
chore: 🤖 add translations back
streamich Jul 10, 2019
6c1bb38
chore: 🤖 add Storybook config to SIEM
streamich Jul 10, 2019
4c115cd
Merge branch 'master' into storybook
streamich Jul 11, 2019
4647e0c
chore: 🤖 WIP
streamich Jul 11, 2019
9911be0
chore: 🤖 fix Storybooh HTML head import
streamich Jul 11, 2019
980b78b
chore: 🤖 add script for loading Storybook with `yarn storybook`
streamich Jul 12, 2019
e1a03de
refactor: 💡 rename exampleGlobs to storyGlobs
streamich Jul 12, 2019
3796354
Merge remote-tracking branch 'upstream/master' into storybook
streamich Jul 12, 2019
b447ccd
chore: 🤖 use same expression for storybook paths
streamich Jul 12, 2019
8aec6aa
chore: 🤖 clean up PR
streamich Jul 12, 2019
c859924
chore: 🤖 clean up PR - 2
streamich Jul 12, 2019
f89c833
chore: 🤖 add webpackHook extension for Storybooks
streamich Jul 12, 2019
2058923
chore: 🤖 fix Canvas Storybook
streamich Jul 12, 2019
8990b37
Merge remote-tracking branch 'upstream/master' into storybook
streamich Jul 12, 2019
d211cac
fix: 🐛 fix Canvas Popover component
streamich Jul 12, 2019
4b504d8
Merge remote-tracking branch 'upstream/master' into storybook
streamich Jul 12, 2019
1db12ab
fix: 🐛 fix TS typings
streamich Jul 12, 2019
890df7a
style: 💄 fix linter error
streamich Jul 12, 2019
92061ef
chore: 🤖 add @kbn/pm file to fix CI error
streamich Jul 12, 2019
13c84e7
chore: 🤖 remove unused file
streamich Jul 12, 2019
f39a75e
chore: 🤖 fix linter error
streamich Jul 12, 2019
e162192
Merge branch 'master' of github.com:elastic/kibana into pr/38943
Jul 12, 2019
ecb5458
cleanup dev/run usage
Jul 12, 2019
4b3970b
chore: 🤖 don't error on file casing
streamich Jul 12, 2019
f019d63
Merge branch 'master' into storybook
streamich Jul 16, 2019
843619d
fix: 🐛 fix Popover missing prop error
streamich Jul 16, 2019
7c1f98e
fix: 🐛 make sure Storybook currentConfig folder exists
streamich Jul 16, 2019
d15ab30
Merge branch 'master' into storybook
streamich Jul 16, 2019
24182c3
chore: 🤖 add license to @kbn/storybook
streamich Jul 16, 2019
7578cae
Merge branch 'master' of github.com:elastic/kibana into storybook
streamich Jul 16, 2019
6d0d85f
Merge branch 'master' of github.com:elastic/kibana into storybook
streamich Jul 18, 2019
93321d9
Merge remote-tracking branch 'upstream/master' into storybook
streamich Jul 19, 2019
c915c5e
chore: 🤖 revert back packages/kbn-pm/dist/index.js changes
streamich Jul 19, 2019
3b6bec6
chore: 🤖 add newline to pm dist file
streamich Jul 19, 2019
48eff0f
chore: 🤖 delete pm dist file
streamich Jul 19, 2019
7b6afc7
chore: 🤖 add back pm dist file
streamich Jul 19, 2019
a1df950
chore: 🤖 catch up with master
streamich Aug 15, 2019
801b652
chore: 🤖 remove unexisting package from package.json
streamich Aug 15, 2019
e437ff7
chore: 🤖 run yarn kbn run build -i @kbn/pm
streamich Aug 15, 2019
b910c4a
chore: 🤖 catch up with master
streamich Aug 15, 2019
94e35e3
chore: 🤖 sync proc_runner with master
streamich Aug 15, 2019
3acebad
chore: 🤖 fix type_check
streamich Aug 15, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ module.exports = {
'packages/kbn-test-subj-selector/**/*',
'packages/kbn-test/**/*',
'packages/kbn-eslint-import-resolver-kibana/**/*',
'packages/kbn-storybook/**/*',
'src/legacy/server/saved_objects/**/*',
'x-pack/legacy/plugins/apm/**/*',
'x-pack/legacy/plugins/canvas/**/*',
Expand Down Expand Up @@ -247,6 +248,7 @@ module.exports = {
'packages/kbn-ui-framework/**/*.js',
'x-pack/**/*.js',
'packages/kbn-interpreter/**/*.js',
'packages/kbn-storybook/**/*',
],
rules: {
'import/no-extraneous-dependencies': [
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"core:acceptApiChanges": "node scripts/check_core_api_changes.js --accept",
"kbn:bootstrap": "yarn build:types && node scripts/register_git_hook",
"spec_to_console": "node scripts/spec_to_console",
"storybook": "node scripts/storybook",
"backport-skip-ci": "backport --prDescription \"[skip-ci]\""
},
"repository": {
Expand Down Expand Up @@ -211,6 +212,7 @@
"react-dom": "^16.8.0",
"react-grid-layout": "^0.16.2",
"react-hooks-testing-library": "^0.5.0",
"react-test-renderer": "^16.8.6",
"react-input-range": "^1.3.0",
"react-markdown": "^3.4.1",
"react-redux": "^5.1.1",
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-dev-utils/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ export { withProcRunner } from './proc_runner';
export { ToolingLog, ToolingLogTextWriter, pickLevelFromFlags } from './tooling_log';
export { createAbsolutePathSerializer } from './serializers';
export { CA_CERT_PATH, ES_KEY_PATH, ES_CERT_PATH } from './certs';
export { ProcRunner } from './proc_runner/proc_runner';
20 changes: 20 additions & 0 deletions packages/kbn-dev-utils/src/proc_runner/index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

export * from './with_proc_runner';
38 changes: 38 additions & 0 deletions packages/kbn-dev-utils/src/proc_runner/proc_runner.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

export class ProcRunner {
run(
name: string,
options: {
cmd: string;
args?: string[];
cwd?: string;
stdin?: string | Buffer;
wait?: RegExp | true;
env?: { [key: string]: string };
}
): Promise<void>;

stop(name: string, signal?: string): Promise<void>;

waitForAllToStop(): Promise<void>;

teardown(signal: string): Promise<void>;
}
27 changes: 27 additions & 0 deletions packages/kbn-dev-utils/src/proc_runner/with_proc_runner.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { ToolingLog } from '../tooling_log';
import { ProcRunner } from './proc_runner';

export { ProcRunner };
export function withProcRunner(
log: ToolingLog,
block: (procs: ProcRunner) => Promise<void>
): Promise<void>;
Loading