Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] [Accessibility] "Select this row" checkbox reads description #39821

Closed
wants to merge 1 commit into from

Conversation

PhilippBaranovskiy
Copy link
Contributor

@PhilippBaranovskiy PhilippBaranovskiy commented Jun 27, 2019

Related #28390

On hold

This PR is fully packed and waits until EUI version newer than 12.1.0 is being merged into Kibana.
Once 12.1.1+ version is merged, the associated issue #28390 is ready to be marked fixed.
This PR is ready to be merged already now.

Summary

It uses selectableMessage method to construct a proper title and aria-label attributes.
Further details can be found in that PR: elastic/eui#2043

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@PhilippBaranovskiy
Copy link
Contributor Author

Updated:

Once 12.1.1+ version is merged, the associated issue #28390 is ready to be marked fixed.
This PR is ready to be merged already now.

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson
Copy link
Contributor

Closing in favour of #40149 which uses the job ID rather than the description (which may be blank, and not unique).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants