Shape data plugin into standard shim form #42238

lizozom · 2019-07-30T10:37:08Z

Summary

Shape data plugin into standard shim form.

MIGRATION.md updated to match these changes. #42338

Dev Docs

New plugin shape

data/public/index.ts - export types & static code
data/public/plugin.ts - defines the plugin services
data/public/legacy.ts - import any legacy dependencies we have, and shim them into our plugin
data/public/setup.ts - compatibility with 7.3 docs
data/public/shim/legacy_dependencies_plugin
data/public/shim/legacy_module

Loading plugin instance

// Old
import { data } from 'plugins/data/setup';

// New way added
import { setup as data } from 'plugins/data/legacy';

// The previous way is still supported!
import { data } from 'plugins/data/setup';

Loading legacy directives

Moved all remaining angular directives (from the filter service, others were already deleted) into the shim folder.

// Up to 7.3
import { data } from 'plugins/data/setup';	
data.filter.loadLegacyDirectives();	

// New, as a result of the new legacy dependencies plugin
import 'plugins/data/legacy';

Loading react components

// Up to 7.3
import { data } from 'plugins/data/setup';	
const QueryBar = data.ui.QueryBar;

<QueryBar>...

// New 
import { QueryBar } from 'plugins/data';	

<QueryBar>...

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…plugin/new-shape

elasticmachine · 2019-07-30T11:23:11Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-07-30T12:17:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-30T13:11:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…plugin/new-shape

elasticmachine · 2019-07-30T14:14:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…plugin/new-shape

elasticmachine · 2019-07-30T15:13:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-30T15:52:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Chnaged to relative imports

elasticmachine · 2019-07-30T16:15:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-30T16:40:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…plugin/new-shape

lizozom · 2019-07-30T17:33:10Z

retest

elasticmachine · 2019-07-30T18:41:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lukeelmers

Overall makes sense! Added a couple notes, all pretty minor.

In this PR, do you think you could also update the legacy / new platform chart in the migration guide to ensure it has the most accurate info based on these changes? The platform team has asked that we try to keep this up-to-date as it helps people understand where to find things.

src/legacy/core_plugins/data/public/index.ts

src/legacy/core_plugins/data/public/setup.ts

src/legacy/core_plugins/data/public/shim/legacy_module.ts

src/legacy/core_plugins/kibana/public/visualize/index.js

src/legacy/core_plugins/metrics/public/components/annotations_editor.js

src/legacy/ui/public/agg_types/buckets/filters.js

src/legacy/core_plugins/metrics/public/components/vis_types/metric/series.test.tsx

src/legacy/core_plugins/metrics/public/components/vis_types/gauge/series.test.tsx

…plugin/new-shape

elasticmachine · 2019-07-31T08:09:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-31T10:15:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

lizozom · 2019-07-31T10:52:52Z

@alexwizp #42159 depends on this PR.

lizozom · 2019-07-31T16:02:23Z

@lukeelmers docs updated #42338

elasticmachine · 2019-08-01T11:00:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/core_plugins/data/public/shim/legacy_module.ts

alexwizp

TSVB changes looks good to me. Thanks

…plugin/new-shape

elasticmachine · 2019-08-01T13:29:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

lukeelmers

LGTM! And thanks for opening #42338!

* Merge to 7.x * lint

elasticmachine · 2019-08-19T12:25:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Update data plugin shape

9f0133c

lizozom requested a review from a team July 30, 2019 10:37

lizozom added the release_note:skip Skip the PR/issue when compiling release notes label Jul 30, 2019

lizozom self-assigned this Jul 30, 2019

Liza K added 3 commits July 30, 2019 14:14

type fixes

5569313

fix core start import

bfefe9d

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

941e686

…plugin/new-shape

lizozom added Feature:New Platform Team:AppArch v7.4.0 v8.0.0 labels Jul 30, 2019

lizozom requested a review from a team July 30, 2019 11:23

lizozom mentioned this pull request Jul 30, 2019

Pass uiSettings to all data plugin services #42159

Merged

7 tasks

Fixed tests

333d928

Liza K added 2 commits July 30, 2019 16:13

fix another test mock

2d09451

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

8797f63

…plugin/new-shape

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

b8bde7e

…plugin/new-shape

Liza K added 2 commits July 30, 2019 18:53

Brought back setup.ts for backward compatibility.

62f912b

Chnaged to relative imports

bad import from data plugin

dd558fd

Yet another import :-(

dfccf57

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

5644e3d

…plugin/new-shape

lukeelmers reviewed Jul 30, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

3959d82

…plugin/new-shape

Code revire #1 @lukeelmers

7989aa5

Liza K added 2 commits August 1, 2019 10:54

use IndexPatterns type

468db17

import order

a0e7f23

alexwizp reviewed Aug 1, 2019

View reviewed changes

src/legacy/core_plugins/data/public/shim/legacy_module.ts Show resolved Hide resolved

alexwizp reviewed Aug 1, 2019

View reviewed changes

src/legacy/core_plugins/data/public/shim/legacy_module.ts Show resolved Hide resolved

alexwizp reviewed Aug 1, 2019

View reviewed changes

src/legacy/core_plugins/data/public/shim/legacy_module.ts Show resolved Hide resolved

alexwizp approved these changes Aug 1, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

445a583

…plugin/new-shape

lukeelmers approved these changes Aug 1, 2019

View reviewed changes

lizozom merged commit 9bf9ac3 into elastic:master Aug 1, 2019

lizozom mentioned this pull request Aug 1, 2019

[7.x] Shape data plugin into standard shim form (#42238) #42446

Merged

lukeelmers added Feature:NP Migration and removed Feature:New Platform labels Aug 1, 2019

lizozom pushed a commit that referenced this pull request Aug 1, 2019

[7.x] Shape data plugin into standard shim form (#42238) (#42446)

bf907b4

* Merge to 7.x * lint

This was referenced Aug 6, 2019

Export type for TSetup on plugin top level #42665

Closed

Ensure DataSetup is exported from data public contract. #42784

Merged

lizozom mentioned this pull request Aug 19, 2019

Implement saved queries and filters #39140

Merged

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shape data plugin into standard shim form #42238

Shape data plugin into standard shim form #42238

lizozom commented Jul 30, 2019 •

edited

Loading

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

lizozom commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

lukeelmers left a comment

elasticmachine commented Jul 31, 2019

elasticmachine commented Jul 31, 2019

lizozom commented Jul 31, 2019

lizozom commented Jul 31, 2019

elasticmachine commented Aug 1, 2019

alexwizp left a comment

elasticmachine commented Aug 1, 2019

lukeelmers left a comment

elasticmachine commented Aug 19, 2019

Shape data plugin into standard shim form #42238

Shape data plugin into standard shim form #42238

Conversation

lizozom commented Jul 30, 2019 • edited Loading

Summary

Dev Docs

New plugin shape

Loading plugin instance

Loading legacy directives

Loading react components

Checklist

For maintainers

elasticmachine commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

💔 Build Failed

elasticmachine commented Jul 30, 2019

💔 Build Failed

elasticmachine commented Jul 30, 2019

💔 Build Failed

elasticmachine commented Jul 30, 2019

💔 Build Failed

elasticmachine commented Jul 30, 2019

💔 Build Failed

elasticmachine commented Jul 30, 2019

💔 Build Failed

elasticmachine commented Jul 30, 2019

💔 Build Failed

lizozom commented Jul 30, 2019

elasticmachine commented Jul 30, 2019

💔 Build Failed

lukeelmers left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

lizozom commented Jul 31, 2019

lizozom commented Jul 31, 2019

elasticmachine commented Aug 1, 2019

💚 Build Succeeded

alexwizp left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 1, 2019

💚 Build Succeeded

lukeelmers left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 19, 2019

💔 Build Failed

lizozom commented Jul 30, 2019 •

edited

Loading