Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI enhancement: handle descriptions for visualizations (#20936) #44702

Merged
merged 5 commits into from
Sep 12, 2019
Merged

GUI enhancement: handle descriptions for visualizations (#20936) #44702

merged 5 commits into from
Sep 12, 2019

Conversation

friol
Copy link
Contributor

@friol friol commented Sep 3, 2019 •
edited by lizozom
Loading

Summary

As asked in Issue #20936, this PR:

  • Allows to save a description for a view from the GUI
  • Shows the description in the view list
  • Shows an "info" icon on the right of the view name when in a dashboard; hovering the icon shows the description within a tooltip

I've updated the jest tests to match the new "save visualization" modal.

Dev Docs

  • Allow adding a description in the visualization save form.
  • Show the description in the visualizations list
  • Shows an "info" icon on the right of the visualization when in a dashboard; hovering the icon shows the description within a toolti.

@friol friol requested a review from a team as a code owner September 3, 2019 19:46
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ppisljar ppisljar added the review label Sep 4, 2019
@ppisljar ppisljar requested a review from a team September 4, 2019 10:15
ppisljar
ppisljar approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for app arch related changes

@ppisljar
Copy link
Member

ppisljar commented Sep 4, 2019

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@friol
Copy link
Contributor Author

friol commented Sep 4, 2019

@ppisljar : I don't see how that functional test error can be related to my code. Could it be an occasional timeout? I tried to reproduce the error on my machine, but the test seems to pass.
Thanks.

@ppisljar
Copy link
Member

ppisljar commented Sep 5, 2019

can you merge master, maybe thats the cause ? then i'll rerun the tests

@friol
Copy link
Contributor Author

friol commented Sep 5, 2019

@ppisljar Done.

@ppisljar
Copy link
Member

ppisljar commented Sep 5, 2019

retest

@ppisljar ppisljar requested a review from a team September 5, 2019 13:12
@ppisljar ppisljar added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Sep 11, 2019
@lizozom
Copy link
Contributor

lizozom commented Sep 11, 2019 •
edited
Loading

@friol
Tested this PR and it looks good.
If you could just merge master again, I will approve and merge the PR.

@friol
Copy link
Contributor Author

friol commented Sep 11, 2019

@friol
Tested this PR and it looks good.
If you could just merge master again, I will approve and merge the PR.

@lizozom : Done!

lizozom
lizozom approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppisljar
Copy link
Member

jenkins, test this

@lizozom
Copy link
Contributor

lizozom commented Sep 12, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit df21530 into elastic:master Sep 12, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Sep 12, 2019
@friol
GUI enhancement: handle descriptions for visualizations (elastic#20936)…
91873de 
… (elastic#44702)

* Adds descriptions to visualizations

* Adds descriptions to visualizations

* Tests on the saved object (visualization) modal
@lizozom lizozom mentioned this pull request Sep 12, 2019
Merged
lizozom pushed a commit that referenced this pull request Sep 12, 2019
GUI enhancement: handle descriptions for visualizations (#20936) (#44702
1bc029b 
) (#45535)

* Adds descriptions to visualizations

* Adds descriptions to visualizations

* Tests on the saved object (visualization) modal
This was referenced Oct 16, 2019
Closed
Closed
@alexfrancoeur
Copy link

Woah, great addition! This is a huge enhancement 🍾

@knightian
Copy link

knightian commented Oct 30, 2020 •
edited
Loading

image
How to use this? Despite having descriptions of all my visualisations, only one of them is showing the tool tip???? Spent ages looking for a way to enable on each visualisation.

@govindrai
Copy link

govindrai commented Jul 18, 2022 •
edited
Loading

Hi, how do you add descriptions to visualizations that you don't want to save to the visualize library? I only see the option to add descriptions when saving to the Library and I don't want these visualizations to be used elsewhere.
image

@markov00
Copy link
Member

@govindrai you are right, we have an open request to add the ability to edit the description directly from the dashboard panel #83743
Please signup or 👍 to the issue to increase its priority
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
release_note:enhancement release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@friol @elasticmachine @ppisljar @lizozom @alexfrancoeur @knightian @govindrai @markov00