Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Shim UI exports for new platform #44722
[Uptime] Shim UI exports for new platform #44722
Changes from 29 commits
8b83f05
2e64147
7b0bf2d
f02a501
97398d0
cf2eb8c
9fd78a1
ee9f07e
790c81a
1bdc942
6e31ccc
dd10627
9e5c726
01751a0
597fe4e
f10988f
0bc7395
838175c
342b945
1608782
160ecf8
e5cb213
13297ea
638b589
d46be5f
4a83b40
6f5da20
da2e6f1
7098397
bb33f37
a9c696d
1d54f0b
9f5577a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rudolf it looks like
setRootTemplate
is slated as being available for 7.5... is this the case? If so we can delete the legacyui/chrome
import and rely entirely onStartObject
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, I learned from #46481 that this function isn't going to be offered in the same way in the NP, so we do need this dependency for now.
This file was deleted.
This file was deleted.
This file was deleted.