[Uptime] Shim UI exports for new platform #44722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
Feature:New Platform
v8.0.0
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime |
💔 Build Failed |
shahzad31
reviewed
Sep 4, 2019
justinkambic
force-pushed
the
uptime_shim-ui-exports
branch
from
b5d5183 to
6e31ccc
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
rudolf
reviewed
Sep 27, 2019
There was a problem hiding this comment.
The shape of your shim looks good. I found one more import that will have to be injected from the top of your shim at some point instead of being imported from 'ui/*': https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/uptime/public/components/functional/kuery_bar/index.tsx#L9
ui/index_patterns has been moved to the data plugin, so you can also start consuming it from the data plugin by injecting it into your shim instead of the 'ui/*' import:
https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/uptime/public/components/functional/kuery_bar/index.tsx#L13
💚 Build Succeeded |
|
@elasticmachine merge upstream |
rudolf
approved these changes
Oct 2, 2019
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
justinkambic
added a commit
that referenced
this pull request
Oct 3, 2019
* Remove depdency on legacy interface. * Remove custom interface, use common breadcrumb type. * Add HTML template for app react entry point. * Update app props. * Add constant for react app entry point. * Remove dependency on legacy capabilities provider. * Delete legacy kibana framework adapter. * Add New Platform adapter, reference in startup code. * Remove dependency on legacy capabilities function. * Delete reference to obsolete interface. * Fix busted types in new adapter. * Add new plugin class, delete old bootstrap code. * Provide default for potentially-undefined value. * Delete obsolete file. * Update plugin constructor and start interfaces. * Add @ts-ignore for unused constructor parameter. * Import autocomplete provider from new platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per #44682 we are beginning work on the Uptime app's migration to the new platform.
The goal of this patch is to shim any usage of legacy
uiexports in preparation for the move of the Uptime plugin to the new platform. In place of the old framework, we leverage the updated exports provided by the new platform'score.Testing this PR
This patch should cause the plugin to run in the same manner as in
master. As such there shouldn't need to be any test modifications or additions.You should smoke test this by loading the application and running it normally. Ensure you can filter, search, drill into a monitor, etc., but aside from that there are no special functionality additions or reductions.
Part of your review should be an attempt to ensure that we are no longer referencing legacy
uiexports, aside from those required to keep the application functioning as we straddle the old and new platforms.