-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI / ML] Add partitioning to log entry rate job #46690
[Logs UI / ML] Add partitioning to log entry rate job #46690
Conversation
💔 Build Failed |
…oning-to-log-rate-job
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual inspection of the results written by ML looks good. Of course, the data returned by our log entry rate results api will be incorrect until it has been adapted (see #46459).
One thought just appeared: Even though we haven't shipped this feature, we might want to increment the job revision in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
...acy/plugins/ml/server/models/data_recognizer/modules/logs_ui_analysis/ml/log_entry_rate.json
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
* Add partitioning to log rate job
Summary
Closes #46583 by adding partitioning to the log entry rate job, using the ECS
event.dataset
field.cc @elastic/infra-logs-ui