[Logs UI] Support partitioned log rate results in API #46751

weltenwort · 2019-09-26T23:20:24Z

⚠️ ~~This is WIP and contains unmerged commits of prior PR #46690~~.

Summary

This changes the log entry rate result API response such that it returns partitioned log rate results. It also adapts the client-side consumption to match the new data structures. To do so it replaces the line chart with a rudimentary bar chart that demonstrates the usage.

closes #46459

TODO

rebase on master after [Logs UI / ML] Add partitioning to log entry rate job #46690 and [Logs UI] Remove table view from Analysis feature #46688 have been merged
adapt api tests

Implementation Notes

The chart is only a demo placeholder until [Logs UI/Design] Improve log rate visualization #46399 has been implemented (code for this can be given a cursory glance, but doesn't need in depth review as it will likely change).
~~The table view remains in a broken state because it will be removed by [Logs UI] Remove table view from Analysis feature #46688 soon.~~

Previews

Checklist

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…oning-to-log-rate-job

elasticmachine · 2019-09-26T23:20:26Z

Pinging @elastic/infra-logs-ui

elasticmachine · 2019-09-27T00:37:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-28T00:48:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-28T19:42:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…partition-log-rate-results

elasticmachine · 2019-10-01T10:53:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

x-pack/legacy/plugins/infra/public/pages/logs/analysis/page_results_content.tsx

elasticmachine · 2019-10-02T15:49:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

jasonrhodes

Looks great. My only comment is I would avoid using "dataSet" as the actual code-level variable name and just call it "partition" since nothing about this implementation couples this to using event.dataset, but everything works great so we can talk about that in a future PR if that's easier. :)

katrin-freihofner · 2019-10-03T09:07:52Z

Prototype: https://www.figma.com/proto/T08kdh6YQcVCx1tzljqNHF/Logs-ML-Integration-v1?node-id=275%3A34562&viewport=-3797%2C-2816%2C1&scaling=min-zoom

katrin-freihofner · 2019-10-03T09:08:29Z

Open questions and things to discuss/explore:

Kerry350 · 2019-10-03T09:39:16Z

@jasonrhodes Thanks for reviewing 👍 Cool, I can see that point. I'll note it down and we can handle it later as it's not urgent or user facing. Just waiting for a build before merging as there were some dead translations.

elasticmachine · 2019-10-03T10:40:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8f16977

Kerry350 · 2019-10-03T11:01:16Z

@elasticmachine merge upstream

Kerry350 · 2019-10-03T11:01:47Z

Became outdated whilst building 🙈

elasticmachine · 2019-10-03T12:13:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8342965

* Add partitioning to log rate results API

…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...

* Add partitioning to log rate results API

Kerry350 and others added 3 commits September 26, 2019 12:00

Add partitioning to log rate job

8de93e2

Merge remote-tracking branch 'upstream/master' into 46583-add-partiti…

bd75441

…oning-to-log-rate-job

Adapt log rate result API to return partitioned values

6504c23

weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Sep 26, 2019

weltenwort self-assigned this Sep 26, 2019

weltenwort added 2 commits September 28, 2019 01:29

Move log entry rate query to separate file for readability

df4845a

Adapt log entry rate api consumers

3bd2276

weltenwort added 4 commits September 28, 2019 20:05

Display partitons in a bar chart

7690874

Remove unused files

42256ec

Move log entry rate api call into separate file

e18f210

Remove anomaly count as per feedback

a5334c6

Merge remote-tracking branch 'upstream/master' into logs-ui-analysis-…

dfdbe00

…partition-log-rate-results

Kerry350 self-assigned this Oct 1, 2019

Amend API tests

9c69b36

Kerry350 marked this pull request as ready for review October 2, 2019 14:46

Kerry350 requested a review from a team as a code owner October 2, 2019 14:46

afgomez reviewed Oct 2, 2019

View reviewed changes

x-pack/legacy/plugins/infra/public/pages/logs/analysis/page_results_content.tsx Show resolved Hide resolved

jasonrhodes approved these changes Oct 3, 2019

View reviewed changes

Remove unused translations

8f16977

Merge branch 'master' into logs-ui-analysis-partition-log-rate-results

8342965

Kerry350 merged commit 8e9f17d into elastic:master Oct 3, 2019

Kerry350 mentioned this pull request Oct 3, 2019

[7.x] [Logs UI] Support partitioned log rate results in API (#46751) #47215

Merged

Kerry350 pushed a commit to Kerry350/kibana that referenced this pull request Oct 3, 2019

[Logs UI] Support partitioned log rate results in API (elastic#46751)

c73a911

* Add partitioning to log rate results API

Kerry350 mentioned this pull request Oct 4, 2019

[Logs UI] Adapt log entry rate data visualisations to new designs #47201

Closed

Kerry350 added a commit that referenced this pull request Oct 7, 2019

[Logs UI] Support partitioned log rate results in API (#46751) (#47215)

1c738ce

* Add partitioning to log rate results API

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Support partitioned log rate results in API #46751

[Logs UI] Support partitioned log rate results in API #46751

weltenwort commented Sep 26, 2019 •

edited by Kerry350

Loading

elasticmachine commented Sep 26, 2019

elasticmachine commented Sep 27, 2019

elasticmachine commented Sep 28, 2019

elasticmachine commented Sep 28, 2019

elasticmachine commented Oct 1, 2019

elasticmachine commented Oct 2, 2019

jasonrhodes left a comment

katrin-freihofner commented Oct 3, 2019

katrin-freihofner commented Oct 3, 2019

Kerry350 commented Oct 3, 2019

elasticmachine commented Oct 3, 2019

Kerry350 commented Oct 3, 2019

Kerry350 commented Oct 3, 2019

elasticmachine commented Oct 3, 2019

[Logs UI] Support partitioned log rate results in API #46751

[Logs UI] Support partitioned log rate results in API #46751

Conversation

weltenwort commented Sep 26, 2019 • edited by Kerry350 Loading

Summary

TODO

Implementation Notes

Previews

Checklist

For maintainers

elasticmachine commented Sep 26, 2019

elasticmachine commented Sep 27, 2019

💔 Build Failed

elasticmachine commented Sep 28, 2019

💔 Build Failed

elasticmachine commented Sep 28, 2019

💔 Build Failed

elasticmachine commented Oct 1, 2019

💔 Build Failed

elasticmachine commented Oct 2, 2019

💔 Build Failed

jasonrhodes left a comment

Choose a reason for hiding this comment

katrin-freihofner commented Oct 3, 2019

katrin-freihofner commented Oct 3, 2019

Kerry350 commented Oct 3, 2019

elasticmachine commented Oct 3, 2019

💚 Build Succeeded

Kerry350 commented Oct 3, 2019

Kerry350 commented Oct 3, 2019

elasticmachine commented Oct 3, 2019

💚 Build Succeeded

weltenwort commented Sep 26, 2019 •

edited by Kerry350

Loading