Fix export all #4954
Merged
Fix export all #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks good |
|
Created 301 dashboards and 1 visualization, and the export contained all 302 items. LGTM! |
This was referenced Sep 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4902.
Prior to this PR, the Export button at the top of the page on the saved object screen (Settings -> Objects) would not always export everything.
If you searched using the filter on that page, then hit the export button, only the results of the current search would be exported.
Only a maximum of 100 results show up by default, so if you had more than 100 dashboards, searches, or visualizations, then only the first 100 would be exported.
This PR changes it so that everything is exported, and changes the text to show that this is, in fact, what is intended by the button, so there is no confusion.
To accomplish this, we now make a request to Elasticsearch to grab all of the objects, instead of just exporting what's in view.