Fix Export All - Backport of 4954 #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var self = this; | ||
| size = size || 100; |
There was a problem hiding this comment.
Hmm, I guess technically it's possible to pass in 0 as the size here (which could be valid, if you were just doing this.find to end up getting the total back, and weren't interested in the actual docs). Maybe doing a check for undefined or our standard != null might be better here...
w33ble
force-pushed
the
export-all-backport
branch
from
81e2963 to
02c018d
Compare
|
LGTM. |
lukasolson
added a commit
that referenced
this pull request
Sep 17, 2015
Fix Export All - Backport of 4954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4954 for details.
Converted to ES5 and applied to the 4.1 branch.