Display changed field formats without requiring hard page refresh. #53746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
Feature:NP Migration
v7.6.0
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
streamich
approved these changes
Dec 23, 2019
src/plugins/data/public/field_formats_provider/field_formats.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/field_formats_provider/field_formats.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/field_formats_provider/field_formats.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>
💚 Build SucceededTo update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 23, 2019
…lastic#53746) * Display changed field formats without requiring hard page refresh. * Update src/plugins/data/public/field_formats_provider/field_formats.ts Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * fix PR commetns Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Dec 23, 2019
…53746) (#53771) * Display changed field formats without requiring hard page refresh. * Update src/plugins/data/public/field_formats_provider/field_formats.ts Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * fix PR commetns Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
…lastic#53746) * Display changed field formats without requiring hard page refresh. * Update src/plugins/data/public/field_formats_provider/field_formats.ts Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com> * fix PR commetns Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #35235
Summary
Resolves an issue where changing a field format and navigating back to discover/visualizations/dashboard requires a hard page refresh in order to see the changes that were made. This relates to the issue reported in #35235
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers