Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Transaction page throws unhandled exception if transactions doesn't have http.request #53760

Merged
merged 2 commits into from
Dec 24, 2019
Merged

[APM] Transaction page throws unhandled exception if transactions doesn't have http.request #53760

merged 2 commits into from
Dec 24, 2019

Conversation

cauemarcondes
Copy link
Contributor

closes #52648

@cauemarcondes cauemarcondes added bug Fixes for quality problems that affect the customer experience v7.6.0 labels Dec 23, 2019
@cauemarcondes cauemarcondes requested a review from a team as a code owner December 23, 2019 11:33
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv reviewed Dec 23, 2019
View reviewed changes
x-pack/legacy/plugins/apm/public/components/shared/Summary/TransactionSummary.test.tsx Outdated
});
});
describe('renders RUM transaction without request info', () => {
const transaction: Transaction = exampleTransactions.httpRumOK;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the explicit type

Suggested change
const transaction: Transaction = exampleTransactions.httpRumOK;
const transaction = exampleTransactions.httpRumOK;

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 3b0cce0 into elastic:master Dec 24, 2019
@cauemarcondes cauemarcondes deleted the optional-request branch December 24, 2019 09:33
@cauemarcondes cauemarcondes mentioned this pull request Dec 24, 2019
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 24, 2019
@cauemarcondes
[APM] Transaction page throws unhandled exception if transactions doe…
0d3d057 
…sn't have `http.request` (elastic#53760)

* Making http.request optional

* changing unit test
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/conso…
13e7c02 
…le-saved-objects

* 'master' of github.com:elastic/kibana: (250 commits)
  Allow chromeless applications to render via non-/app routes (elastic#51527)
  Add server rendering service to enable standalone route rendering (elastic#52161)
  Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220)
  Update maps telemetry mappings to account for recent updates (elastic#53803)
  [Maps] Only show legend when layer is visible (elastic#53781)
  remove use of experimental fs.promises api (elastic#53346)
  [APM] Add log statements for flaky test (elastic#53775)
  [APM] Transaction page throws unhandled exception if transactions doesn't have  `http.request` (elastic#53760)
  Licensing plugin functional tests (elastic#53580)
  [Lens] Disable saving visualization until there are no changes to the document (elastic#52982)
  [Monitoring] Added safeguard for some EUI components (elastic#53318)
  [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605)
  Display changed field formats without requiring hard page refresh. (elastic#53746)
  Upgrade EUI to v17.3.1 (elastic#53655)
  [APM] Fix missing apm indicies (elastic#53541)
  Disable inspector for timelion (elastic#53747)
  Clean up search servie (elastic#53701)
  [Dashboard] Grid: removing double handler (elastic#53707)
  Remove SavedObjectRegistryProvider from codebase (elastic#53455)
  Move ui/courier into data shim plugin (elastic#52359)
  ...
cauemarcondes added a commit that referenced this pull request Jan 6, 2020
@cauemarcondes
[APM] Transaction page throws unhandled exception if transactions doe…
0736909 
…sn't have `http.request` (#53760) (#53785)

* Making http.request optional

* changing unit test
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
@cauemarcondes @jkelastic
[APM] Transaction page throws unhandled exception if transactions doe…
e3da3ca 
…sn't have `http.request` (elastic#53760)

* Making http.request optional

* changing unit test
@dgieselaar dgieselaar self-assigned this Jan 20, 2020
@dgieselaar
Copy link
Member

Tested by removing http.request for a transaction document, and inspecting the transaction summary component.

@dgieselaar dgieselaar added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@dgieselaar dgieselaar

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience release_note:enhancement v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Transaction page throws unhandled exception if transactions doesn't have http.request
5 participants
@cauemarcondes @kibanamachine @dgieselaar @sorenlouv @ogupte