[Maps] Add categorical styling #54408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
force-pushed
the
maps/add_categories
branch
4 times, most recently
from
721ad06 to
db8ad51
Compare
thomasneirynck
force-pushed
the
maps/add_categories
branch
from
d259e1b to
b8f0aa3
Compare
thomasneirynck
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
remove cruft remove cruft more palettes move options to size as well default rename auto-select tmp stops for consistency fix legend toggle behavior add default stop subdued text color custom legend
thomasneirynck
force-pushed
the
maps/add_categories
branch
from
b8f0aa3 to
8454f19
Compare
thomasneirynck
force-pushed
the
maps/add_categories
branch
from
a31ee38 to
87fac2c
Compare
check vlaidyt
add unit test for legend rendering more tests
thomasneirynck
force-pushed
the
maps/add_categories
branch
from
17235bd to
599b1a4
Compare
thomasneirynck
force-pushed
the
maps/add_categories
branch
from
34eec16 to
1c52a14
Compare
restore deal with incomplete config
thomasneirynck
force-pushed
the
maps/add_categories
branch
from
1c52a14 to
17d51ac
Compare
nreese
reviewed
Jan 14, 2020
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js
Outdated
Show resolved
Hide resolved
nreese
reviewed
Jan 14, 2020
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style_defaults.js
Outdated
Show resolved
Hide resolved
nreese
approved these changes
Jan 14, 2020
thomasneirynck
changed the title
kindsun
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
✨ Great addition! Thanks for the lifecycle updates to color_map_select. Offline we discussed one more hopefully quick fix for occasionally passing an undefined color value to mapbox which causes an error but doesn't appear to affect functionality. Otherwise, works smoothly! lgtm
- tested locally in chrome
- code review
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
thx @aaronjcaldwell , 0532b65 should address the undefined branch coloring issue. |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 15, 2020
This allows users to style fields by category. Users can either uses one of default color palettes or specify a custom ramp.
nickpeihl
pushed a commit
that referenced
this pull request
Jan 15, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 15, 2020
* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
This allows users to style fields by category. Users can either uses one of default color palettes or specify a custom ramp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32202 by adding categorical styling for color properties.
Scope
String fields can be matched to a color
Using a custom palette
Using one of the default palettes.
When using one of the default palettes, the top ten terms from the underlying data are used to style the features.
To keep this PR as small as possible, it excludes some additional features. These can be addressed in subsequent PRs: