[Endpoint] FIX: Increase saga tests `sleep()` default duration back to 100ms #55492

paul-tavares · 2020-01-22T00:04:05Z

Summary

Revert sleep() default duration, in the saga tests, back to 100ms in order to prevent intermittent failures during CI runs.

Fixes #55464
Fixes #55465

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~[ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~[ ] This was checked for breaking API changes and was labeled appropriately~~
~~[ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

kibanamachine · 2020-01-22T01:20:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d1a6689

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kevinlog · 2020-01-22T14:24:09Z

x-pack/plugins/endpoint/public/applications/endpoint/lib/saga.test.ts

  const INCREMENT_COUNTER = 'INCREMENT';
  const DELAYED_INCREMENT_COUNTER = 'DELAYED INCREMENT COUNTER';
  const STOP_SAGA_PROCESSING = 'BREAK ASYNC ITERATOR';

-  const sleep = (ms = 10) => new Promise(resolve => setTimeout(resolve, ms));
+  const sleep = (ms = 100) => new Promise(resolve => setTimeout(resolve, ms));


I'm worried about this continuing to be a problem down the road. I assume 10 was intermittent depending on resources during CI. 100 would certainly make it occur less often, but kibana is a constantly growing application. Just weighing the values of this test vs. the risk of intermittent failures. What are your thoughts?

Yeah, I looked at this for a while yesterday trying to see if there was another way. Because this lib is the core for us doing side-effects, I think there is high value in ensuring that it behaves as expected. I searched around other x-pack plugins and I do see 100 (or in some cases higher values) being used. Because there are not allot of tests here, I can also increase the ms to a higher number in order to try to avoid this type of failure again.

got it, thanks for the reply and taking a look around at the other plugins.

* Add Endpoint plugin and Resolver embeddable (#51994) * Add functional tests for plugins to x-pack (so we can do a functional test of the Resolver embeddable) * Add Endpoint plugin * Add Resolver embeddable * Test that Resolver embeddable can be rendered Conflicts: x-pack/.i18nrc.json x-pack/test/api_integration/apis/index.js * [Endpoint] Register endpoint app (#53527) * register app, create functional test * formatting * update tests * adjust test data for endpoint * add endpoint tests for testing spaces, app enabled, disabled, etc * linting * add read privileges to endpoint * rename variable since its used now * remove deprecated context * remove unused variable * fix type check * correct test suite message Co-Authored-By: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * [Endpoint] add react router to endpoint app (#53808) * add react router to endpoint app * linting * linting * linting * correct tests * change history from hash to browser, add new test util * remove default values in helper functions * fix type check, use FunctionComponent as oppsed to FC * use BrowserRouter component * use BrowserRouter component lin * add comments to test framework, change function name to include browserHistory Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * EMT-issue-65: add endpoint list api (#53861) add endpoint list api * EMT-65:always return accurate endpoint count (#54423) EMT-65:always return accurate endpoint count, independent of paging properties * Resolver component w/ sample data (#53619) Resolver is a map. It shows processes that ran on a computer. The processes are drawn as nodes and lines connect processes with their parents. Resolver is not yet implemented in Kibana. This PR adds a 'map' type UX. The user can click and drag to pan the map and zoom using trackpad pinching (or ctrl and mousewheel.) There is no code providing actual data. Sample data is included. The sample data is used to draw a map. The fundamental info needed is: process names the parent of a process With this info we can topologically lay out the processes. The sample data isn't yet in a realistic format. We'll be fixing that soon. Related issue: elastic/endpoint-app-team#30 * Resolver test plugin not using mount context. (#54933) Mount context was deprecated. Use core.getStartServices() instead. * Resolver nonlinear zoom (#54936) * [Endpoint] add Redux saga Middleware and app Store (#53906) * Added saga library * Initialize endpoint app redux store * Resolver is overflow: hidden to prevent obscured elements from showing up (#55076) * [Endpoint] Fix saga to start only after store is created and stopped on app unmount (#55245) - added `stop()`/`start()` methods to the Saga Middleware creator factory - adjust tests based on changes - changed application `renderApp` to stop sagas when react app is unmounted * Resolver zoom, pan, and center controls (#55221) * Resolver zoom, pan, and center controls * add tests, fix north panning * fix type issue * update west and east panning to behave like google maps * [Endpoint] FIX: Increase tests `sleep` default duration back to 100ms (#55492) Revert `sleep()` default duration, in the saga tests, back to 100ms in order to prevent intermittent failures during CI runs. Fixes #55464 Fixes #55465 * [Endpoint] EMT-65: make endpoint data types common, restructure (#54772) [Endpoint] EMT-65: make endpoint data types common, use schema changes * Basic Functionality Alert List (#55800) * sets up initial grid and data type * data feeds in from backend but doesnt update * sample data feeding in correctly * Fix combineReducers issue by importing Redux type from 'redux' package * Add usePageId hook that fires action when user navigates to page * Strict typing for middleware * addresses comments and uses better types * move types to common/types.ts * Move types to endpoint/types.ts, address PR comments blah 2 Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com> * [Endpoint] Add Endpoint Details route (#55746) * Add Endpoint Details route * add Endpoint Details tests * sacrifices to the Type gods * update to latest endpoint schema Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Endpoint] EMT-67: add kql support for endpoint list (#56328) [Endpoint] EMT-67: add kql support for endpoint list * [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (#56538) * ERT-82 ERT-83 ERT-84 (partial): Add Alert List API with pagination * Better type safety for alert list API * Add Test to Verify Endpoint App Landing Page (#57129) Conflicts: x-pack/test/functional/page_objects/index.ts * fixes render bug in alert list (#57152) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolver: Animate camera, add sidebar (#55590) This PR adds a sidebar navigation. clicking the icons in the nav will focus the camera on the different nodes. There is an animation effect when the camera moves. Conflicts: yarn.lock * [Endpoint] Task/basic endpoint list (#55623) * Adds host management list to endpoint security plugin Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Endpoint] Policy List UI route and initial view (#56918) * Initial Policy List view * Add `endpoint/policy` route and displays Policy List * test cases (both unit and functional) Does not yet interact with API (Ingest). * Add ApplicationService app status management (#50223) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. * Implements `getStartServices` on server-side (#55156) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. * [ui/utils/query_string]: Remove unused methods & migrate apps to querystring lib (#56957) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: nnamdifrankie <56440728+nnamdifrankie@users.noreply.github.com> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com> Co-authored-by: Dan Panzarella <pzl@users.noreply.github.com> Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com> Co-authored-by: Charlie Pichette <56399229+charlie-pichette@users.noreply.github.com> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

Increase sleep default duration back to 100ms

d1a6689

paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 Team:Endpoint Response Endpoint Response Team Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Endpoint Management labels Jan 22, 2020

paul-tavares requested review from parkiino and kevinlog January 22, 2020 14:06

kevinlog reviewed Jan 22, 2020

View reviewed changes

kevinlog approved these changes Jan 22, 2020

View reviewed changes

paul-tavares merged commit e2230d5 into elastic:master Jan 22, 2020

paul-tavares deleted the fix/saga-test-sleep branch January 22, 2020 16:55

kevinlog added the Feature:Endpoint Elastic Endpoint feature label Feb 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Endpoint] FIX: Increase saga tests `sleep()` default duration back to 100ms #55492

[Endpoint] FIX: Increase saga tests `sleep()` default duration back to 100ms #55492

paul-tavares commented Jan 22, 2020

kibanamachine commented Jan 22, 2020

kevinlog Jan 22, 2020

paul-tavares Jan 22, 2020

kevinlog Jan 22, 2020

[Endpoint] FIX: Increase saga tests sleep() default duration back to 100ms #55492

[Endpoint] FIX: Increase saga tests sleep() default duration back to 100ms #55492

Conversation

paul-tavares commented Jan 22, 2020

Summary

Checklist

For maintainers

kibanamachine commented Jan 22, 2020

💚 Build Succeeded

kevinlog Jan 22, 2020

Choose a reason for hiding this comment

paul-tavares Jan 22, 2020

Choose a reason for hiding this comment

kevinlog Jan 22, 2020

Choose a reason for hiding this comment

[Endpoint] FIX: Increase saga tests `sleep()` default duration back to 100ms #55492

[Endpoint] FIX: Increase saga tests `sleep()` default duration back to 100ms #55492