Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixing "aggs" use in datafeeds #56002

Conversation

jgowdyelastic
Copy link
Member

Fixing bug when loading aggregations from the datafeed config. If the shortened aggs key is used, the fields would not be found.

Relates to #55180 and so doesn't require its own release notes.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.6.0 labels Jan 27, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner January 27, 2020 13:40
@jgowdyelastic jgowdyelastic self-assigned this Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 6f0bfa0 into elastic:master Jan 27, 2020
@jgowdyelastic jgowdyelastic deleted the fixing-aggs-rather-than-aggregations-use-in-datafeeds branch January 27, 2020 15:22
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jan 27, 2020
* [ML] Fixing "aggs" use in datafeeds

* removing use of Record
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jan 27, 2020
* [ML] Fixing "aggs" use in datafeeds

* removing use of Record
jgowdyelastic added a commit that referenced this pull request Jan 27, 2020
* [ML] Fixing "aggs" use in datafeeds

* removing use of Record
jgowdyelastic added a commit that referenced this pull request Jan 27, 2020
* [ML] Fixing "aggs" use in datafeeds

* removing use of Record
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants