Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Improving job wizards with datafeed aggregations #55180

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jan 17, 2020

Fixes issue where jobs using aggregations cannot be configured correctly in the advanced job wizard. This also means that jobs created in the original advanced wizard cannot be cloned.

When a datafeed contains a script_fields or aggregations section, the additional fields from these sections should be made available for selection in the wizards.

Also adds doc_source as an option in the summary count field select if aggregations are being used.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic marked this pull request as ready for review January 17, 2020 15:01
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner January 17, 2020 15:01
@jgowdyelastic jgowdyelastic self-assigned this Jan 17, 2020
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection release_note:fix review v7.6.0 v7.7.0 v8.0.0 labels Jan 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic force-pushed the improving-job-wizards-with-datafeed-aggregations branch from 62b3a57 to 6facb00 Compare January 20, 2020 09:53
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #21085 succeeded 62b3a575ca1f9019159bbab3b3762240f6b28c06
  • 💚 Build #21071 succeeded 97925eab008afd703e40c5a0e7cb9e63be1d82b4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 82ab1a6 into elastic:master Jan 20, 2020
@jgowdyelastic jgowdyelastic deleted the improving-job-wizards-with-datafeed-aggregations branch January 20, 2020 13:24
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jan 20, 2020
* [ML] Improving job wizards with datafeed aggregations

* picking all agg keys for fields

* function move and rename
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jan 20, 2020
* [ML] Improving job wizards with datafeed aggregations

* picking all agg keys for fields

* function move and rename
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
* upstream/master: (24 commits)
  Show error page when accessing unavailable app (elastic#54656)
  [ML] Improving job wizards with datafeed aggregations (elastic#55180)
  remove flaly assetion. a license presence tested anyway (elastic#55289)
  fix commonly used ranges uptime (elastic#54930)
  [SIEM] Use proper icons on Detections view (elastic#55215)
  Fix: invalid translation referenced (elastic#54901)
  [State Management] Remove AppState from edit_index_pattern page (elastic#54104)
  Implements `getStartServices` on server-side (elastic#55156)
  Move vis_vega_type/data_model tests to jest (elastic#55186)
  [SIEM] [Detection Engine] Update status on rule details page (elastic#55201)
  Fix KQL value suggestions for nested fields (elastic#54820)
  Enforce camelCase format for a plugin id (elastic#53759)
  [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069)
  Remove nested root from index pattern (elastic#54978)
  [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198)
  [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252)
  [SIEM] Detections add alert & signal tab (elastic#55127)
  Management API - redirect on disabled app path (elastic#55136)
  [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags
  update local (elastic#55177)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
* master: (108 commits)
  [ML] Single Metric Viewer: Fix job check. (elastic#55191)
  Show error page when accessing unavailable app (elastic#54656)
  [ML] Improving job wizards with datafeed aggregations (elastic#55180)
  remove flaly assetion. a license presence tested anyway (elastic#55289)
  fix commonly used ranges uptime (elastic#54930)
  [SIEM] Use proper icons on Detections view (elastic#55215)
  Fix: invalid translation referenced (elastic#54901)
  [State Management] Remove AppState from edit_index_pattern page (elastic#54104)
  Implements `getStartServices` on server-side (elastic#55156)
  Move vis_vega_type/data_model tests to jest (elastic#55186)
  [SIEM] [Detection Engine] Update status on rule details page (elastic#55201)
  Fix KQL value suggestions for nested fields (elastic#54820)
  Enforce camelCase format for a plugin id (elastic#53759)
  [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069)
  Remove nested root from index pattern (elastic#54978)
  [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198)
  [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252)
  [SIEM] Detections add alert & signal tab (elastic#55127)
  Management API - redirect on disabled app path (elastic#55136)
  [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags
  ...
jgowdyelastic added a commit that referenced this pull request Jan 20, 2020
* [ML] Improving job wizards with datafeed aggregations

* picking all agg keys for fields

* function move and rename
jgowdyelastic added a commit that referenced this pull request Jan 20, 2020
* [ML] Improving job wizards with datafeed aggregations

* picking all agg keys for fields

* function move and rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants