Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Filter pill base coloring #56761

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 4, 2020

One of the latest EUI updates brought an unwanted change to the filter pill coloring. This is a quick fix.

7.5

Screen Shot 2020-02-04 at 11 36 43 AM

7.6 / Master

Screen Shot 2020-02-03 at 14 23 44 PM

This PR

Screen Shot 2020-02-03 at 14 23 25 PM

@cchaos cchaos requested a review from ryankeairns February 4, 2020 16:43
@cchaos cchaos requested a review from a team as a code owner February 4, 2020 16:43
@cchaos cchaos added the release_note:skip Skip the PR/issue when compiling release notes label Feb 4, 2020
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cchaos cchaos merged commit b92e8e2 into elastic:master Feb 4, 2020
cchaos added a commit to cchaos/kibana that referenced this pull request Feb 4, 2020
cchaos added a commit that referenced this pull request Feb 4, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 5, 2020
* master: (23 commits)
  Properly handle password change for users authenticated with provider other than `basic`. (elastic#55206)
  Improve pull request template proposal (elastic#56756)
  Only change handlers as the element changes (elastic#56782)
  [SIEM][Detection Engine] Final final rule changes (elastic#56806)
  [SIEM][Detection Engine] critical blocker, wrong ilm policy, need to match beats ilm policy
  Move ui/agg_types in to shim data plugin (elastic#56353)
  [SIEM] Fixes Signals count spinner (elastic#56797)
  [docs] Update upgrade version path (elastic#56658)
  [Canvas] Use unique Id for Canvas Embeddables (elastic#56783)
  [Rollups] Adjust max width for job detail panel (elastic#56674)
  Prevent http client from converting our form data (elastic#56772)
  Disable creating alerts client instances when ESO plugin is using an ephemeral encryption key (elastic#56676)
  Bumps terser-webpack-plugin to 2.3.4 (elastic#56662)
  Advanced settings component registry ⇒ kibana platform plugin (elastic#55940)
  [Endpoint] EMT-67: add kql support for endpoint list (elastic#56328)
  Implement UI for Create Alert form  (elastic#55232)
  Fix: Filter pill base coloring (elastic#56761)
  fix open close signal on detail page (elastic#56757)
  [Search service] Move loadingCount to sync search strategy (elastic#56335)
  Rollup TSVB integration: Add test and fix warning text (elastic#56639)
  ...
cchaos added a commit that referenced this pull request Feb 5, 2020
@cchaos cchaos deleted the fix-filter-pill-color branch October 1, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Filters release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants