Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fixes Signals count spinner #56797

Merged
merged 1 commit into from
Feb 4, 2020
Merged

[SIEM] Fixes Signals count spinner #56797

merged 1 commit into from
Feb 4, 2020

Conversation

andrew-goldstein
Copy link
Contributor

Fixes an issue where the Signals count spinner can spin forever

Per the animated gif below, in 7.6 BC 4, the Signals count spinner on the Overview page spins forever until the signals index is created (in the current Kibana space):

signals-count-loading-spinner

The Signals count spinner will spin forever until the user clicks the Detections tab, which-in turn creates the signals index (if it doesn't exist), per the animated gif below:

create-signals-index

This behavior is an issue because:

  • When a fresh deployment is created on Elastic Cloud, a user won't understand why the Signals count widget is always spinning on the Overview page. (The user must click the Detections page to resolve this.)
  • In deployments where authentication is disabled, or, for reasons, a Detections index will never be created, the Signals count spinner on the Overview page will always spin.

To reproduce:

  1. Spin up a new 7.6 BC 4 deployment on Elastic Cloud
  2. Login to Kibana for the first time
  3. Navigate to the SIEM app

Expected result

  • All histograms on the Overview page eventually stop displaying their respective loading spinners

Actual result

  • The Signals count widget spinner spins forever. (The user must click the Detections tab to create the signals index.)

Deleting the signals index

To reproduce the issue above when a signals index has already been created (by clicking on the Detections tab), run the following from the Kibana Dev Tools Console:

DELETE /.siem-signals-default-000001

It is also possible to reproduce this issue by creating a new space, because it won't have a signals index.

https://github.com/elastic/siem-team/issues/514

@andrew-goldstein
## Fixes an issue where the Signals count spinner can spin forever
96316eb 
Per the animated gif below, in `7.6` `BC 4`, the `Signals count` spinner on the Overview page spins forever until the signals index is created (in the current Kibana space):

![signals-count-loading-spinner](https://user-images.githubusercontent.com/4459398/73785251-2ca42000-4754-11ea-8671-daa81f351c9b.gif)

The `Signals count` spinner will spin forever until the user clicks the `Detections` tab, which-in turn creates the signals index (if it doesn't exist), per the animated gif below:

![create-signals-index](https://user-images.githubusercontent.com/4459398/73785319-4ba2b200-4754-11ea-9bb0-a745a8b2be5d.gif)

This behavior is an issue because:

- When a fresh deployment is created on Elastic Cloud, a user won't understand why the `Signals count` widget is always spinning on the `Overview` page. (The user must click the `Detections` page to resolve this.)
- In deployments where authentication is disabled, or, for _reasons_, a Detections index will never be created, the `Signals count` spinner on the Overview page will always spin.

To reproduce:

1. Spin up a new `7.6` `BC 4` deployment on Elastic Cloud
2. Login to Kibana for the first time
3. Navigate to the SIEM app

**Expected result**
- All histograms on the Overview page eventually stop displaying their respective loading spinners

**Actual result**
- The `Signals count` widget spinner spins forever. (The user must click the `Detections` tab to create the signals index.)

## Deleting the signals index

To reproduce the issue above when a signals index has already been created (by clicking on the Detections tab), run the following from the Kibana `Dev Tools` `Console`:

```
DELETE /.siem-signals-default-000001
```

It is also possible to reproduce this issue by creating a new space, because it won't have a signals index.

elastic/siem-team#514
@andrew-goldstein andrew-goldstein added bug Fixes for quality problems that affect the customer experience critical Team:SIEM v8.0.0 v7.7.0 v7.6.0 labels Feb 4, 2020
@andrew-goldstein andrew-goldstein self-assigned this Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Feb 4, 2020
XavierM
XavierM approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on code reviewed.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit 2fc1f79 into elastic:master Feb 4, 2020
@andrew-goldstein andrew-goldstein deleted the fix-signals-count-spinner branch February 4, 2020 22:24
This was referenced Feb 4, 2020
Merged
Merged
andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this pull request Feb 4, 2020
@andrew-goldstein
[SIEM] Fixes Signals count spinner (elastic#56797)
d74782c 
## Fixes an issue where the Signals count spinner can spin forever

Per the animated gif below, in `7.6` `BC 4`, the `Signals count` spinner on the Overview page spins forever until the signals index is created (in the current Kibana space):

![signals-count-loading-spinner](https://user-images.githubusercontent.com/4459398/73785251-2ca42000-4754-11ea-8671-daa81f351c9b.gif)

The `Signals count` spinner will spin forever until the user clicks the `Detections` tab, which-in turn creates the signals index (if it doesn't exist), per the animated gif below:

![create-signals-index](https://user-images.githubusercontent.com/4459398/73785319-4ba2b200-4754-11ea-9bb0-a745a8b2be5d.gif)

This behavior is an issue because:

- When a fresh deployment is created on Elastic Cloud, a user won't understand why the `Signals count` widget is always spinning on the `Overview` page. (The user must click the `Detections` page to resolve this.)
- In deployments where authentication is disabled, or, for _reasons_, a Detections index will never be created, the `Signals count` spinner on the Overview page will always spin.

To reproduce:

1. Spin up a new `7.6` `BC 4` deployment on Elastic Cloud
2. Login to Kibana for the first time
3. Navigate to the SIEM app

**Expected result**
- All histograms on the Overview page eventually stop displaying their respective loading spinners

**Actual result**
- The `Signals count` widget spinner spins forever. (The user must click the `Detections` tab to create the signals index.)

## Deleting the signals index

To reproduce the issue above when a signals index has already been created (by clicking on the Detections tab), run the following from the Kibana `Dev Tools` `Console`:

```
DELETE /.siem-signals-default-000001
```

It is also possible to reproduce this issue by creating a new space, because it won't have a signals index.

elastic/siem-team#514
andrew-goldstein added a commit that referenced this pull request Feb 4, 2020
@andrew-goldstein
[SIEM] Fixes Signals count spinner (#56797) (#56810)
1f485c8 
## Fixes an issue where the Signals count spinner can spin forever

Per the animated gif below, in `7.6` `BC 4`, the `Signals count` spinner on the Overview page spins forever until the signals index is created (in the current Kibana space):

![signals-count-loading-spinner](https://user-images.githubusercontent.com/4459398/73785251-2ca42000-4754-11ea-8671-daa81f351c9b.gif)

The `Signals count` spinner will spin forever until the user clicks the `Detections` tab, which-in turn creates the signals index (if it doesn't exist), per the animated gif below:

![create-signals-index](https://user-images.githubusercontent.com/4459398/73785319-4ba2b200-4754-11ea-9bb0-a745a8b2be5d.gif)

This behavior is an issue because:

- When a fresh deployment is created on Elastic Cloud, a user won't understand why the `Signals count` widget is always spinning on the `Overview` page. (The user must click the `Detections` page to resolve this.)
- In deployments where authentication is disabled, or, for _reasons_, a Detections index will never be created, the `Signals count` spinner on the Overview page will always spin.

To reproduce:

1. Spin up a new `7.6` `BC 4` deployment on Elastic Cloud
2. Login to Kibana for the first time
3. Navigate to the SIEM app

**Expected result**
- All histograms on the Overview page eventually stop displaying their respective loading spinners

**Actual result**
- The `Signals count` widget spinner spins forever. (The user must click the `Detections` tab to create the signals index.)

## Deleting the signals index

To reproduce the issue above when a signals index has already been created (by clicking on the Detections tab), run the following from the Kibana `Dev Tools` `Console`:

```
DELETE /.siem-signals-default-000001
```

It is also possible to reproduce this issue by creating a new space, because it won't have a signals index.

elastic/siem-team#514
andrew-goldstein added a commit that referenced this pull request Feb 4, 2020
@andrew-goldstein
[SIEM] Fixes Signals count spinner (#56797) (#56809)
f48c339 
## Fixes an issue where the Signals count spinner can spin forever

Per the animated gif below, in `7.6` `BC 4`, the `Signals count` spinner on the Overview page spins forever until the signals index is created (in the current Kibana space):

![signals-count-loading-spinner](https://user-images.githubusercontent.com/4459398/73785251-2ca42000-4754-11ea-8671-daa81f351c9b.gif)

The `Signals count` spinner will spin forever until the user clicks the `Detections` tab, which-in turn creates the signals index (if it doesn't exist), per the animated gif below:

![create-signals-index](https://user-images.githubusercontent.com/4459398/73785319-4ba2b200-4754-11ea-9bb0-a745a8b2be5d.gif)

This behavior is an issue because:

- When a fresh deployment is created on Elastic Cloud, a user won't understand why the `Signals count` widget is always spinning on the `Overview` page. (The user must click the `Detections` page to resolve this.)
- In deployments where authentication is disabled, or, for _reasons_, a Detections index will never be created, the `Signals count` spinner on the Overview page will always spin.

To reproduce:

1. Spin up a new `7.6` `BC 4` deployment on Elastic Cloud
2. Login to Kibana for the first time
3. Navigate to the SIEM app

**Expected result**
- All histograms on the Overview page eventually stop displaying their respective loading spinners

**Actual result**
- The `Signals count` widget spinner spins forever. (The user must click the `Detections` tab to create the signals index.)

## Deleting the signals index

To reproduce the issue above when a signals index has already been created (by clicking on the Detections tab), run the following from the Kibana `Dev Tools` `Console`:

```
DELETE /.siem-signals-default-000001
```

It is also possible to reproduce this issue by creating a new space, because it won't have a signals index.

elastic/siem-team#514
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 5, 2020
@gmmorris
Merge branch 'master' into alerting/get-alert-state
a34c0cb 
* master: (23 commits)
  Properly handle password change for users authenticated with provider other than `basic`. (elastic#55206)
  Improve pull request template proposal (elastic#56756)
  Only change handlers as the element changes (elastic#56782)
  [SIEM][Detection Engine] Final final rule changes (elastic#56806)
  [SIEM][Detection Engine] critical blocker, wrong ilm policy, need to match beats ilm policy
  Move ui/agg_types in to shim data plugin (elastic#56353)
  [SIEM] Fixes Signals count spinner (elastic#56797)
  [docs] Update upgrade version path (elastic#56658)
  [Canvas] Use unique Id for Canvas Embeddables (elastic#56783)
  [Rollups] Adjust max width for job detail panel (elastic#56674)
  Prevent http client from converting our form data (elastic#56772)
  Disable creating alerts client instances when ESO plugin is using an ephemeral encryption key (elastic#56676)
  Bumps terser-webpack-plugin to 2.3.4 (elastic#56662)
  Advanced settings component registry ⇒ kibana platform plugin (elastic#55940)
  [Endpoint] EMT-67: add kql support for endpoint list (elastic#56328)
  Implement UI for Create Alert form  (elastic#55232)
  Fix: Filter pill base coloring (elastic#56761)
  fix open close signal on detail page (elastic#56757)
  [Search service] Move loadingCount to sync search strategy (elastic#56335)
  Rollup TSVB integration: Add test and fix warning text (elastic#56639)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@XavierM XavierM XavierM approved these changes

Assignees

@andrew-goldstein andrew-goldstein

Labels
bug Fixes for quality problems that affect the customer experience critical release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrew-goldstein @elasticmachine @kibanamachine @XavierM @patrykkopycinski