Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transform: Remove duplicate page main landmarks #56883

Merged
merged 3 commits into from
Feb 6, 2020
Merged

[ML] Transform: Remove duplicate page main landmarks #56883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c8b05e
[ML] Transform: Remove duplicate page main landmarks
peteharverson Feb 5, 2020
74437e1
[ML] Removed unused import
peteharverson Feb 6, 2020
60b3709
Merge branch 'master' into transforms-fix-duplicate-main
elasticmachine Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 45 additions & 48 deletions ...egacy/plugins/transform/public/app/sections/create_transform/create_transform_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiPageContent,
EuiPageBody,
EuiPageContentBody,
EuiSpacer,
EuiTitle,
Expand All @@ -41,53 +40,51 @@ export const CreateTransformSection: FC<Props> = ({ match }) => {
return (
<PrivilegesWrapper privileges={APP_CREATE_TRANSFORM_CLUSTER_PRIVILEGES}>
<KibanaProvider savedObjectId={match.params.savedObjectId}>
<EuiPageBody data-test-subj="transformPageCreateTransform">
<EuiPageContent>
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1>
<FormattedMessage
id="xpack.transform.transformsWizard.createTransformTitle"
defaultMessage="Create transform"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformsWizard.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformsWizard.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformsWizard.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<RenderOnlyWithInitializedKibanaContext>
<Wizard />
</RenderOnlyWithInitializedKibanaContext>
</EuiPageContentBody>
</EuiPageContent>
</EuiPageBody>
<EuiPageContent data-test-subj="transformPageCreateTransform">
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1>
<FormattedMessage
id="xpack.transform.transformsWizard.createTransformTitle"
defaultMessage="Create transform"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformsWizard.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformsWizard.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformsWizard.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<RenderOnlyWithInitializedKibanaContext>
<Wizard />
</RenderOnlyWithInitializedKibanaContext>
</EuiPageContentBody>
</EuiPageContent>
</KibanaProvider>
</PrivilegesWrapper>
);
Expand Down
121 changes: 59 additions & 62 deletions ...ugins/transform/public/app/sections/transform_management/transform_management_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
EuiFlexItem,
EuiModal,
EuiOverlayMask,
EuiPageBody,
EuiPageContent,
EuiPageContentBody,
EuiSpacer,
Expand Down Expand Up @@ -74,68 +73,66 @@ export const TransformManagement: FC = () => {

return (
<Fragment>
<EuiPageBody data-test-subj="transformPageTransformList">
<EuiPageContent>
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1 data-test-subj="transformAppTitle">
<FormattedMessage
id="xpack.transform.transformList.transformTitle"
defaultMessage="Transforms"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformList.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformList.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformList.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiSpacer size="s" />
<EuiTitle size="s">
<EuiText color="subdued">
<FormattedMessage
id="xpack.transform.transformList.transformDescription"
defaultMessage="Use transforms to pivot existing Elasticsearch indices into summarized or entity-centric indices."
/>
</EuiText>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<TransformStatsBar transformsList={transforms} />
<EuiSpacer size="s" />
<TransformList
errorMessage={errorMessage}
isInitialized={isInitialized}
onCreateTransform={onOpenModal}
transforms={transforms}
transformsLoading={transformsLoading}
<EuiPageContent data-test-subj="transformPageTransformList">
<EuiTitle size="l">
<EuiFlexGroup alignItems="center">
<EuiFlexItem grow={true}>
<h1 data-test-subj="transformAppTitle">
<FormattedMessage
id="xpack.transform.transformList.transformTitle"
defaultMessage="Transforms"
/>
<span>&nbsp;</span>
<EuiBetaBadge
label={i18n.translate('xpack.transform.transformList.betaBadgeLabel', {
defaultMessage: `Beta`,
})}
tooltipContent={i18n.translate(
'xpack.transform.transformList.betaBadgeTooltipContent',
{
defaultMessage: `Transforms are a beta feature. We'd love to hear your feedback.`,
}
)}
/>
</h1>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
href={documentationLinksService.getTransformsDocUrl()}
target="_blank"
iconType="help"
data-test-subj="documentationLink"
>
<FormattedMessage
id="xpack.transform.transformList.transformDocsLinkText"
defaultMessage="Transform docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiTitle>
<EuiSpacer size="s" />
<EuiTitle size="s">
<EuiText color="subdued">
<FormattedMessage
id="xpack.transform.transformList.transformDescription"
defaultMessage="Use transforms to pivot existing Elasticsearch indices into summarized or entity-centric indices."
/>
</EuiPageContentBody>
</EuiPageContent>
</EuiPageBody>
</EuiText>
</EuiTitle>
<EuiPageContentBody>
<EuiSpacer size="l" />
<TransformStatsBar transformsList={transforms} />
<EuiSpacer size="s" />
<TransformList
errorMessage={errorMessage}
isInitialized={isInitialized}
onCreateTransform={onOpenModal}
transforms={transforms}
transformsLoading={transformsLoading}
/>
</EuiPageContentBody>
</EuiPageContent>
{isSearchSelectionVisible && (
<EuiOverlayMask>
<EuiModal
Expand Down