Expose Vis on the contract as it requires visTypes #56968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Dosant
commented
Feb 6, 2020
| }); | ||
| export const start = pluginInstance.start(npStart.core, { | ||
| ...npStart.plugins, | ||
| visualizations: visualizationsStart, |
There was a problem hiding this comment.
@ppisljar, is this correct way to pass visualizations until is not migrated to NP?
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
added
v7.7.0
v8.0.0
Feature:NP Migration
Feature:Visualizations
flash1293
approved these changes
Feb 6, 2020
|
Retest |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Feb 15, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
that referenced
this pull request
Feb 15, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 17, 2020
…re/files-and-filetree * 'master' of github.com:elastic/kibana: (139 commits) Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563) [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541) [ML] New Platform server shim: update indices routes (elastic#57685) Bump redux dependencies (elastic#53348) [Index management] Client-side NP ready (elastic#57295) change id of x-pack event_log plugin to eventLog (elastic#57612) [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607) revert allow using any path to generate fixes ui titles (elastic#57535) Fix login redirect for expired sessions (elastic#57157) Expose Vis on the contract as it requires visTypes (elastic#56968) [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present [Remote clusters] Migrate client-side code out of legacy (elastic#57365) Fix failed test reporter for SIEM Cypress use (elastic#57240) skip flaky suite (elastic#45244) update chromedriver to 80.0.1 (elastic#57602) change slack action to only report on whitelisted host name (elastic#57582) [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735) moving visualize/utils to new platform (elastic#56650) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dev Docs
In most of the places
Visused as a type, but in couple places it is used as a class.At the moment
Visas a class is not stateless, as it depends onvisTypes. As it is not stateless,Visclass was removed from public exports and exposed onvisualisationscontract instead:Visas interface still can be imported as:Checklist
Delete any items that are not applicable to this PR.
For maintainers