-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Precision function in Timelion Kibana #58031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
If you are changing default messages of phrases, please also delete them from the existing translation files x-pack/plugins/translations/translations/zh-CN.json
and x-pack/plugins/translations/translations/ja-JP.json
}), | ||
}, | ||
], | ||
help: i18n.translate('timelion.help.functions.precisionHelpText', { | ||
defaultMessage: 'number of digits to round the decimal portion of the value to', | ||
defaultMessage: 'The number of digists to truncate the decimal portion of the value to', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: digists
-> digits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Good catch, lol
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Closes issue 26100 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…-out-of-legacy * 'master' of github.com:elastic/kibana: (109 commits) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) Drilldown plugin (elastic#58097) [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033) [ML] New Platform server shim: update datafeed routes (elastic#57739) Add flag for building static storybook site (elastic#58050) add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075) [SIEM] Let us try out code owners for a little while and see what happens Add throttle param to Alerting readme (elastic#57609) [NP] Move ui/saved_objects to NP (elastic#57452) [Logs UI] Fix column reordering in settings page (elastic#58104) Fix browser date format (elastic#57714) Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402) Clarify Precision function in Timelion Kibana (elastic#58031) ... # Conflicts: # x-pack/.i18nrc.json
Summary
This PR closes issue #26100
Changed the text within
defaultMessage
in the precision.js file fromNumber of digits to round each value to
toThe number of digits to truncate each value to
, andnumber of digits to round the decimal potion of the value to
toThe number of digits to truncate the decimal portion of the value to
cc @KOTungseth
Checklist
Delete any items that are not applicable to this PR.
For maintainers