Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose serverBasePath on client-side #58070

Merged
merged 4 commits into from
Feb 20, 2020

Conversation

joshdover
Copy link
Contributor

Summary

Fixes #57583

Exposes the server base path on core.http.basePath.serverBasePath on the client to match the server-side API.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 19, 2020
@joshdover joshdover requested a review from a team as a code owner February 19, 2020 23:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover requested a review from a team as a code owner February 20, 2020 15:53
@joshdover joshdover requested a review from a team February 20, 2020 19:46
@joshdover joshdover requested a review from a team as a code owner February 20, 2020 19:46
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes lgtm. Seems like these snapshots are capturing way too much. Cc @majagrubic are you currently working in that area? If yes could you clean those up a little when you are touch the tests the next time? If not I can set up a separate PR.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover
Copy link
Contributor Author

Merging without code owners approval for snapshot test updates.

@joshdover joshdover merged commit 5238493 into elastic:master Feb 20, 2020
@joshdover joshdover deleted the np/client-server-base-path branch February 20, 2020 21:43
joshdover added a commit to joshdover/kibana that referenced this pull request Feb 20, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 21, 2020
…-out-of-legacy

* 'master' of github.com:elastic/kibana: (109 commits)
  document difference between log record formats (elastic#57798)
  Expose elasticsearch config schema (elastic#57655)
  [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130)
  [SIEM] Cleans Cypress tests code (elastic#58134)
  fix: 🐛 make dev server Storybook builds work again (elastic#58188)
  Prevent core savedObjects plugin from being overridden (elastic#58193)
  Expose serverBasePath on client-side (elastic#58070)
  Fix legend sizing on area charts (elastic#58083)
  Drilldown plugin (elastic#58097)
  [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033)
  [ML] New Platform server shim: update datafeed routes (elastic#57739)
  Add flag for building static storybook site (elastic#58050)
  add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075)
  [SIEM] Let us try out code owners for a little while and see what happens
  Add throttle param to Alerting readme (elastic#57609)
  [NP] Move ui/saved_objects to NP (elastic#57452)
  [Logs UI]  Fix column reordering in settings page (elastic#58104)
  Fix browser date format (elastic#57714)
  Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402)
  Clarify Precision function in Timelion Kibana (elastic#58031)
  ...

# Conflicts:
#	x-pack/.i18nrc.json
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 21, 2020
…_improve-advanced-settings-save

* commit '02efb01c481f9f24d8d707f06dfc68b2fb805001': (43 commits)
  [Endpoint] Add a flyout to alert list. (elastic#57926)
  Make sure index pattern has fields before parsing (elastic#58242)
  Sanitize workpad before sending to API (elastic#57704)
  [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015)
  [Endpoint] Refactor Management List Tests (elastic#58148)
  [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176)
  Do not refresh color scale on each lookup (elastic#57792)
  Updating to @elastic/lodash@3.10.1-kibana4 (elastic#54662)
  Trigger context (elastic#57870)
  [ML] Transforms: Adds clone feature to transforms list. (elastic#57837)
  [ML] New Platform server shim: update fields service routes (elastic#58060)
  [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)
  document difference between log record formats (elastic#57798)
  Expose elasticsearch config schema (elastic#57655)
  [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130)
  [SIEM] Cleans Cypress tests code (elastic#58134)
  fix: 🐛 make dev server Storybook builds work again (elastic#58188)
  Prevent core savedObjects plugin from being overridden (elastic#58193)
  Expose serverBasePath on client-side (elastic#58070)
  Fix legend sizing on area charts (elastic#58083)
  ...
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 21, 2020
joshdover added a commit that referenced this pull request Feb 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose serverBasePath on client-side
5 participants