Corrected heat intensity calculation on tilemap view.

[ghost]

Existing solution does not get minimum value of interval.
If we have temperature values from 23 to 27, then the heatmap is almost always red (maximum intensity) because:
[(value/max)_100] 23/27_100 = ~85,19%
If 23 is minimum value of interval it should be marked as blue on heatmap, so correct way to count heatintensity is:
(value - min)/(max - min)*100/(27-23)*100 = 0%

[elasticsearch-release]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[trevan]

This is probably the same thing as #5236 and #6014

[elasticsearch-release]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[epixa]

@karolurb-dev Can you submit the CLA? https://www.elastic.co/contributor-agreement/

[ghost]

The legal department of my company is checking CLAs. The case is in progress.

[adambro]

The CLA has been signed by the Future Processing company. It might be few days before all the paperwork lands where it belongs though. Any other action on our side?

[rashidkpc]

We'll keep an eye on this and ping you if we don't see the status change.

[adambro]

The CLA was been sent at Friday, so you should get it by now I hope.

Regarding code I see an issue, because PR #5236 changes heatIntensity scale to 0.0 - 1.0 range, which makes it incompatible with this PR. The #5236 has been merged to master already and backported to 4.x branch in #6371 PR.

[adambro]

CLA paperwork has been sorted out I guess, it was sent month ago. Any other thing that is blocking us right now?

[panda01]

@adambro you should just have to sign from here, it's an automated thing. Is that something you can do?

[adambro]

@panda01 the CLA has been signed by the company I work for (Future Processing), because the fix was developed during office hours, so it's company copyright. I know it's dull and nasty but, dura lex, sed lex. Anyway, my account and @karolurb-dev should be listed in the signed CLA, so that part of paperwork is sorted-out I hope. Is there anything else we can do?

[epixa]

I'm looking into this now. I'll update this PR when I have something.

[karmi]

Hi @karolurb-dev, you are correct that we have a corporate CLA signature for your company and that your Github handle is listed. @epixa, it's OK to merge from the CLA standpoint.

[epixa]

@adambro Is your issue fixed in 4.5.0 or 5.0.0-alpha2? #5236 isn't the exact same change, but it is related to a big with the heatmap intensities.

[adambro]

Indeed #5236 seems to be related, but it still does not address the issue with normalization and using whole scale linearly between down and up brackets, not only some upper percentile, like @karolurb-dev showed in 1st comment. So I guess it still applies to 4.4 branch as a bugfix.

On the other hand #6014 seems be be adding other scales, like log and sqrt as well, so it seems nice addition for the future maybe. Haven't got much time to look into it, though.

[panda01]

Jenkins, test it.

[epixa]

I think that test failure in the build is legitimate.

[panda01]

@karolurb-dev Can/Will you update this to fix the tests. I will run them again so you have a record of what failed?

[panda01]

Jenkins, test it

[epixa]

I'm going to close this due to inactivity. Please open a new pull request if you want to pick this back up.