[ui/filterContext] give access to root-level filter context

[spalger]

_Looking for feedback on design and, ideally, a better solution_

While working in a plugin I wanted to write a query that used the context of the "root search source", wether that was the dashboard or visualization search source I wanted it to include the filters from the filterbar and timefilter. To do this I created the ui/filterContext service. It has one method, getEsBoolQuery(), which formats the filters into a bool query.

This can then be consumed by a user like so:

var filterContext = Private(FilterContextProvider);
$scope.addGenericFetcher(function () {
  return filterContext.getEsBoolQuery().then(context => {
    return es.search({
      body: {
        query: context,
        aggs: {
          // ... some custom aggregations
        }
      }
    })
    .then(function (resp) {
      // ...
    });
  });
})

(example uses the courier's new generic search functions)

[rashidkpc]

I'm generally a fan of this functionality. I would consider what other configuration you might want to pass to getESBoolQuery(). For example, you may not want the time filter and it would be annoying to have to strip it out yourself.

Kibana 3 had similar functionality in its filter service where you could pass a list of filter ids you wanted.

https://github.com/elastic/kibana/blob/3.0/src/app/services/filterSrv.js#L130-L157

It was usually used in combination with the idsByType() function which let you retrieve the ids for a given type of filter:

https://github.com/elastic/kibana/blob/3.0/src/app/services/filterSrv.js#L130-L157

[rashidkpc]

@simianhacker thoughts on implementation?

[rashidkpc]

I'd also like to see a way to uniquely identify filters go along with this. For example, functionality that creates a filter will want a way to track and update that filter. Unique ids for filter would be helpful here.

[simianhacker]

It seems like it would work for what we need. Is there a PR for the addGenericFetcher() feature?

[epixa]

@spalger Do you have any plans to get back to this?

[spalger]

I don't have any plans, and my initial hesitation is even greater now, so I'll close