Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting link path in home feature #68889

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

sulemanof
Copy link
Contributor

Summary

Seems to be a regression after #65796

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexwizp
Copy link
Contributor

I think it should be also backported into 7.8 too

@sulemanof sulemanof marked this pull request as ready for review June 11, 2020 13:54
@sulemanof sulemanof added the release_note:skip Skip the PR/issue when compiling release notes label Jun 11, 2020
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this! Didn’t test locally but code LGTM. We should backport this to 7.8.

@sulemanof sulemanof merged commit c6ea29f into elastic:master Jun 11, 2020
@sulemanof sulemanof deleted the fix/reporting_link branch June 11, 2020 13:56
sulemanof added a commit to sulemanof/kibana that referenced this pull request Jun 11, 2020
# Conflicts:
#	x-pack/plugins/reporting/public/plugin.tsx
sulemanof added a commit that referenced this pull request Jun 12, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants