Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8] Fix reporting link path in home feature (#68889) #68899

Closed
wants to merge 1 commit into from

Conversation

sulemanof
Copy link
Contributor

Backports the following commits to 7.8:

# Conflicts:
#	x-pack/plugins/reporting/public/plugin.tsx
@@ -112,7 +112,7 @@ export class ReportingPublicPlugin implements Plugin<void, void> {
defaultMessage: 'Manage your reports generated from Discover, Visualize, and Dashboard.',
}),
icon: 'reportingApp',
path: '/app/kibana#/management/kibana/reporting',
path: '/app/management/insightsAndAlerting/reporting',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexwizp @cjcenizal are you sure this should be backported into 7.8 ?
It seems the section is registered in kibana

management.sections.getSection('kibana')!.registerApp({

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I’m sorry, you’re right. The regression was introduced into 7.9, not 7.8. So the fix doesn’t need to be backported to 7.8. My mistake!

@sulemanof sulemanof closed this Jun 11, 2020
@sulemanof sulemanof deleted the backport/7.8/pr-68889 branch June 11, 2020 14:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants