Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8] Fix reporting link path in home feature (#68889) #68899

Closed
wants to merge 1 commit into from
Closed

[7.8] Fix reporting link path in home feature (#68889) #68899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/public/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class ReportingPublicPlugin implements Plugin<void, void> {
defaultMessage: 'Manage your reports generated from Discover, Visualize, and Dashboard.',
}),
icon: 'reportingApp',
path: '/app/kibana#/management/kibana/reporting',
path: '/app/management/insightsAndAlerting/reporting',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexwizp @cjcenizal are you sure this should be backported into 7.8 ?
It seems the section is registered in kibana

kibana/x-pack/plugins/reporting/public/plugin.tsx

Line 120 in c449252

management.sections.getSection('kibana')!.registerApp({

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I’m sorry, you’re right. The regression was introduced into 7.9, not 7.8. So the fix doesn’t need to be backported to 7.8. My mistake!

showOnHomePage: false,
category: FeatureCatalogueCategory.ADMIN,
});
Expand Down