-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rum Dashbaord] Rum selected service view #70579
Merged
shahzad31
merged 18 commits into
elastic:master
from
shahzad31:rum-selected-service-view
Jul 3, 2020
Merged
[Rum Dashbaord] Rum selected service view #70579
shahzad31
merged 18 commits into
elastic:master
from
shahzad31:rum-selected-service-view
Jul 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/apm-ui (Team:apm) |
shahzad31
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.9.0
v8.0.0
labels
Jul 2, 2020
Pinging @elastic/uptime (Team:uptime) |
smith
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Had a couple comments but nothing blocking merge.
x-pack/plugins/apm/e2e/cypress/integration/rum_dashboard.feature
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/e2e/cypress/integration/rum_dashboard.feature
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/e2e/cypress/support/step_definitions/rum/service_name_filter.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/e2e/cypress/support/step_definitions/rum/service_name_filter.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/Links/apm/RumOverviewLink.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
…rvice_name_filter.ts Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
…rvice_name_filter.ts Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: (32 commits) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) [kbn/optimizer] only build specified themes (elastic#70389) Fix saved query modal overlay (elastic#68826) Update component templates list to render empty prompt inside of content container. Show detail panel when deep-linked, even if there are no component templates. (elastic#70633) [Security Solution] Renames the `Investigate in Resolver` Timeline action (elastic#70634) fix 400 error on initial signals search (elastic#70618) [Maps] fix unable to edit heatmap metric (elastic#70606) Update network idle timeout (elastic#70629) [APM] Disable flaky useFetcher test (elastic#70638) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: (199 commits) [Telemetry] Add documentation about Application Usage (elastic#70624) [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031) Handle timeouts on creating templates (elastic#70635) [Lens] Add ability to set colors for y-axis series (elastic#70311) [Uptime] Use elastic charts donut (elastic#70364) [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687) [Composable template] Create / Edit wizard (elastic#70220) [APM] Optimize services overview (elastic#69648) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jul 3, 2020
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jul 6, 2020
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #70293
Added a selected service view for rum inside selected service. If user is inside some service view and they click RUM tab, they won't be taken out of that view, and instead will be shown data related to that service.
ON main RUM view, user will be able to change service using, service name filter.