Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rum Dashbaord] Rum selected service view #70579

Merged
merged 18 commits into from
Jul 3, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use constant for rum agent name
  • Loading branch information
shahzad31 committed Jul 1, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit b5185691860a087194b2fc965230a36cfadfb7c3
4 changes: 3 additions & 1 deletion x-pack/plugins/apm/common/agent_name.ts
Original file line number Diff line number Diff line change
@@ -30,10 +30,12 @@ export function isAgentName(agentName: string): agentName is AgentName {
return AGENT_NAMES.includes(agentName as AgentName);
}

export const RUM_AGENTS = ['js-base', 'rum-js'];

export function isRumAgentName(
agentName: string | undefined
): agentName is 'js-base' | 'rum-js' {
return agentName === 'js-base' || agentName === 'rum-js';
return RUM_AGENTS.includes(agentName);
}

export function isJavaAgentName(
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ import { RumDashboard } from './RumDashboard';
import { ServiceNameFilter } from '../../shared/LocalUIFilters/ServiceNameFilter';
import { useUrlParams } from '../../../hooks/useUrlParams';
import { useFetcher } from '../../../hooks/useFetcher';
import { RUM_AGENTS } from '../../../../common/agent_name';

export function RumOverview() {
useTrackPageview({ app: 'apm', path: 'rum_overview' });
@@ -45,7 +46,7 @@ export function RumOverview() {
query: {
start,
end,
uiFilters: JSON.stringify({ agentName: ['rum-js'] }),
uiFilters: JSON.stringify({ agentName: RUM_AGENTS }),
},
},
});