[uiActions] Support emitting nested triggers and actions #70602

Dosant · 2020-07-02T14:18:15Z

Summary

closes #59162

Needed for:

URL Drilldown MVP #69409
Possible way forward for dashboard drilldown and TSVB Drilldowns for TSVB #60611

Clean up In next PR:

"Show underlying data" to work with Apply filter trigger directly Use "Apply_filter_trigger" in "explore underlying data" action #71445
Dashboard drilldown to work with apply filter trigger directly Use "Apply_filter_trigger" in dashboard drilldown #71468

Implementation (more in #59162):

Concept of automatically executed actions
Such actions won't be batched into 1 context menu but will automatically execute. This could be useful for other reasons anyway (consider the situation of a HOVER trigger and wanting to attach it to an action that shows a tooltip and an action that shows a global threshold line - those are two actions that should be executed simultaneously, and not shown to the user in a context menu for them to choose from).
Introduce batching of emitted triggers to be execute on the next event loop.
An auto executed action can be attached to VALUE_CLICK_TRIGGER - ACTION_EMIT_APPLY_FILTER_TRIGGER. This checks to see if the data can be transformed into a Filter shape. If it does, it uiActionApi.emit(APPLY_FILTER_TRIGGER, filters). Because this is auto executed, it gets emitted before the event loop, should get batched up and then the context menu shown to the user should contain both actions attached to VALUE_CLICK_TRIGGER and actions attached to APPLY_FILTER_TRIGGER

Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

Dosant · 2020-07-03T09:11:05Z

@elasticmachine merge upstream

…iggers

elasticmachine · 2020-07-03T14:15:37Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

ppisljar

LGTM, but i suggest keeping two distinct actions which autoexecute instead of groupuing value_click and range_select triggers under one action.

src/plugins/data/public/actions/emit_apply_filter_trigger_action.ts

src/plugins/data/public/actions/select_range_action.ts

src/plugins/data/public/actions/value_click_action.ts

stacey-gammon

Like the addition of shouldAutoExecute.
Verified the example plugin was updated, with the nested action (didn't test).
Didn't pull down and test, just a quick code review.
Didn't look too deeply into UiActionsExecutionService.
Agree with Peter's remarks about not combining the two triggers.
Some public API docs look like they could use some more comments.

Overall, approach looks good. 👍

src/plugins/data/public/actions/apply_filter_action.ts

src/plugins/ui_actions/public/service/ui_actions_execution_service.ts

…iggers

…iggers # Conflicts: # src/plugins/data/public/public.api.md

streamich

LGTM, tested on Mac Chrome, I only think we should add unit tests for the new service.

src/plugins/data/public/actions/filters/create_filters_from_range_select.ts

streamich · 2020-07-14T12:24:49Z

src/plugins/data/public/actions/select_range_action.ts

-        filterManager.addFilters(restOfFilters);
-        if (timeRangeFilter) {
-          esFilters.changeTimeFilter(timeFilter, timeRangeFilter);
+    shouldAutoExecute: async () => true,


Curious, can this be

Suggested change

shouldAutoExecute: async () => true,

autoExecute: true,

? I.e. does it have to by async?

No use case now, but I thought of having it as flexible as possible from that start (doesn't add much burden). Recently had to change getHref: () => string to getHref: () => Promise<string>

src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx

src/plugins/ui_actions/public/service/ui_actions_execution_service.ts

streamich · 2020-07-14T13:13:06Z

Talked over Zoom, the new service has some integration tests covering it, so unit test can be skipped.

…iggers

kibanamachine · 2020-07-15T14:05:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c3f632d

Build metrics

miscellaneous assets size

id	value	diff	baseline
data	402.6KB	-74.0B	402.7KB
embeddable	131.3KB	+8.0B	131.2KB
uiActions	88.1KB	+1.6KB	86.4KB
upgradeAssistant	22.6KB	-1.0B	22.6KB
total	-	+1.6KB	-

page load bundle size

id	value	diff	baseline
data	1.5MB	-1.8KB	1.5MB
embeddable	446.8KB	+26.0B	446.8KB
uiActions	210.5KB	+6.9KB	203.6KB
total	-	+5.1KB	-

History

💔 Build #61864 failed afcdc85
💚 Build #61828 succeeded 2ee8e54
💚 Build #61285 succeeded acb014f
💚 Build #60832 succeeded 46efa57
💔 Build #60801 failed bb7a96b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [Form lib] Memoize form hook object and fix hook array deps (elastic#71237) [uiActions] Support emitting nested triggers and actions (elastic#70602) add short sleep before clicking Remove on sample data (elastic#71104) Fixed the beta badge layout. (elastic#71835) Restores task for downloading Chromium builds (elastic#71749) [logging] Format new platform json logging to ECS (elastic#71138) add policy details and update SO limit requests (elastic#71789) Convert vis_type_vega to Typescript (elastic#68915) [ML] Fix UI Actions context menu positioning for the Anomaly Swim Lane (elastic#71839)

* Introduce automatically executed actions * Introduce batching of emitted triggers to be execute on the macro task

…2027) * Introduce automatically executed actions * Introduce batching of emitted triggers to be execute on the macro task

Dosant added 3 commits July 2, 2020 16:05

auto actions and nested triggers

04318ce

add test

e784e0d

docs, remove redundant public api

b9e990f

Dosant added 3 commits July 3, 2020 12:31

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

0914ebb

…iggers

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

8a20273

…iggers

fix lodash usage

81b1fd3

Dosant added Team:AppArch v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Jul 3, 2020

Dosant marked this pull request as ready for review July 3, 2020 14:15

Dosant requested a review from a team as a code owner July 3, 2020 14:15

botelastic bot added the Feature:Embedding Embedding content via iFrame label Jul 3, 2020

Dosant requested review from stacey-gammon, streamich and ppisljar July 3, 2020 14:15

ppisljar approved these changes Jul 6, 2020

View reviewed changes

src/plugins/data/public/actions/emit_apply_filter_trigger_action.ts Outdated Show resolved Hide resolved

src/plugins/data/public/actions/select_range_action.ts Show resolved Hide resolved

src/plugins/data/public/actions/value_click_action.ts Show resolved Hide resolved

stacey-gammon reviewed Jul 9, 2020

View reviewed changes

src/plugins/data/public/actions/apply_filter_action.ts Outdated Show resolved Hide resolved

src/plugins/ui_actions/public/service/ui_actions_execution_service.ts Outdated Show resolved Hide resolved

Dosant added 4 commits July 13, 2020 11:59

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

b5ec2ba

…iggers

review

fb279db

fix lint

bb7a96b

fix docs

46efa57

This was referenced Jul 13, 2020

Use "Apply_filter_trigger" in "explore underlying data" action #71445

Merged

Use "Apply_filter_trigger" in dashboard drilldown #71468

Merged

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

acb014f

…iggers # Conflicts: # src/plugins/data/public/public.api.md

streamich approved these changes Jul 14, 2020

View reviewed changes

Dosant added 5 commits July 15, 2020 08:55

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

f57fcd6

…iggers

any -> BaseContext

2ee8e54

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

afcdc85

…iggers

Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…

67ad653

…iggers

fix docs

c3f632d

Dosant added v7.10.0 and removed v7.9.0 labels Jul 15, 2020

Dosant merged commit 1ac56d7 into elastic:master Jul 15, 2020

Dosant deleted the dev/nested-triggers branch July 15, 2020 14:44

Dosant mentioned this pull request Jul 16, 2020

[7.x] [uiActions] Support emitting nested triggers and actions (#70602) #72027

Merged

Dosant added a commit to Dosant/kibana that referenced this pull request Jul 16, 2020

[uiActions] Support emitting nested triggers and actions (elastic#70602)

b766101

* Introduce automatically executed actions * Introduce batching of emitted triggers to be execute on the macro task

Dosant added a commit that referenced this pull request Jul 16, 2020

[uiActions] Support emitting nested triggers and actions (#70602) (#7…

dda3a3e

…2027) * Introduce automatically executed actions * Introduce batching of emitted triggers to be execute on the macro task

Dosant mentioned this pull request Jul 21, 2020

[discuss][uiActions] How to force specific action execution? #72673

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[uiActions] Support emitting nested triggers and actions #70602

[uiActions] Support emitting nested triggers and actions #70602

Dosant commented Jul 2, 2020 •

edited

Loading

Dosant commented Jul 3, 2020

elasticmachine commented Jul 3, 2020

ppisljar left a comment

stacey-gammon left a comment

streamich left a comment

streamich Jul 14, 2020

Dosant Jul 15, 2020

streamich commented Jul 14, 2020

kibanamachine commented Jul 15, 2020

[uiActions] Support emitting nested triggers and actions #70602

[uiActions] Support emitting nested triggers and actions #70602

Conversation

Dosant commented Jul 2, 2020 • edited Loading

Summary

Implementation (more in #59162):

Checklist

Dosant commented Jul 3, 2020

elasticmachine commented Jul 3, 2020

ppisljar left a comment

Choose a reason for hiding this comment

stacey-gammon left a comment

Choose a reason for hiding this comment

streamich left a comment

Choose a reason for hiding this comment

streamich Jul 14, 2020

Choose a reason for hiding this comment

Dosant Jul 15, 2020

Choose a reason for hiding this comment

streamich commented Jul 14, 2020

kibanamachine commented Jul 15, 2020

💚 Build Succeeded

Build metrics

miscellaneous assets size

page load bundle size

History

Dosant commented Jul 2, 2020 •

edited

Loading