Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "Apply_filter_trigger" in "explore underlying data" action #71445

Merged
merged 13 commits into from
Aug 1, 2020
Merged

Use "Apply_filter_trigger" in "explore underlying data" action #71445

merged 13 commits into from
Aug 1, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jul 13, 2020 •
edited
Loading

Summary

Small clean up made possible by #70602
Refactor "explore underlying data" action to use apply filter directly

I didn't expect it would also enable this feature for maps 😅
see: #71445 (comment)

For now I disabled it to move forward with this small refactoring because of UX considerations with spatial filter.
Created to follow up: #73043

Checklist

Delete any items that are not applicable to this PR.

@Dosant Dosant requested a review from streamich July 13, 2020 13:57
@Dosant Dosant mentioned this pull request Jul 13, 2020
Merged
2 tasks
@Dosant Dosant force-pushed the dev/nested-trigger-underlying-data branch from 76c3867 to 313e546 Compare July 16, 2020 11:31
@Dosant
Copy link
Contributor Author

Dosant commented Jul 16, 2020

Dear @elastic/kibana-gis,

Recently app-arch team introduced explore underlying data action.
It navigates from visualization to Discover app. It navigates to the index pattern of the visualization and carry overs visualization's filters, query and time range.

Before this pr that action was attached to low level "value_click" and "select_range" triggers, but this pr also attaches it to higher level "apply_filter" trigger.

Since maps use "apply_filter" trigger directly, this new action didn't appear for maps before.
But now it does. This is how it looks:

Jul-16-2020 14-09-15

@elastic/kibana-gis, do you think we should leave it enabled for maps? Or should I disable it?

@Dosant Dosant added refactoring Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Jul 16, 2020
@Dosant Dosant marked this pull request as ready for review July 16, 2020 12:12
@Dosant Dosant requested a review from a team July 16, 2020 12:12
@Dosant Dosant requested a review from a team as a code owner July 16, 2020 12:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jul 16, 2020
@Dosant Dosant requested a review from a team July 16, 2020 12:12
@nreese
Copy link
Contributor

nreese commented Jul 16, 2020 •
edited
Loading

do you think we should leave it enabled for maps? Or should I disable it?

There are a couple of cases where "explore underlying data" provides an awkward user experience as is.

  1. spatial filters. Users can draw on the map to create spatial filters. In this case, the current UI appears broken because when the user if finished drawing the filter, instead of the filter being created, there is an odd looking pop-up. I think in this case, the action needs to be configured before the filter is created. Maps provides a UI before drawing to allow users to configure the filter. "explore underlying data" needs to be part of this UI and not after filter creation.

Screen Shot 2020-07-16 at 9 52 53 AM

  1. "explore underlying data" is not displayed when filtering by a property field, https://www.elastic.co/guide/en/kibana/current/maps-create-filter-from-map.html#maps-phrase-filter.

Screen Shot 2020-07-16 at 9 56 40 AM

@Dosant
Copy link
Contributor Author

Dosant commented Jul 20, 2020

Thanks @nreese for checking this out.

  1. I guess we could find a way to disable that for some cases. Do you think it is worth looking into it?

  2. Didn't find this case, for example, is this the same filter that you are referring to?

filter

Maybe you've checked that not inside map embeddable? (this functionality relies on embeddable and index pattern in embeddable output)

@nreese
Copy link
Contributor

nreese commented Jul 21, 2020

I guess we could find a way to disable that for some cases. Do you think it is worth looking into it?

For spatial filtering it really makes sense to disable this feature when the filter is added. I think the effort is worth looking into for better usability

@Dosant Dosant marked this pull request as draft July 21, 2020 14:23
@Dosant Dosant mentioned this pull request Jul 21, 2020
Closed
streamich
streamich approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for purposes of this PR we should disable this action for Maps, and address it separately. Othwerwise, LGTM, checked on Ubuntu/Chrome.

@Dosant Dosant mentioned this pull request Jul 23, 2020
Closed
Dosant added 2 commits July 23, 2020 15:04
@Dosant
Merge branch 'master' of github.com:elastic/kibana into dev/nested-tr…
db140d8 
…igger-underlying-data

# Conflicts:
#	x-pack/plugins/discover_enhanced/public/actions/explore_data/abstract_explore_data_action.ts
#	x-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_chart_action.test.ts
#	x-pack/plugins/discover_enhanced/public/actions/explore_data/explore_data_context_menu_action.test.ts
@Dosant
fix formatting
f6ee31a
@Dosant Dosant removed the request for review from a team July 23, 2020 13:16
@Dosant Dosant marked this pull request as ready for review July 23, 2020 13:17
@Dosant Dosant requested a review from kertal July 23, 2020 13:17
@Dosant
Copy link
Contributor Author

Dosant commented Jul 27, 2020

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Jul 28, 2020

@elasticmachine merge upstream

@Dosant Dosant requested review from flash1293 and removed request for kertal July 28, 2020 15:38
flash1293
flash1293 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and Firefox, still works fine for me - filters and ranges get carried over correctly. Not super familiar with the code, but Kibana app changes look sensible to me (I like how we don't need the embeddable service anymore)

@Dosant
Copy link
Contributor Author

Dosant commented Jul 31, 2020

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Aug 1, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
discoverEnhanced 29.4KB +1.9KB 27.5KB
embeddable 428.7KB -3.0KB 431.7KB
total - -1.2KB -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 56e51bd into elastic:master Aug 1, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Aug 1, 2020
@Dosant @elasticmachine
Use "Apply_filter_trigger" in "explore underlying data" action (elast…
17687ce 
…ic#71445)

* use apply filter trigger for “expore underlying data”
* disable for maps for now

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Dosant Dosant mentioned this pull request Aug 1, 2020
Merged
Dosant added a commit that referenced this pull request Aug 1, 2020
@Dosant @elasticmachine
Use "Apply_filter_trigger" in "explore underlying data" action (#71445)…
e9c01e9 
… (#74045)

* use apply filter trigger for “expore underlying data”
* disable for maps for now

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
@Dosant Dosant mentioned this pull request Aug 4, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame Feature:UIActions UI actions. These are client side only, not related to the server side actions.. refactoring release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dosant @elasticmachine @nreese @kibanamachine @flash1293 @streamich