Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] [Lens] 7.9 docs refresh #72301

Merged
merged 3 commits into from
Jul 29, 2020
Merged

[DOCS] [Lens] 7.9 docs refresh #72301

merged 3 commits into from
Jul 29, 2020

Conversation

KOTungseth
Copy link
Contributor

Summary

This PR:

Checklist

  • Documentation was added for features that require explanation or tutorials

@KOTungseth KOTungseth added Team:Docs release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.10.0 v7.9.0 labels Jul 17, 2020
@KOTungseth KOTungseth self-assigned this Jul 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@wylieconlon
Copy link
Contributor

Preview build is ready https://kibana_72301.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html

mbondyra
mbondyra reviewed Jul 17, 2020
View reviewed changes
docs/visualize/lens.asciidoc Outdated

[float]
[[layers]]
==== Add layers and indices

Bar, line, and area charts allow you to visualize multiple data layers and indices so that you can compare and analyze data from multiple sources.
X and y charts allow you to visualize multiple data layers and indices so that you can compare and analyze data from multiple sources.
Copy link
Contributor

@mbondyra mbondyra Jul 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if 'X and y charts' is clear enough. The name 'XY Chart' is reserved for scatter chart so we cannot use it either. But still 'XY Chart' is very close to 'X and y charts' and it can cause some confusion.

I don't have a good idea though except for leaving it as it was before.
(still, not native speaker opinion, I might be wrong)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Visualize docs refresh, we are renaming these three chart types "XY charts", so I'm changing here for consistency. I agree that XY charts is a bit vague, but I was told this a common term. I'm open to other suggestions!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to list the separate chart types? If we're going to group them, they are often grouped together as "XY charts," but not as "X and Y charts".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all really good points. I'm going to take Marta's original advice and list them all out. I'll do the same in the Visualize docs refresh.

wylieconlon
wylieconlon reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the image quality on docs/visualize/images/lens_aggregation_labels.png to be low, is that just me?

wylieconlon
wylieconlon reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the stacked area chart shown in the tutorial has gaps in the data: maybe you can pick a different dataset to screenshot, without gaps?

@KOTungseth KOTungseth merged commit 71badc6 into elastic:master Jul 29, 2020
@KOTungseth KOTungseth deleted the docs/lens-79 branch July 29, 2020 15:40
@KOTungseth KOTungseth mentioned this pull request Jul 29, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Jul 29, 2020
@KOTungseth
[DOCS] [Lens] 7.9 docs refresh (elastic#72301)
18c13fd 
* [DOCS] Lens refresh for 7.9

* Clean up

* Review comments from Wylie
@KOTungseth KOTungseth mentioned this pull request Jul 29, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Jul 29, 2020
@KOTungseth
[DOCS] [Lens] 7.9 docs refresh (elastic#72301)
4f60ffd 
* [DOCS] Lens refresh for 7.9

* Clean up

* Review comments from Wylie
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
KOTungseth added a commit that referenced this pull request Jul 29, 2020
@KOTungseth
[DOCS] [Lens] 7.9 docs refresh (#72301) (#73691)
e33f18e 
* [DOCS] Lens refresh for 7.9

* Clean up

* Review comments from Wylie
KOTungseth added a commit that referenced this pull request Jul 29, 2020
@KOTungseth
[DOCS] [Lens] 7.9 docs refresh (#72301) (#73692)
2d64ef0 
* [DOCS] Lens refresh for 7.9

* Clean up

* Review comments from Wylie
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon left review comments

@mbondyra mbondyra mbondyra approved these changes

Assignees

@KOTungseth KOTungseth

Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.9.0 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Update screenshots in docs for 7.9
4 participants
@KOTungseth @elasticmachine @wylieconlon @mbondyra