Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Add tooltips #73436

Merged
merged 7 commits into from
Jul 29, 2020
Merged

[Security Solutions] Add tooltips #73436

merged 7 commits into from
Jul 29, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jul 28, 2020 •
edited
Loading

Summary

This PR adds three tooltips. The first two are tooltips for the attaching to a case buttons. The third tooltip is for the Upload value lists button in the Detections page.

Timeline:
Screenshot 2020-07-28 at 3 08 31 PM

Screenshot 2020-07-28 at 3 08 38 PM

Detections:

Screenshot 2020-07-28 at 3 19 53 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 28, 2020
@cnasikas cnasikas requested review from a team as code owners July 28, 2020 12:21
@cnasikas cnasikas self-assigned this Jul 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

andrew-goldstein
andrew-goldstein reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should have a different tooltip to represent the state when the actions are enabled?

For example, when the timeline does not have a title (and the actions are disabled), the tooltip prompts the user to take action, Please provide a title for your timeline in order to attach it to a case, per the screenshot below:

tooltip-disabeld

After taking the prescribed action to provide a title, the actions become enabled, but per the screenshot below, the tooltip still suggests Please provide a title for your timeline in order to attach it to a case, a that task has already been accomplished:

tooltip-enabled

@cnasikas
Copy link
Member Author

cnasikas commented Jul 28, 2020 •
edited
Loading

Do you think we should have a different tooltip to represent the state when the actions are enabled?

For example, when the timeline does not have a title (and the actions are disabled), the tooltip prompts the user to take action, Please provide a title for your timeline in order to attach it to a case, per the screenshot below:

tooltip-disabeld

After taking the prescribed action to provide a title, the actions become enabled, but per the screenshot below, the tooltip still suggests Please provide a title for your timeline in order to attach it to a case, a that task has already been accomplished:

tooltip-enabled

You are right! I think is best to not have a tooltip when the actions become enabled.

andrew-goldstein
andrew-goldstein approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this helpful tooltip @cnasikas! 🙏
Desk tested locally
LGTM 🚀

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +1.5KB 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit b729446 into elastic:master Jul 29, 2020
@andrew-goldstein andrew-goldstein mentioned this pull request Jul 29, 2020
Merged
andrew-goldstein pushed a commit to andrew-goldstein/kibana that referenced this pull request Jul 29, 2020
@cnasikas @andrew-goldstein
[Security Solutions] Add tooltips (elastic#73436)
c78ce5f 
## Summary

This PR adds three tooltips. The first two are tooltips for the `attaching to a case` buttons. The third tooltip is for the `Upload value lists` button in the `Detections` page.

**Timeline:**
<img width="672" alt="Screenshot 2020-07-28 at 3 08 31 PM" src="https://user-images.githubusercontent.com/7871006/88664558-e79aee00-d0e5-11ea-9644-48480c194498.png">

<img width="673" alt="Screenshot 2020-07-28 at 3 08 38 PM" src="https://user-images.githubusercontent.com/7871006/88664552-e49ffd80-d0e5-11ea-8d9e-2910f58332d4.png">

**Detections:**

<img width="639" alt="Screenshot 2020-07-28 at 3 19 53 PM" src="https://user-images.githubusercontent.com/7871006/88664531-dce05900-d0e5-11ea-9dcd-7e336f215e40.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@andrew-goldstein andrew-goldstein mentioned this pull request Jul 29, 2020
Merged
andrew-goldstein pushed a commit to andrew-goldstein/kibana that referenced this pull request Jul 29, 2020
@cnasikas @andrew-goldstein
[Security Solutions] Add tooltips (elastic#73436)
cd0bd9e 
## Summary

This PR adds three tooltips. The first two are tooltips for the `attaching to a case` buttons. The third tooltip is for the `Upload value lists` button in the `Detections` page.

**Timeline:**
<img width="672" alt="Screenshot 2020-07-28 at 3 08 31 PM" src="https://user-images.githubusercontent.com/7871006/88664558-e79aee00-d0e5-11ea-9644-48480c194498.png">

<img width="673" alt="Screenshot 2020-07-28 at 3 08 38 PM" src="https://user-images.githubusercontent.com/7871006/88664552-e49ffd80-d0e5-11ea-8d9e-2910f58332d4.png">

**Detections:**

<img width="639" alt="Screenshot 2020-07-28 at 3 19 53 PM" src="https://user-images.githubusercontent.com/7871006/88664531-dce05900-d0e5-11ea-9dcd-7e336f215e40.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
andrew-goldstein added a commit that referenced this pull request Jul 29, 2020
@andrew-goldstein @cnasikas
[Security Solutions] Add tooltips (#73436) (#73628)
35734e5 
## Summary

This PR adds three tooltips. The first two are tooltips for the `attaching to a case` buttons. The third tooltip is for the `Upload value lists` button in the `Detections` page.

**Timeline:**
<img width="672" alt="Screenshot 2020-07-28 at 3 08 31 PM" src="https://user-images.githubusercontent.com/7871006/88664558-e79aee00-d0e5-11ea-9644-48480c194498.png">

<img width="673" alt="Screenshot 2020-07-28 at 3 08 38 PM" src="https://user-images.githubusercontent.com/7871006/88664552-e49ffd80-d0e5-11ea-8d9e-2910f58332d4.png">

**Detections:**

<img width="639" alt="Screenshot 2020-07-28 at 3 19 53 PM" src="https://user-images.githubusercontent.com/7871006/88664531-dce05900-d0e5-11ea-9dcd-7e336f215e40.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
cnasikas added a commit that referenced this pull request Jul 29, 2020
@andrew-goldstein @cnasikas @elasticmachine
[7.x] [Security Solutions] Add tooltips (#73436) (#73627)
9ed8227 
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@stephmilovic stephmilovic Awaiting requested review from stephmilovic

@MikePaquette MikePaquette Awaiting requested review from MikePaquette

Assignees

@cnasikas cnasikas

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cnasikas @elasticmachine @andrew-goldstein @kibanamachine @patrykkopycinski @MindyRS